LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-03-08 06:54:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(memory): dedupe readonly recovery test scenarios

Browse Source
This commit is contained in:
Peter Steinberger
2026-03-03 02:47:23 +00:00
parent 3ff0cf262d
commit 55c128ddc2
1 changed files with 20 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/memory/manager.readonly-recovery.test.ts
View File

@@ -58,6 +58,18 @@ describe("memory manager readonly recovery", () => {
});
}
async function expectReadonlyRetry(params: { firstError: unknown; expectedLastError: string }) {
const currentManager = await createManager();
const { runSyncSpy, openDatabaseSpy } = createSyncSpies(currentManager);
runSyncSpy.mockRejectedValueOnce(params.firstError).mockResolvedValueOnce(undefined);
await currentManager.sync({ reason: "test" });
expect(runSyncSpy).toHaveBeenCalledTimes(2);
expect(openDatabaseSpy).toHaveBeenCalledTimes(1);
expectReadonlyRecoveryStatus(params.expectedLastError);
}
beforeEach(async () => {
resetEmbeddingMocks();
workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-mem-readonly-"));
@@ -75,31 +87,17 @@ describe("memory manager readonly recovery", () => {
});
it("reopens sqlite and retries once when sync hits SQLITE_READONLY", async () => {
const currentManager = await createManager();
const { runSyncSpy, openDatabaseSpy } = createSyncSpies(currentManager);
runSyncSpy
.mockRejectedValueOnce(new Error("attempt to write a readonly database"))
.mockResolvedValueOnce(undefined);
await currentManager.sync({ reason: "test" });
expect(runSyncSpy).toHaveBeenCalledTimes(2);
expect(openDatabaseSpy).toHaveBeenCalledTimes(1);
expectReadonlyRecoveryStatus("attempt to write a readonly database");
await expectReadonlyRetry({
firstError: new Error("attempt to write a readonly database"),
expectedLastError: "attempt to write a readonly database",
});
});
it("reopens sqlite and retries when readonly appears in error code", async () => {
const currentManager = await createManager();
const { runSyncSpy, openDatabaseSpy } = createSyncSpies(currentManager);
runSyncSpy
.mockRejectedValueOnce({ message: "write failed", code: "SQLITE_READONLY" })
.mockResolvedValueOnce(undefined);
await currentManager.sync({ reason: "test" });
expect(runSyncSpy).toHaveBeenCalledTimes(2);
expect(openDatabaseSpy).toHaveBeenCalledTimes(1);
expectReadonlyRecoveryStatus("write failed");
await expectReadonlyRetry({
firstError: { message: "write failed", code: "SQLITE_READONLY" },
expectedLastError: "write failed",
});
});
it("does not retry non-readonly sync errors", async () => {