From 55c128ddc2322538608378b20ebfea485c672b1d Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Tue, 3 Mar 2026 02:47:23 +0000
Subject: [PATCH] refactor(memory): dedupe readonly recovery test scenarios

---
 src/memory/manager.readonly-recovery.test.ts | 42 ++++++++++----------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/src/memory/manager.readonly-recovery.test.ts b/src/memory/manager.readonly-recovery.test.ts
index 35f37cf8371..c6a566468bb 100644
--- a/src/memory/manager.readonly-recovery.test.ts
+++ b/src/memory/manager.readonly-recovery.test.ts
@@ -58,6 +58,18 @@ describe("memory manager readonly recovery", () => {
     });
   }
 
+  async function expectReadonlyRetry(params: { firstError: unknown; expectedLastError: string }) {
+    const currentManager = await createManager();
+    const { runSyncSpy, openDatabaseSpy } = createSyncSpies(currentManager);
+    runSyncSpy.mockRejectedValueOnce(params.firstError).mockResolvedValueOnce(undefined);
+
+    await currentManager.sync({ reason: "test" });
+
+    expect(runSyncSpy).toHaveBeenCalledTimes(2);
+    expect(openDatabaseSpy).toHaveBeenCalledTimes(1);
+    expectReadonlyRecoveryStatus(params.expectedLastError);
+  }
+
   beforeEach(async () => {
     resetEmbeddingMocks();
     workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-mem-readonly-"));
@@ -75,31 +87,17 @@ describe("memory manager readonly recovery", () => {
   });
 
   it("reopens sqlite and retries once when sync hits SQLITE_READONLY", async () => {
-    const currentManager = await createManager();
-    const { runSyncSpy, openDatabaseSpy } = createSyncSpies(currentManager);
-    runSyncSpy
-      .mockRejectedValueOnce(new Error("attempt to write a readonly database"))
-      .mockResolvedValueOnce(undefined);
-
-    await currentManager.sync({ reason: "test" });
-
-    expect(runSyncSpy).toHaveBeenCalledTimes(2);
-    expect(openDatabaseSpy).toHaveBeenCalledTimes(1);
-    expectReadonlyRecoveryStatus("attempt to write a readonly database");
+    await expectReadonlyRetry({
+      firstError: new Error("attempt to write a readonly database"),
+      expectedLastError: "attempt to write a readonly database",
+    });
   });
 
   it("reopens sqlite and retries when readonly appears in error code", async () => {
-    const currentManager = await createManager();
-    const { runSyncSpy, openDatabaseSpy } = createSyncSpies(currentManager);
-    runSyncSpy
-      .mockRejectedValueOnce({ message: "write failed", code: "SQLITE_READONLY" })
-      .mockResolvedValueOnce(undefined);
-
-    await currentManager.sync({ reason: "test" });
-
-    expect(runSyncSpy).toHaveBeenCalledTimes(2);
-    expect(openDatabaseSpy).toHaveBeenCalledTimes(1);
-    expectReadonlyRecoveryStatus("write failed");
+    await expectReadonlyRetry({
+      firstError: { message: "write failed", code: "SQLITE_READONLY" },
+      expectedLastError: "write failed",
+    });
   });
 
   it("does not retry non-readonly sync errors", async () => {