LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-05-13 15:47:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: clear model picker broad matchers

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-10 11:05:11 +01:00
parent a7aa5d98e3
commit f72a520f7b
1 changed files with 103 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

188
src/commands/model-picker.test.ts
View File

@@ -163,6 +163,54 @@ function configuredTextModel(id: string, name: string) {
};
}
type MockCallSource = {
mock: {
calls: ArrayLike<ReadonlyArray<unknown>>;
};
};
function requireRecord(value: unknown, label: string): Record<string, unknown> {
expect(value, label).toBeTypeOf("object");
expect(value, label).not.toBeNull();
return value as Record<string, unknown>;
}
function mockArg(source: MockCallSource, callIndex: number, argIndex: number, label: string) {
const call = source.mock.calls[callIndex];
if (!call) {
throw new Error(`expected mock call: ${label}`);
}
return call[argIndex];
}
function pickerParams(source: MockCallSource, callIndex = 0) {
return requireRecord(mockArg(source, callIndex, 0, `picker call ${callIndex}`), "picker params");
}
function pickerOptions(source: MockCallSource, callIndex = 0) {
const options = pickerParams(source, callIndex).options;
expect(options, "picker options").toBeInstanceOf(Array);
return options as Array<Record<string, unknown>>;
}
function optionValues(options: Array<Record<string, unknown>>) {
return options.map((option) => option.value);
}
function requireOption(options: Array<Record<string, unknown>>, value: string) {
const option = options.find((candidate) => candidate.value === value);
if (!option) {
throw new Error(`expected picker option: ${value}`);
}
return option;
}
function providerCallProviders() {
return resolveOwningPluginIdsForProvider.mock.calls.map(
([params]) => requireRecord(params, "provider ownership params").provider,
);
}
beforeEach(() => {
vi.clearAllMocks();
loadStaticManifestCatalogRowsForList.mockReturnValue([]);
@@ -210,19 +258,11 @@ describe("promptDefaultModel", () => {
ignoreAllowlist: true,
});
const options = select.mock.calls[0]?.[0]?.options ?? [];
expect(options).toEqual(
expect.arrayContaining([
expect.objectContaining({
value: "openai/gpt-5.5",
hint: expect.stringContaining("Codex runtime route"),
}),
expect.objectContaining({
value: "openai-codex/gpt-5.5",
hint: expect.stringContaining("legacy Codex OAuth route"),
}),
]),
);
const options = pickerOptions(select as MockCallSource);
const canonical = requireOption(options, "openai/gpt-5.5");
expect(canonical.hint).toContain("Codex runtime route");
const legacy = requireOption(options, "openai-codex/gpt-5.5");
expect(legacy.hint).toContain("legacy Codex OAuth route");
});
it("hides unauthenticated catalog entries from default model choices", async () => {
@@ -324,14 +364,15 @@ describe("promptDefaultModel", () => {
});
expect(result.model).toBe("google/gemini-3.1-pro-preview");
expect(select.mock.calls[0]?.[0]?.options).toEqual([
expect.objectContaining({ value: "google/gemini-3.1-pro-preview" }),
expect(optionValues(pickerOptions(select as MockCallSource))).toEqual([
"google/gemini-3.1-pro-preview",
]);
expect(runProviderModelSelectedHook).toHaveBeenCalledWith(
expect.objectContaining({
model: "google/gemini-3.1-pro-preview",
}),
);
expect(
requireRecord(
mockArg(runProviderModelSelectedHook as MockCallSource, 0, 0, "provider selected hook"),
"provider selected hook params",
).model,
).toBe("google/gemini-3.1-pro-preview");
});
it("uses configured provider models for default picker without loading the full catalog in replace mode", async () => {
@@ -364,12 +405,11 @@ describe("promptDefaultModel", () => {
});
expect(loadModelCatalog).not.toHaveBeenCalled();
expect(select.mock.calls[0]?.[0]?.options).toEqual([
expect.objectContaining({
value: "minimax/MiniMax-M2.7-highspeed",
hint: expect.stringContaining("MiniMax M2.7 Highspeed"),
}),
]);
const minimaxOption = requireOption(
pickerOptions(select as MockCallSource),
"minimax/MiniMax-M2.7-highspeed",
);
expect(minimaxOption.hint).toContain("MiniMax M2.7 Highspeed");
expect(result.model).toBe("minimax/MiniMax-M2.7-highspeed");
});
@@ -412,12 +452,8 @@ describe("promptDefaultModel", () => {
expect(optionValues[1]).toBe("byteplus-plan/ark-code-latest");
expect(select.mock.calls[0]?.[0]?.initialValue).toBe("byteplus-plan/ark-code-latest");
expect(result.model).toBe("byteplus-plan/ark-code-latest");
expect(resolveOwningPluginIdsForProvider).toHaveBeenCalledWith(
expect.objectContaining({ provider: "byteplus" }),
);
expect(resolveOwningPluginIdsForProvider).toHaveBeenCalledWith(
expect.objectContaining({ provider: "byteplus-plan" }),
);
expect(providerCallProviders()).toContain("byteplus");
expect(providerCallProviders()).toContain("byteplus-plan");
});
it("shows literal double-prefix labels for providers that preserve literal prefixes", async () => {
@@ -453,18 +489,12 @@ describe("promptDefaultModel", () => {
ignoreAllowlist: true,
});
const options = select.mock.calls[0]?.[0]?.options ?? [];
expect(options).toEqual(
expect.arrayContaining([
expect.objectContaining({
value: "__keep__",
label: "Keep current (nvidia/nvidia/nemotron-3-super-120b-a12b)",
}),
expect.objectContaining({
value: "nvidia/nemotron-3-super-120b-a12b",
label: "nvidia/nvidia/nemotron-3-super-120b-a12b",
}),
]),
const options = pickerOptions(select as MockCallSource);
expect(requireOption(options, "__keep__").label).toBe(
"Keep current (nvidia/nvidia/nemotron-3-super-120b-a12b)",
);
expect(requireOption(options, "nvidia/nemotron-3-super-120b-a12b").label).toBe(
"nvidia/nvidia/nemotron-3-super-120b-a12b",
);
});
@@ -498,18 +528,14 @@ describe("promptDefaultModel", () => {
expect(result).toStrictEqual({});
expect(loadModelCatalog).not.toHaveBeenCalled();
expect(select.mock.calls[0]?.[0]).toMatchObject({
searchable: false,
initialValue: "__keep__",
});
expect(select.mock.calls[0]?.[0]?.options).toEqual([
expect.objectContaining({
value: "__keep__",
label: "Keep current (nvidia/nvidia/nemotron-3-super-120b-a12b)",
}),
expect.objectContaining({ value: "__manual__" }),
expect.objectContaining({ value: "__browse__" }),
]);
const params = pickerParams(select as MockCallSource);
expect(params.searchable).toBe(false);
expect(params.initialValue).toBe("__keep__");
const options = pickerOptions(select as MockCallSource);
expect(optionValues(options)).toEqual(["__keep__", "__manual__", "__browse__"]);
expect(requireOption(options, "__keep__").label).toBe(
"Keep current (nvidia/nvidia/nemotron-3-super-120b-a12b)",
);
});
it("keeps current preferred-provider models cold until browsing is requested", async () => {
@@ -535,14 +561,13 @@ describe("promptDefaultModel", () => {
expect(result).toStrictEqual({});
expect(loadModelCatalog).not.toHaveBeenCalled();
expect(select.mock.calls[0]?.[0]).toMatchObject({
searchable: false,
initialValue: "__keep__",
});
expect(select.mock.calls[0]?.[0]?.options).toEqual([
expect.objectContaining({ value: "__keep__" }),
expect.objectContaining({ value: "__manual__" }),
expect.objectContaining({ value: "__browse__" }),
const params = pickerParams(select as MockCallSource);
expect(params.searchable).toBe(false);
expect(params.initialValue).toBe("__keep__");
expect(optionValues(pickerOptions(select as MockCallSource))).toEqual([
"__keep__",
"__manual__",
"__browse__",
]);
});
@@ -656,7 +681,7 @@ describe("promptDefaultModel", () => {
mode: "setup",
});
expect(result.model).toBe("vllm/meta-llama/Meta-Llama-3-8B-Instruct");
expect(result.config?.models?.providers?.vllm).toMatchObject({
expect(result.config?.models?.providers?.vllm).toEqual({
baseUrl: "http://127.0.0.1:8000/v1",
api: "openai-completions",
apiKey: "VLLM_API_KEY", // pragma: allowlist secret
@@ -713,12 +738,9 @@ describe("promptDefaultModel", () => {
});
expect(providerModelPickerContributionRuntime.resolve).toHaveBeenCalledOnce();
expect(select.mock.calls[0]?.[0]?.options).toEqual(
expect.arrayContaining([expect.objectContaining({ value: "ollama", label: "Ollama" })]),
);
expect(select.mock.calls[0]?.[0]?.options).not.toEqual(
expect.arrayContaining([expect.objectContaining({ value: "legacy-entry" })]),
);
const options = pickerOptions(select as MockCallSource);
expect(requireOption(options, "ollama").label).toBe("Ollama");
expect(optionValues(options)).not.toContain("legacy-entry");
});
it("keeps skip-auth model selection cold when catalog loading is disabled", async () => {
@@ -748,10 +770,10 @@ describe("promptDefaultModel", () => {
expect(loadModelCatalog).not.toHaveBeenCalled();
expect(resolveProviderModelPickerEntries).not.toHaveBeenCalled();
expect(providerModelPickerContributionRuntime.resolve).not.toHaveBeenCalled();
expect(select.mock.calls[0]?.[0]?.options).toEqual([
expect.objectContaining({ value: "__keep__" }),
expect.objectContaining({ value: "__manual__" }),
expect.objectContaining({ value: "openai/gpt-5.5" }),
expect(optionValues(pickerOptions(select as MockCallSource))).toEqual([
"__keep__",
"__manual__",
"openai/gpt-5.5",
]);
});
@@ -796,14 +818,10 @@ describe("promptDefaultModel", () => {
runtime: {} as never,
});
expect(select.mock.calls[0]?.[0]?.options).toEqual(
expect.arrayContaining([
expect.objectContaining({
value: "provider-plugin:nvidia:api-key",
label: "NVIDIA (custom)",
}),
]),
);
expect(
requireOption(pickerOptions(select as MockCallSource), "provider-plugin:nvidia:api-key")
.label,
).toBe("NVIDIA (custom)");
});
});
@@ -1221,8 +1239,8 @@ describe("promptModelAllowlist", () => {
});
expect(loadModelCatalog).not.toHaveBeenCalled();
expect(multiselect.mock.calls[0]?.[0]?.options).toEqual([
expect.objectContaining({ value: "openai-codex/gpt-5.5" }),
expect(optionValues(pickerOptions(multiselect as MockCallSource))).toEqual([
"openai-codex/gpt-5.5",
]);
expect(multiselect.mock.calls[0]?.[0]?.initialValues).toEqual(["openai-codex/gpt-5.5"]);
expect(result).toEqual({