LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-05-17 02:37:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: guard secrets channel collector calls

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-11 22:32:27 +01:00
parent f1ccfd87b9
commit e241aedbcf
2 changed files with 45 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/secrets/runtime-config-collectors-channels.test.ts
View File

@@ -13,6 +13,23 @@ vi.mock("./channel-contract-api.js", () => ({
loadChannelSecretContractApi,
}));
function requireLoadChannelSecretContractApiCall(): {
channelId?: unknown;
config?: unknown;
env?: unknown;
loadablePluginOrigins?: unknown;
} {
const [call] = loadChannelSecretContractApi.mock.calls;
if (!call) {
throw new Error("expected loadChannelSecretContractApi call");
}
const [params] = call;
if (typeof params !== "object" || params === null || Array.isArray(params)) {
throw new Error("expected loadChannelSecretContractApi params to be an object");
}
return params;
}
describe("runtime channel config collectors", () => {
beforeEach(() => {
getBootstrapChannelSecrets.mockReset();
@@ -43,11 +60,11 @@ describe("runtime channel config collectors", () => {
context: {} as ResolverContext,
});
const loadCall = loadChannelSecretContractApi.mock.calls[0]?.[0];
expect(loadCall?.channelId).toBe("imessage");
expect(loadCall?.config).toBe(config);
expect(loadCall?.env).toBeUndefined();
expect(loadCall?.loadablePluginOrigins).toBeUndefined();
const loadCall = requireLoadChannelSecretContractApiCall();
expect(loadCall.channelId).toBe("imessage");
expect(loadCall.config).toBe(config);
expect(loadCall.env).toBeUndefined();
expect(loadCall.loadablePluginOrigins).toBeUndefined();
expect(collectRuntimeConfigAssignments).toHaveBeenCalledOnce();
expect(getBootstrapChannelSecrets).not.toHaveBeenCalled();
});
@@ -72,11 +89,11 @@ describe("runtime channel config collectors", () => {
context: {} as ResolverContext,
});
const loadCall = loadChannelSecretContractApi.mock.calls[0]?.[0];
expect(loadCall?.channelId).toBe("legacy");
expect(loadCall?.config).toBe(config);
expect(loadCall?.env).toBeUndefined();
expect(loadCall?.loadablePluginOrigins).toBeUndefined();
const loadCall = requireLoadChannelSecretContractApiCall();
expect(loadCall.channelId).toBe("legacy");
expect(loadCall.config).toBe(config);
expect(loadCall.env).toBeUndefined();
expect(loadCall.loadablePluginOrigins).toBeUndefined();
expect(getBootstrapChannelSecrets).toHaveBeenCalledWith("legacy");
expect(collectRuntimeConfigAssignments).toHaveBeenCalledOnce();
});

21
src/secrets/runtime-external-channel-origin-discovery.test.ts
View File

@@ -28,6 +28,21 @@ function requireDiscordConfig(snapshot: Awaited<ReturnType<typeof prepareSecrets
return config;
}
function requireLoadChannelSecretContractApiCall(): {
channelId?: unknown;
loadablePluginOrigins?: unknown;
} {
const [call] = loadChannelSecretContractApiMock.mock.calls;
if (!call) {
throw new Error("expected loadChannelSecretContractApi call");
}
const [params] = call;
if (typeof params !== "object" || params === null || Array.isArray(params)) {
throw new Error("expected loadChannelSecretContractApi params to be an object");
}
return params;
}
describe("secrets runtime external channel origin discovery", () => {
it("discovers loadable plugins for channel SecretRefs when plugins.entries is absent", async () => {
loadPluginMetadataSnapshotMock.mockReturnValue({
@@ -78,8 +93,8 @@ describe("secrets runtime external channel origin discovery", () => {
expect(requireDiscordConfig(snapshot).token).toBe("resolved-discord-token");
expect(loadPluginMetadataSnapshotMock).toHaveBeenCalled();
const loadCall = loadChannelSecretContractApiMock.mock.calls[0]?.[0];
expect(loadCall?.channelId).toBe("discord");
expect(loadCall?.loadablePluginOrigins).toEqual(new Map([["discord", "global"]]));
const loadCall = requireLoadChannelSecretContractApiCall();
expect(loadCall.channelId).toBe("discord");
expect(loadCall.loadablePluginOrigins).toEqual(new Map([["discord", "global"]]));
});
});