fix(ios): split watch notify normalization helpers

Co-authored-by: Mariano Belinky <mbelinky@gmail.com>
This commit is contained in:
Peter Steinberger
2026-02-24 14:36:06 +00:00
parent 4ec0af00fe
commit 80daaeba38
2 changed files with 103 additions and 99 deletions

View File

@@ -0,0 +1,103 @@
import Foundation
import OpenClawKit
extension NodeAppModel {
static func normalizeWatchNotifyParams(_ params: OpenClawWatchNotifyParams) -> OpenClawWatchNotifyParams {
var normalized = params
normalized.title = params.title.trimmingCharacters(in: .whitespacesAndNewlines)
normalized.body = params.body.trimmingCharacters(in: .whitespacesAndNewlines)
normalized.promptId = self.trimmedOrNil(params.promptId)
normalized.sessionKey = self.trimmedOrNil(params.sessionKey)
normalized.kind = self.trimmedOrNil(params.kind)
normalized.details = self.trimmedOrNil(params.details)
normalized.priority = self.normalizedWatchPriority(params.priority, risk: params.risk)
normalized.risk = self.normalizedWatchRisk(params.risk, priority: normalized.priority)
let normalizedActions = self.normalizeWatchActions(
params.actions,
kind: normalized.kind,
promptId: normalized.promptId)
normalized.actions = normalizedActions.isEmpty ? nil : normalizedActions
return normalized
}
static func normalizeWatchActions(
_ actions: [OpenClawWatchAction]?,
kind: String?,
promptId: String?) -> [OpenClawWatchAction]
{
let provided = (actions ?? []).compactMap { action -> OpenClawWatchAction? in
let id = action.id.trimmingCharacters(in: .whitespacesAndNewlines)
let label = action.label.trimmingCharacters(in: .whitespacesAndNewlines)
guard !id.isEmpty, !label.isEmpty else { return nil }
return OpenClawWatchAction(
id: id,
label: label,
style: self.trimmedOrNil(action.style))
}
if !provided.isEmpty {
return Array(provided.prefix(4))
}
// Only auto-insert quick actions when this is a prompt/decision flow.
guard promptId?.isEmpty == false else {
return []
}
let normalizedKind = kind?.trimmingCharacters(in: .whitespacesAndNewlines).lowercased() ?? ""
if normalizedKind.contains("approval") || normalizedKind.contains("approve") {
return [
OpenClawWatchAction(id: "approve", label: "Approve"),
OpenClawWatchAction(id: "decline", label: "Decline", style: "destructive"),
OpenClawWatchAction(id: "open_phone", label: "Open iPhone"),
OpenClawWatchAction(id: "escalate", label: "Escalate"),
]
}
return [
OpenClawWatchAction(id: "done", label: "Done"),
OpenClawWatchAction(id: "snooze_10m", label: "Snooze 10m"),
OpenClawWatchAction(id: "open_phone", label: "Open iPhone"),
OpenClawWatchAction(id: "escalate", label: "Escalate"),
]
}
static func normalizedWatchRisk(
_ risk: OpenClawWatchRisk?,
priority: OpenClawNotificationPriority?) -> OpenClawWatchRisk?
{
if let risk { return risk }
switch priority {
case .passive:
return .low
case .active:
return .medium
case .timeSensitive:
return .high
case nil:
return nil
}
}
static func normalizedWatchPriority(
_ priority: OpenClawNotificationPriority?,
risk: OpenClawWatchRisk?) -> OpenClawNotificationPriority?
{
if let priority { return priority }
switch risk {
case .low:
return .passive
case .medium:
return .active
case .high:
return .timeSensitive
case nil:
return nil
}
}
static func trimmedOrNil(_ value: String?) -> String? {
let trimmed = value?.trimmingCharacters(in: .whitespacesAndNewlines) ?? ""
return trimmed.isEmpty ? nil : trimmed
}
}

View File

@@ -1536,105 +1536,6 @@ private extension NodeAppModel {
}
}
private static func normalizeWatchNotifyParams(_ params: OpenClawWatchNotifyParams) -> OpenClawWatchNotifyParams {
var normalized = params
normalized.title = params.title.trimmingCharacters(in: .whitespacesAndNewlines)
normalized.body = params.body.trimmingCharacters(in: .whitespacesAndNewlines)
normalized.promptId = self.trimmedOrNil(params.promptId)
normalized.sessionKey = self.trimmedOrNil(params.sessionKey)
normalized.kind = self.trimmedOrNil(params.kind)
normalized.details = self.trimmedOrNil(params.details)
normalized.priority = self.normalizedWatchPriority(params.priority, risk: params.risk)
normalized.risk = self.normalizedWatchRisk(params.risk, priority: normalized.priority)
let normalizedActions = self.normalizeWatchActions(
params.actions,
kind: normalized.kind,
promptId: normalized.promptId)
normalized.actions = normalizedActions.isEmpty ? nil : normalizedActions
return normalized
}
private static func normalizeWatchActions(
_ actions: [OpenClawWatchAction]?,
kind: String?,
promptId: String?) -> [OpenClawWatchAction]
{
let provided = (actions ?? []).compactMap { action -> OpenClawWatchAction? in
let id = action.id.trimmingCharacters(in: .whitespacesAndNewlines)
let label = action.label.trimmingCharacters(in: .whitespacesAndNewlines)
guard !id.isEmpty, !label.isEmpty else { return nil }
return OpenClawWatchAction(
id: id,
label: label,
style: self.trimmedOrNil(action.style))
}
if !provided.isEmpty {
return Array(provided.prefix(4))
}
// Only auto-insert quick actions when this is a prompt/decision flow.
guard promptId?.isEmpty == false else {
return []
}
let normalizedKind = kind?.trimmingCharacters(in: .whitespacesAndNewlines).lowercased() ?? ""
if normalizedKind.contains("approval") || normalizedKind.contains("approve") {
return [
OpenClawWatchAction(id: "approve", label: "Approve"),
OpenClawWatchAction(id: "decline", label: "Decline", style: "destructive"),
OpenClawWatchAction(id: "open_phone", label: "Open iPhone"),
OpenClawWatchAction(id: "escalate", label: "Escalate"),
]
}
return [
OpenClawWatchAction(id: "done", label: "Done"),
OpenClawWatchAction(id: "snooze_10m", label: "Snooze 10m"),
OpenClawWatchAction(id: "open_phone", label: "Open iPhone"),
OpenClawWatchAction(id: "escalate", label: "Escalate"),
]
}
private static func normalizedWatchRisk(
_ risk: OpenClawWatchRisk?,
priority: OpenClawNotificationPriority?) -> OpenClawWatchRisk?
{
if let risk { return risk }
switch priority {
case .passive:
return .low
case .active:
return .medium
case .timeSensitive:
return .high
case nil:
return nil
}
}
private static func normalizedWatchPriority(
_ priority: OpenClawNotificationPriority?,
risk: OpenClawWatchRisk?) -> OpenClawNotificationPriority?
{
if let priority { return priority }
switch risk {
case .low:
return .passive
case .medium:
return .active
case .high:
return .timeSensitive
case nil:
return nil
}
}
private static func trimmedOrNil(_ value: String?) -> String? {
let trimmed = value?.trimmingCharacters(in: .whitespacesAndNewlines) ?? ""
return trimmed.isEmpty ? nil : trimmed
}
func locationMode() -> OpenClawLocationMode {
let raw = UserDefaults.standard.string(forKey: "location.enabledMode") ?? "off"
return OpenClawLocationMode(rawValue: raw) ?? .off