LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-05-13 23:56:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(codex): simplify native tool diagnostics

Browse Source
This commit is contained in:
Ayaan Zaidi
2026-05-10 18:10:50 +05:30
parent 2afd67f93f
commit 529bfdbaca
2 changed files with 25 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
extensions/codex/src/app-server/event-projector.ts
View File

@@ -816,29 +816,24 @@ export class CodexAppServerEventProjector {
typeof params.item.durationMs === "number" ? params.item.durationMs : undefined;
const durationMs =
itemDurationMs ?? (startedAt === undefined ? 0 : Math.max(0, Date.now() - startedAt));
if (params.status === "blocked") {
emitTrustedDiagnosticEvent({
type: "tool.execution.blocked",
...base,
reason: "codex_native_tool_blocked",
deniedReason: "codex_native_tool_blocked",
});
return;
}
if (params.status === "failed") {
emitTrustedDiagnosticEvent({
type: "tool.execution.error",
...base,
durationMs,
errorCategory: "codex_native_tool_error",
});
return;
}
emitTrustedDiagnosticEvent({
type: "tool.execution.completed",
...base,
durationMs,
});
const terminalEvent =
params.status === "blocked"
? {
type: "tool.execution.blocked" as const,
reason: "codex_native_tool_blocked",
deniedReason: "codex_native_tool_blocked",
}
: params.status === "failed"
? {
type: "tool.execution.error" as const,
durationMs,
errorCategory: "codex_native_tool_error",
}
: {
type: "tool.execution.completed" as const,
durationMs,
};
emitTrustedDiagnosticEvent({ ...base, ...terminalEvent });
}
private emitToolResultSummary(item: CodexThreadItem | undefined): void {

22
src/logging/diagnostic-run-activity.ts
View File

@@ -21,6 +21,11 @@ type ActiveTool = {
lastProgressAt: number;
};
type DiagnosticToolStartedActivityEvent = Pick<
Extract<DiagnosticEventPayload, { type: "tool.execution.started" }>,
"runId" | "sessionId" | "sessionKey" | "toolName" | "toolCallId"
>;
export type DiagnosticSessionActivitySnapshot = {
activeWorkKind?: DiagnosticSessionActiveWorkKind;
activeToolName?: string;
@@ -158,9 +163,7 @@ function modelCallKey(event: { runId?: string; provider?: string; model?: string
return `${event.runId ?? "unknown"}:${event.provider ?? "provider"}:${event.model ?? "model"}`;
}
function recordToolStarted(
event: Extract<DiagnosticEventPayload, { type: "tool.execution.started" }>,
): void {
function recordToolStarted(event: DiagnosticToolStartedActivityEvent): void {
const activity = resolveSessionActivity({ ...event, create: true });
if (!activity) {
return;
@@ -314,18 +317,7 @@ export function markDiagnosticToolStartedForTest(params: {
toolName: string;
toolCallId?: string;
}): void {
const activity = resolveSessionActivity({ ...params, create: true });
if (!activity) {
return;
}
const now = Date.now();
activity.activeTools.set(toolKey(params), {
toolName: params.toolName,
toolCallId: params.toolCallId,
startedAt: now,
lastProgressAt: now,
});
touchSessionActivity(activity, `tool:${params.toolName}:started`, now);
recordToolStarted(params);
}
export function resetDiagnosticRunActivityForTest(): void {