mirror of
https://github.com/moltbot/moltbot.git
synced 2026-05-07 16:06:19 +00:00
2c716f5677
* [EV-001] memory-core: filter memory_search session hits by visibility - Move session visibility + listSpawnedSessionKeys to plugin-sdk; sync test hook with sessions-resolution __testing.setDepsForTest - Extract loadCombinedSessionStoreForGateway to config/sessions; re-export from gateway session-utils - Add session-transcript-hit stem resolver for builtin + QMD paths - Post-filter memory_search results before citations/recall; fail closed when requester session key missing; optional corpus=sessions - Tests: stem extraction, visibility filter smoke, existing suites green * chore: sync plugin-sdk exports for session-transcript-hit and session-visibility Run pnpm plugin-sdk:sync-exports so package.json exports match scripts/lib/plugin-sdk-entrypoints.json. Fixes contract tests and lint:plugins:plugin-sdk-subpaths-exported for memory-core imports. * fix(EV-001): cross-agent session memory hits + hoist combined store load - resolveTranscriptStemToSessionKeys: stop filtering by requester agentId so keys from other agents reach createSessionVisibilityGuard (a2a + visibility=all). - Re-export loadCombinedSessionStoreForGateway from session-transcript-hit; filterMemorySearchHitsBySessionVisibility loads the combined store once per pass. - Drop unused agentId from filter params; extend tests (Greptile/Codex review). * fix(memory_search): honor corpus=sessions before maxResults cap Pass sources into MemoryIndexManager.search so FTS/vector queries add source IN (...) before ranking and top-N slice (Codex: non-session hits could fill the window). QMD path: oversample fetch limit for single-source recall, filter by source, then diversify/clamp to the requested maxResults. Wire corpus=sessions from tools; extend MemorySearchManager opts and wrappers. * fix(memory_search): apply corpus=memory source filter like sessions Pass sources: ["memory"] into manager.search so maxResults applies only within the memory index; post-filter for defense in depth. Document corpus=memory in the tool description. * fix: scope qmd session memory search * fix: enforce memory search session visibility (#70761) (thanks @nefainl) --------- Co-authored-by: NefAI <info@nefai.nl> Co-authored-by: Ayaan Zaidi <hi@obviy.us>
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
import path from "node:path";
|
|
import { parseUsageCountedSessionIdFromFileName } from "../config/sessions/artifacts.js";
|
|
import type { SessionEntry } from "../config/sessions/types.js";
|
|
import { normalizeOptionalString } from "../shared/string-coerce.js";
|
|
|
|
export { loadCombinedSessionStoreForGateway } from "../config/sessions/combined-store-gateway.js";
|
|
|
|
/**
|
|
* Derive transcript stem `S` from a memory search hit path for `source === "sessions"`.
|
|
* Builtin index uses `sessions/<basename>.jsonl`; QMD exports use `<stem>.md`.
|
|
*/
|
|
export function extractTranscriptStemFromSessionsMemoryHit(hitPath: string): string | null {
|
|
const normalized = hitPath.replace(/\\/g, "/");
|
|
const trimmed = normalized.startsWith("sessions/")
|
|
? normalized.slice("sessions/".length)
|
|
: normalized;
|
|
const base = path.basename(trimmed);
|
|
if (base.endsWith(".jsonl")) {
|
|
const stem = base.slice(0, -".jsonl".length);
|
|
return stem || null;
|
|
}
|
|
if (base.endsWith(".md")) {
|
|
const stem = base.slice(0, -".md".length);
|
|
return stem || null;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Map transcript stem to canonical session store keys (all agents in the combined store).
|
|
* Session tools visibility and agent-to-agent policy are enforced by the caller (e.g.
|
|
* `createSessionVisibilityGuard`), including cross-agent cases.
|
|
*/
|
|
export function resolveTranscriptStemToSessionKeys(params: {
|
|
store: Record<string, SessionEntry>;
|
|
stem: string;
|
|
}): string[] {
|
|
const { store } = params;
|
|
const matches: string[] = [];
|
|
const stemAsFile = params.stem.endsWith(".jsonl") ? params.stem : `${params.stem}.jsonl`;
|
|
const parsedStemId = parseUsageCountedSessionIdFromFileName(stemAsFile);
|
|
|
|
for (const [sessionKey, entry] of Object.entries(store)) {
|
|
const sessionFile = normalizeOptionalString(entry.sessionFile);
|
|
if (sessionFile) {
|
|
const base = path.basename(sessionFile);
|
|
const fileStem = base.endsWith(".jsonl") ? base.slice(0, -".jsonl".length) : base;
|
|
if (fileStem === params.stem) {
|
|
matches.push(sessionKey);
|
|
continue;
|
|
}
|
|
}
|
|
if (entry.sessionId === params.stem || (parsedStemId && entry.sessionId === parsedStemId)) {
|
|
matches.push(sessionKey);
|
|
}
|
|
}
|
|
return [...new Set(matches)];
|
|
}
|