mirror of
https://github.com/moltbot/moltbot.git
synced 2026-03-07 22:44:16 +00:00
* feat(secrets): expand secret target coverage and gateway tooling * docs(secrets): align gateway and CLI secret docs * chore(protocol): regenerate swift gateway models for secrets methods * fix(config): restore talk apiKey fallback and stabilize runner test * ci(windows): reduce test worker count for shard stability * ci(windows): raise node heap for test shard stability * test(feishu): make proxy env precedence assertion windows-safe * fix(gateway): resolve auth password SecretInput refs for clients * fix(gateway): resolve remote SecretInput credentials for clients * fix(secrets): skip inactive refs in command snapshot assignments * fix(secrets): scope gateway.remote refs to effective auth surfaces * fix(secrets): ignore memory defaults when enabled agents disable search * fix(secrets): honor Google Chat serviceAccountRef inheritance * fix(secrets): address tsgo errors in command and gateway collectors * fix(secrets): avoid auth-store load in providers-only configure * fix(gateway): defer local password ref resolution by precedence * fix(secrets): gate telegram webhook secret refs by webhook mode * fix(secrets): gate slack signing secret refs to http mode * fix(secrets): skip telegram botToken refs when tokenFile is set * fix(secrets): gate discord pluralkit refs by enabled flag * fix(secrets): gate discord voice tts refs by voice enabled * test(secrets): make runtime fixture modes explicit * fix(cli): resolve local qr password secret refs * fix(cli): fail when gateway leaves command refs unresolved * fix(gateway): fail when local password SecretRef is unresolved * fix(gateway): fail when required remote SecretRefs are unresolved * fix(gateway): resolve local password refs only when password can win * fix(cli): skip local password SecretRef resolution on qr token override * test(gateway): cast SecretRef fixtures to OpenClawConfig * test(secrets): activate mode-gated targets in runtime coverage fixture * fix(cron): support SecretInput webhook tokens safely * fix(bluebubbles): support SecretInput passwords across config paths * fix(msteams): make appPassword SecretInput-safe in onboarding/token paths * fix(bluebubbles): align SecretInput schema helper typing * fix(cli): clarify secrets.resolve version-skew errors * refactor(secrets): return structured inactive paths from secrets.resolve * refactor(gateway): type onboarding secret writes as SecretInput * chore(protocol): regenerate swift models for secrets.resolve * feat(secrets): expand extension credential secretref support * fix(secrets): gate web-search refs by active provider * fix(onboarding): detect SecretRef credentials in extension status * fix(onboarding): allow keeping existing ref in secret prompt * fix(onboarding): resolve gateway password SecretRefs for probe and tui * fix(onboarding): honor secret-input-mode for local gateway auth * fix(acp): resolve gateway SecretInput credentials * fix(secrets): gate gateway.remote refs to remote surfaces * test(secrets): cover pattern matching and inactive array refs * docs(secrets): clarify secrets.resolve and remote active surfaces * fix(bluebubbles): keep existing SecretRef during onboarding * fix(tests): resolve CI type errors in new SecretRef coverage * fix(extensions): replace raw fetch with SSRF-guarded fetch * test(secrets): mark gateway remote targets active in runtime coverage * test(infra): normalize home-prefix expectation across platforms * fix(cli): only resolve local qr password refs in password mode * test(cli): cover local qr token mode with unresolved password ref * docs(cli): clarify local qr password ref resolution behavior * refactor(extensions): reuse sdk SecretInput helpers * fix(wizard): resolve onboarding env-template secrets before plaintext * fix(cli): surface secrets.resolve diagnostics in memory and qr * test(secrets): repair post-rebase runtime and fixtures * fix(gateway): skip remote password ref resolution when token wins * fix(secrets): treat tailscale remote gateway refs as active * fix(gateway): allow remote password fallback when token ref is unresolved * fix(gateway): ignore stale local password refs for none and trusted-proxy * fix(gateway): skip remote secret ref resolution on local call paths * test(cli): cover qr remote tailscale secret ref resolution * fix(secrets): align gateway password active-surface with auth inference * fix(cli): resolve inferred local gateway password refs in qr * fix(gateway): prefer resolvable remote password over token ref pre-resolution * test(gateway): cover none and trusted-proxy stale password refs * docs(secrets): sync qr and gateway active-surface behavior * fix: restore stability blockers from pre-release audit * Secrets: fix collector/runtime precedence contradictions * docs: align secrets and web credential docs * fix(rebase): resolve integration regressions after main rebase * fix(node-host): resolve gateway secret refs for auth * fix(secrets): harden secretinput runtime readers * gateway: skip inactive auth secretref resolution * cli: avoid gateway preflight for inactive secret refs * extensions: allow unresolved refs in onboarding status * tests: fix qr-cli module mock hoist ordering * Security: align audit checks with SecretInput resolution * Gateway: resolve local-mode remote fallback secret refs * Node host: avoid resolving inactive password secret refs * Secrets runtime: mark Slack appToken inactive for HTTP mode * secrets: keep inactive gateway remote refs non-blocking * cli: include agent memory secret targets in runtime resolution * docs(secrets): sync docs with active-surface and web search behavior * fix(secrets): keep telegram top-level token refs active for blank account tokens * fix(daemon): resolve gateway password secret refs for probe auth * fix(secrets): skip IRC NickServ ref resolution when NickServ is disabled * fix(secrets): align token inheritance and exec timeout defaults * docs(secrets): clarify active-surface notes in cli docs * cli: require secrets.resolve gateway capability * gateway: log auth secret surface diagnostics * secrets: remove dead provider resolver module * fix(secrets): restore gateway auth precedence and fallback resolution * fix(tests): align plugin runtime mock typings --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
951 lines
35 KiB
TypeScript
951 lines
35 KiB
TypeScript
import type { PluginRuntime, SsrFPolicy } from "openclaw/plugin-sdk";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { createPluginRuntimeMock } from "../../test-utils/plugin-runtime-mock.js";
|
|
import {
|
|
buildMSTeamsAttachmentPlaceholder,
|
|
buildMSTeamsGraphMessageUrls,
|
|
buildMSTeamsMediaPayload,
|
|
downloadMSTeamsAttachments,
|
|
downloadMSTeamsGraphMedia,
|
|
} from "./attachments.js";
|
|
import { setMSTeamsRuntime } from "./runtime.js";
|
|
|
|
const GRAPH_HOST = "graph.microsoft.com";
|
|
const SHAREPOINT_HOST = "contoso.sharepoint.com";
|
|
const AZUREEDGE_HOST = "azureedge.net";
|
|
const TEST_HOST = "x";
|
|
const createUrlForHost = (host: string, pathSegment: string) => `https://${host}/${pathSegment}`;
|
|
const createTestUrl = (pathSegment: string) => createUrlForHost(TEST_HOST, pathSegment);
|
|
const SAVED_PNG_PATH = "/tmp/saved.png";
|
|
const SAVED_PDF_PATH = "/tmp/saved.pdf";
|
|
const TEST_URL_IMAGE = createTestUrl("img");
|
|
const TEST_URL_IMAGE_PNG = createTestUrl("img.png");
|
|
const TEST_URL_IMAGE_1_PNG = createTestUrl("1.png");
|
|
const TEST_URL_IMAGE_2_JPG = createTestUrl("2.jpg");
|
|
const TEST_URL_PDF = createTestUrl("x.pdf");
|
|
const TEST_URL_PDF_1 = createTestUrl("1.pdf");
|
|
const TEST_URL_PDF_2 = createTestUrl("2.pdf");
|
|
const TEST_URL_HTML_A = createTestUrl("a.png");
|
|
const TEST_URL_HTML_B = createTestUrl("b.png");
|
|
const TEST_URL_INLINE_IMAGE = createTestUrl("inline.png");
|
|
const TEST_URL_DOC_PDF = createTestUrl("doc.pdf");
|
|
const TEST_URL_FILE_DOWNLOAD = createTestUrl("dl");
|
|
const TEST_URL_OUTSIDE_ALLOWLIST = "https://evil.test/img";
|
|
const CONTENT_TYPE_IMAGE_PNG = "image/png";
|
|
const CONTENT_TYPE_APPLICATION_PDF = "application/pdf";
|
|
const CONTENT_TYPE_TEXT_HTML = "text/html";
|
|
const CONTENT_TYPE_TEAMS_FILE_DOWNLOAD_INFO = "application/vnd.microsoft.teams.file.download.info";
|
|
const REDIRECT_STATUS_CODES = [301, 302, 303, 307, 308];
|
|
const MAX_REDIRECT_HOPS = 5;
|
|
type RemoteMediaFetchParams = {
|
|
url: string;
|
|
maxBytes?: number;
|
|
filePathHint?: string;
|
|
ssrfPolicy?: SsrFPolicy;
|
|
fetchImpl?: (input: RequestInfo | URL, init?: RequestInit) => Promise<Response>;
|
|
};
|
|
|
|
const detectMimeMock = vi.fn(async () => CONTENT_TYPE_IMAGE_PNG);
|
|
const saveMediaBufferMock = vi.fn(async () => ({
|
|
id: "saved.png",
|
|
path: SAVED_PNG_PATH,
|
|
size: Buffer.byteLength(PNG_BUFFER),
|
|
contentType: CONTENT_TYPE_IMAGE_PNG,
|
|
}));
|
|
const readRemoteMediaResponse = async (
|
|
res: Response,
|
|
params: Pick<RemoteMediaFetchParams, "maxBytes" | "filePathHint">,
|
|
) => {
|
|
if (!res.ok) {
|
|
throw new Error(`HTTP ${res.status}`);
|
|
}
|
|
const buffer = Buffer.from(await res.arrayBuffer());
|
|
if (typeof params.maxBytes === "number" && buffer.byteLength > params.maxBytes) {
|
|
throw new Error(`payload exceeds maxBytes ${params.maxBytes}`);
|
|
}
|
|
return {
|
|
buffer,
|
|
contentType: res.headers.get("content-type") ?? undefined,
|
|
fileName: params.filePathHint,
|
|
};
|
|
};
|
|
|
|
function isHostnameAllowedByPattern(hostname: string, pattern: string): boolean {
|
|
if (pattern.startsWith("*.")) {
|
|
const suffix = pattern.slice(2);
|
|
return suffix.length > 0 && hostname !== suffix && hostname.endsWith(`.${suffix}`);
|
|
}
|
|
return hostname === pattern;
|
|
}
|
|
|
|
function isUrlAllowedBySsrfPolicy(url: string, policy?: SsrFPolicy): boolean {
|
|
if (!policy?.hostnameAllowlist || policy.hostnameAllowlist.length === 0) {
|
|
return true;
|
|
}
|
|
const hostname = new URL(url).hostname.toLowerCase();
|
|
return policy.hostnameAllowlist.some((pattern) =>
|
|
isHostnameAllowedByPattern(hostname, pattern.toLowerCase()),
|
|
);
|
|
}
|
|
|
|
const fetchRemoteMediaMock = vi.fn(async (params: RemoteMediaFetchParams) => {
|
|
const fetchFn = params.fetchImpl ?? fetch;
|
|
let currentUrl = params.url;
|
|
for (let i = 0; i <= MAX_REDIRECT_HOPS; i += 1) {
|
|
if (!isUrlAllowedBySsrfPolicy(currentUrl, params.ssrfPolicy)) {
|
|
throw new Error(`Blocked hostname (not in allowlist): ${currentUrl}`);
|
|
}
|
|
const res = await fetchFn(currentUrl, { redirect: "manual" });
|
|
if (REDIRECT_STATUS_CODES.includes(res.status)) {
|
|
const location = res.headers.get("location");
|
|
if (!location) {
|
|
throw new Error("redirect missing location");
|
|
}
|
|
currentUrl = new URL(location, currentUrl).toString();
|
|
continue;
|
|
}
|
|
return readRemoteMediaResponse(res, params);
|
|
}
|
|
throw new Error("too many redirects");
|
|
});
|
|
|
|
const runtimeStub: PluginRuntime = createPluginRuntimeMock({
|
|
media: {
|
|
detectMime: detectMimeMock,
|
|
},
|
|
channel: {
|
|
media: {
|
|
fetchRemoteMedia: fetchRemoteMediaMock,
|
|
saveMediaBuffer: saveMediaBufferMock,
|
|
},
|
|
},
|
|
});
|
|
|
|
type DownloadAttachmentsParams = Parameters<typeof downloadMSTeamsAttachments>[0];
|
|
type DownloadGraphMediaParams = Parameters<typeof downloadMSTeamsGraphMedia>[0];
|
|
type DownloadedMedia = Awaited<ReturnType<typeof downloadMSTeamsAttachments>>;
|
|
type MSTeamsMediaPayload = ReturnType<typeof buildMSTeamsMediaPayload>;
|
|
type DownloadAttachmentsBuildOverrides = Partial<
|
|
Omit<DownloadAttachmentsParams, "attachments" | "maxBytes" | "allowHosts">
|
|
> &
|
|
Pick<DownloadAttachmentsParams, "allowHosts">;
|
|
type DownloadAttachmentsNoFetchOverrides = Partial<
|
|
Omit<DownloadAttachmentsParams, "attachments" | "maxBytes" | "allowHosts" | "fetchFn">
|
|
> &
|
|
Pick<DownloadAttachmentsParams, "allowHosts">;
|
|
type DownloadGraphMediaOverrides = Partial<
|
|
Omit<DownloadGraphMediaParams, "messageUrl" | "tokenProvider" | "maxBytes">
|
|
>;
|
|
type FetchFn = typeof fetch;
|
|
type MSTeamsAttachments = DownloadAttachmentsParams["attachments"];
|
|
type AttachmentPlaceholderInput = Parameters<typeof buildMSTeamsAttachmentPlaceholder>[0];
|
|
type GraphMessageUrlParams = Parameters<typeof buildMSTeamsGraphMessageUrls>[0];
|
|
type LabeledCase = { label: string };
|
|
type FetchCallExpectation = { expectFetchCalled?: boolean };
|
|
type DownloadedMediaExpectation = { path?: string; placeholder?: string };
|
|
type MSTeamsMediaPayloadExpectation = {
|
|
firstPath: string;
|
|
paths: string[];
|
|
types: string[];
|
|
};
|
|
|
|
const DEFAULT_MESSAGE_URL = `https://${GRAPH_HOST}/v1.0/chats/19%3Achat/messages/123`;
|
|
const GRAPH_SHARES_URL_PREFIX = `https://${GRAPH_HOST}/v1.0/shares/`;
|
|
const DEFAULT_MAX_BYTES = 1024 * 1024;
|
|
const DEFAULT_ALLOW_HOSTS = [TEST_HOST];
|
|
const DEFAULT_SHAREPOINT_ALLOW_HOSTS = [GRAPH_HOST, SHAREPOINT_HOST];
|
|
const DEFAULT_SHARE_REFERENCE_URL = createUrlForHost(SHAREPOINT_HOST, "site/file");
|
|
const MEDIA_PLACEHOLDER_IMAGE = "<media:image>";
|
|
const MEDIA_PLACEHOLDER_DOCUMENT = "<media:document>";
|
|
const formatImagePlaceholder = (count: number) =>
|
|
count > 1 ? `${MEDIA_PLACEHOLDER_IMAGE} (${count} images)` : MEDIA_PLACEHOLDER_IMAGE;
|
|
const formatDocumentPlaceholder = (count: number) =>
|
|
count > 1 ? `${MEDIA_PLACEHOLDER_DOCUMENT} (${count} files)` : MEDIA_PLACEHOLDER_DOCUMENT;
|
|
const IMAGE_ATTACHMENT = { contentType: CONTENT_TYPE_IMAGE_PNG, contentUrl: TEST_URL_IMAGE };
|
|
const PNG_BUFFER = Buffer.from("png");
|
|
const PNG_BASE64 = PNG_BUFFER.toString("base64");
|
|
const PDF_BUFFER = Buffer.from("pdf");
|
|
const createTokenProvider = (
|
|
tokenOrResolver: string | ((scope: string) => string | Promise<string>) = "token",
|
|
) => ({
|
|
getAccessToken: vi.fn(async (scope: string) =>
|
|
typeof tokenOrResolver === "function" ? await tokenOrResolver(scope) : tokenOrResolver,
|
|
),
|
|
});
|
|
const asSingleItemArray = <T>(value: T) => [value];
|
|
const withLabel = <T extends object>(label: string, fields: T): T & LabeledCase => ({
|
|
label,
|
|
...fields,
|
|
});
|
|
const buildAttachment = <T extends Record<string, unknown>>(contentType: string, props: T) => ({
|
|
contentType,
|
|
...props,
|
|
});
|
|
const createHtmlAttachment = (content: string) =>
|
|
buildAttachment(CONTENT_TYPE_TEXT_HTML, { content });
|
|
const buildHtmlImageTag = (src: string) => `<img src="${src}" />`;
|
|
const createHtmlImageAttachments = (sources: string[], prefix = "") =>
|
|
asSingleItemArray(createHtmlAttachment(`${prefix}${sources.map(buildHtmlImageTag).join("")}`));
|
|
const createContentUrlAttachments = (contentType: string, ...contentUrls: string[]) =>
|
|
contentUrls.map((contentUrl) => buildAttachment(contentType, { contentUrl }));
|
|
const createImageAttachments = (...contentUrls: string[]) =>
|
|
createContentUrlAttachments(CONTENT_TYPE_IMAGE_PNG, ...contentUrls);
|
|
const createPdfAttachments = (...contentUrls: string[]) =>
|
|
createContentUrlAttachments(CONTENT_TYPE_APPLICATION_PDF, ...contentUrls);
|
|
const createTeamsFileDownloadInfoAttachments = (
|
|
downloadUrl = TEST_URL_FILE_DOWNLOAD,
|
|
fileType = "png",
|
|
) =>
|
|
asSingleItemArray(
|
|
buildAttachment(CONTENT_TYPE_TEAMS_FILE_DOWNLOAD_INFO, {
|
|
content: { downloadUrl, fileType },
|
|
}),
|
|
);
|
|
const createMediaEntriesWithType = (contentType: string, ...paths: string[]) =>
|
|
paths.map((path) => ({ path, contentType }));
|
|
const createHostedContentsWithType = (contentType: string, ...ids: string[]) =>
|
|
ids.map((id) => ({ id, contentType, contentBytes: PNG_BASE64 }));
|
|
const createImageMediaEntries = (...paths: string[]) =>
|
|
createMediaEntriesWithType(CONTENT_TYPE_IMAGE_PNG, ...paths);
|
|
const createHostedImageContents = (...ids: string[]) =>
|
|
createHostedContentsWithType(CONTENT_TYPE_IMAGE_PNG, ...ids);
|
|
const createPdfResponse = (payload: Buffer | string = PDF_BUFFER) => {
|
|
return createBufferResponse(payload, CONTENT_TYPE_APPLICATION_PDF);
|
|
};
|
|
const createBufferResponse = (payload: Buffer | string, contentType: string, status = 200) => {
|
|
const raw = Buffer.isBuffer(payload) ? payload : Buffer.from(payload);
|
|
return new Response(new Uint8Array(raw), {
|
|
status,
|
|
headers: { "content-type": contentType },
|
|
});
|
|
};
|
|
const createJsonResponse = (payload: unknown, status = 200) =>
|
|
new Response(JSON.stringify(payload), { status });
|
|
const createTextResponse = (body: string, status = 200) => new Response(body, { status });
|
|
const createGraphCollectionResponse = (value: unknown[]) => createJsonResponse({ value });
|
|
const createNotFoundResponse = () => new Response("not found", { status: 404 });
|
|
const createRedirectResponse = (location: string, status = 302) =>
|
|
new Response(null, { status, headers: { location } });
|
|
|
|
const createOkFetchMock = (contentType: string, payload = "png") =>
|
|
vi.fn(async () => createBufferResponse(payload, contentType));
|
|
const asFetchFn = (fetchFn: unknown): FetchFn => fetchFn as FetchFn;
|
|
|
|
const buildDownloadParams = (
|
|
attachments: MSTeamsAttachments,
|
|
overrides: DownloadAttachmentsBuildOverrides = {},
|
|
): DownloadAttachmentsParams => {
|
|
return {
|
|
attachments,
|
|
maxBytes: DEFAULT_MAX_BYTES,
|
|
allowHosts: DEFAULT_ALLOW_HOSTS,
|
|
...overrides,
|
|
};
|
|
};
|
|
|
|
const downloadAttachmentsWithFetch = async (
|
|
attachments: MSTeamsAttachments,
|
|
fetchFn: unknown,
|
|
overrides: DownloadAttachmentsNoFetchOverrides = {},
|
|
options: FetchCallExpectation = {},
|
|
) => {
|
|
const media = await downloadMSTeamsAttachments(
|
|
buildDownloadParams(attachments, {
|
|
...overrides,
|
|
fetchFn: asFetchFn(fetchFn),
|
|
}),
|
|
);
|
|
expectMockCallState(fetchFn, options.expectFetchCalled ?? true);
|
|
return media;
|
|
};
|
|
|
|
const createAuthAwareImageFetchMock = (params: { unauthStatus: number; unauthBody: string }) =>
|
|
vi.fn(async (_url: string, opts?: RequestInit) => {
|
|
const headers = new Headers(opts?.headers);
|
|
const hasAuth = Boolean(headers.get("Authorization"));
|
|
if (!hasAuth) {
|
|
return createTextResponse(params.unauthBody, params.unauthStatus);
|
|
}
|
|
return createBufferResponse(PNG_BUFFER, CONTENT_TYPE_IMAGE_PNG);
|
|
});
|
|
const expectMockCallState = (mockFn: unknown, shouldCall: boolean) => {
|
|
if (shouldCall) {
|
|
expect(mockFn).toHaveBeenCalled();
|
|
} else {
|
|
expect(mockFn).not.toHaveBeenCalled();
|
|
}
|
|
};
|
|
|
|
const DEFAULT_CHANNEL_TEAM_ID = "team-id";
|
|
const DEFAULT_CHANNEL_ID = "chan-id";
|
|
const createChannelGraphMessageUrlParams = (params: {
|
|
messageId: string;
|
|
replyToId?: string;
|
|
conversationId?: string;
|
|
}) => ({
|
|
conversationType: "channel" as const,
|
|
...params,
|
|
channelData: {
|
|
team: { id: DEFAULT_CHANNEL_TEAM_ID },
|
|
channel: { id: DEFAULT_CHANNEL_ID },
|
|
},
|
|
});
|
|
const buildExpectedChannelMessagePath = (params: { messageId: string; replyToId?: string }) =>
|
|
params.replyToId
|
|
? `/teams/${DEFAULT_CHANNEL_TEAM_ID}/channels/${DEFAULT_CHANNEL_ID}/messages/${params.replyToId}/replies/${params.messageId}`
|
|
: `/teams/${DEFAULT_CHANNEL_TEAM_ID}/channels/${DEFAULT_CHANNEL_ID}/messages/${params.messageId}`;
|
|
|
|
const expectAttachmentMediaLength = (media: DownloadedMedia, expectedLength: number) => {
|
|
expect(media).toHaveLength(expectedLength);
|
|
};
|
|
const expectSingleMedia = (media: DownloadedMedia, expected: DownloadedMediaExpectation = {}) => {
|
|
expectAttachmentMediaLength(media, 1);
|
|
expectFirstMedia(media, expected);
|
|
};
|
|
const expectMediaBufferSaved = () => {
|
|
expect(saveMediaBufferMock).toHaveBeenCalled();
|
|
};
|
|
const expectFirstMedia = (media: DownloadedMedia, expected: DownloadedMediaExpectation) => {
|
|
const first = media[0];
|
|
if (expected.path !== undefined) {
|
|
expect(first?.path).toBe(expected.path);
|
|
}
|
|
if (expected.placeholder !== undefined) {
|
|
expect(first?.placeholder).toBe(expected.placeholder);
|
|
}
|
|
};
|
|
const expectMSTeamsMediaPayload = (
|
|
payload: MSTeamsMediaPayload,
|
|
expected: MSTeamsMediaPayloadExpectation,
|
|
) => {
|
|
expect(payload.MediaPath).toBe(expected.firstPath);
|
|
expect(payload.MediaUrl).toBe(expected.firstPath);
|
|
expect(payload.MediaPaths).toEqual(expected.paths);
|
|
expect(payload.MediaUrls).toEqual(expected.paths);
|
|
expect(payload.MediaTypes).toEqual(expected.types);
|
|
};
|
|
type AttachmentPlaceholderCase = LabeledCase & {
|
|
attachments: AttachmentPlaceholderInput;
|
|
expected: string;
|
|
};
|
|
type CountedAttachmentPlaceholderCaseDef = LabeledCase & {
|
|
attachments: AttachmentPlaceholderCase["attachments"];
|
|
count: number;
|
|
formatPlaceholder: (count: number) => string;
|
|
};
|
|
type AttachmentDownloadSuccessCase = LabeledCase & {
|
|
attachments: MSTeamsAttachments;
|
|
buildFetchFn?: () => unknown;
|
|
beforeDownload?: () => void;
|
|
assert?: (media: DownloadedMedia) => void;
|
|
};
|
|
type AttachmentAuthRetryScenario = {
|
|
attachmentUrl: string;
|
|
unauthStatus: number;
|
|
unauthBody: string;
|
|
overrides?: Omit<DownloadAttachmentsNoFetchOverrides, "tokenProvider">;
|
|
};
|
|
type AttachmentAuthRetryCase = LabeledCase & {
|
|
scenario: AttachmentAuthRetryScenario;
|
|
expectedMediaLength: number;
|
|
expectTokenFetch: boolean;
|
|
};
|
|
type GraphUrlExpectationCase = LabeledCase & {
|
|
params: GraphMessageUrlParams;
|
|
expectedPath: string;
|
|
};
|
|
type ChannelGraphUrlCaseParams = {
|
|
messageId: string;
|
|
replyToId?: string;
|
|
conversationId?: string;
|
|
};
|
|
type GraphMediaDownloadResult = {
|
|
fetchMock: ReturnType<typeof createGraphFetchMock>;
|
|
media: Awaited<ReturnType<typeof downloadMSTeamsGraphMedia>>;
|
|
};
|
|
type GraphMediaSuccessCase = LabeledCase & {
|
|
buildOptions: () => GraphFetchMockOptions;
|
|
expectedLength: number;
|
|
assert?: (params: GraphMediaDownloadResult) => void;
|
|
};
|
|
const EMPTY_ATTACHMENT_PLACEHOLDER_CASES: AttachmentPlaceholderCase[] = [
|
|
withLabel("returns empty string when no attachments", { attachments: undefined, expected: "" }),
|
|
withLabel("returns empty string when attachments are empty", { attachments: [], expected: "" }),
|
|
];
|
|
const COUNTED_ATTACHMENT_PLACEHOLDER_CASE_DEFS: CountedAttachmentPlaceholderCaseDef[] = [
|
|
withLabel("returns image placeholder for one image attachment", {
|
|
attachments: createImageAttachments(TEST_URL_IMAGE_PNG),
|
|
count: 1,
|
|
formatPlaceholder: formatImagePlaceholder,
|
|
}),
|
|
withLabel("returns image placeholder with count for many image attachments", {
|
|
attachments: [
|
|
...createImageAttachments(TEST_URL_IMAGE_1_PNG),
|
|
{ contentType: "image/jpeg", contentUrl: TEST_URL_IMAGE_2_JPG },
|
|
],
|
|
count: 2,
|
|
formatPlaceholder: formatImagePlaceholder,
|
|
}),
|
|
withLabel("treats Teams file.download.info image attachments as images", {
|
|
attachments: createTeamsFileDownloadInfoAttachments(),
|
|
count: 1,
|
|
formatPlaceholder: formatImagePlaceholder,
|
|
}),
|
|
withLabel("returns document placeholder for non-image attachments", {
|
|
attachments: createPdfAttachments(TEST_URL_PDF),
|
|
count: 1,
|
|
formatPlaceholder: formatDocumentPlaceholder,
|
|
}),
|
|
withLabel("returns document placeholder with count for many non-image attachments", {
|
|
attachments: createPdfAttachments(TEST_URL_PDF_1, TEST_URL_PDF_2),
|
|
count: 2,
|
|
formatPlaceholder: formatDocumentPlaceholder,
|
|
}),
|
|
withLabel("counts one inline image in html attachments", {
|
|
attachments: createHtmlImageAttachments([TEST_URL_HTML_A], "<p>hi</p>"),
|
|
count: 1,
|
|
formatPlaceholder: formatImagePlaceholder,
|
|
}),
|
|
withLabel("counts many inline images in html attachments", {
|
|
attachments: createHtmlImageAttachments([TEST_URL_HTML_A, TEST_URL_HTML_B]),
|
|
count: 2,
|
|
formatPlaceholder: formatImagePlaceholder,
|
|
}),
|
|
];
|
|
const ATTACHMENT_PLACEHOLDER_CASES: AttachmentPlaceholderCase[] = [
|
|
...EMPTY_ATTACHMENT_PLACEHOLDER_CASES,
|
|
...COUNTED_ATTACHMENT_PLACEHOLDER_CASE_DEFS.map((testCase) =>
|
|
withLabel(testCase.label, {
|
|
attachments: testCase.attachments,
|
|
expected: testCase.formatPlaceholder(testCase.count),
|
|
}),
|
|
),
|
|
];
|
|
const ATTACHMENT_DOWNLOAD_SUCCESS_CASES: AttachmentDownloadSuccessCase[] = [
|
|
withLabel("downloads and stores image contentUrl attachments", {
|
|
attachments: asSingleItemArray(IMAGE_ATTACHMENT),
|
|
assert: (media) => {
|
|
expectFirstMedia(media, { path: SAVED_PNG_PATH });
|
|
expectMediaBufferSaved();
|
|
},
|
|
}),
|
|
withLabel("supports Teams file.download.info downloadUrl attachments", {
|
|
attachments: createTeamsFileDownloadInfoAttachments(),
|
|
}),
|
|
withLabel("downloads inline image URLs from html attachments", {
|
|
attachments: createHtmlImageAttachments([TEST_URL_INLINE_IMAGE]),
|
|
}),
|
|
withLabel("downloads non-image file attachments (PDF)", {
|
|
attachments: createPdfAttachments(TEST_URL_DOC_PDF),
|
|
buildFetchFn: () => createOkFetchMock(CONTENT_TYPE_APPLICATION_PDF, "pdf"),
|
|
beforeDownload: () => {
|
|
detectMimeMock.mockResolvedValueOnce(CONTENT_TYPE_APPLICATION_PDF);
|
|
saveMediaBufferMock.mockResolvedValueOnce({
|
|
id: "saved.pdf",
|
|
path: SAVED_PDF_PATH,
|
|
size: Buffer.byteLength(PDF_BUFFER),
|
|
contentType: CONTENT_TYPE_APPLICATION_PDF,
|
|
});
|
|
},
|
|
assert: (media) => {
|
|
expectSingleMedia(media, {
|
|
path: SAVED_PDF_PATH,
|
|
placeholder: formatDocumentPlaceholder(1),
|
|
});
|
|
},
|
|
}),
|
|
];
|
|
const ATTACHMENT_AUTH_RETRY_CASES: AttachmentAuthRetryCase[] = [
|
|
withLabel("retries with auth when the first request is unauthorized", {
|
|
scenario: {
|
|
attachmentUrl: IMAGE_ATTACHMENT.contentUrl,
|
|
unauthStatus: 401,
|
|
unauthBody: "unauthorized",
|
|
overrides: { authAllowHosts: [TEST_HOST] },
|
|
},
|
|
expectedMediaLength: 1,
|
|
expectTokenFetch: true,
|
|
}),
|
|
withLabel("skips auth retries when the host is not in auth allowlist", {
|
|
scenario: {
|
|
attachmentUrl: createUrlForHost(AZUREEDGE_HOST, "img"),
|
|
unauthStatus: 403,
|
|
unauthBody: "forbidden",
|
|
overrides: {
|
|
allowHosts: [AZUREEDGE_HOST],
|
|
authAllowHosts: [GRAPH_HOST],
|
|
},
|
|
},
|
|
expectedMediaLength: 0,
|
|
expectTokenFetch: false,
|
|
}),
|
|
];
|
|
const GRAPH_MEDIA_SUCCESS_CASES: GraphMediaSuccessCase[] = [
|
|
withLabel("downloads hostedContents images", {
|
|
buildOptions: () => ({ hostedContents: createHostedImageContents("1") }),
|
|
expectedLength: 1,
|
|
assert: ({ fetchMock }) => {
|
|
expect(fetchMock).toHaveBeenCalled();
|
|
expectMediaBufferSaved();
|
|
},
|
|
}),
|
|
withLabel("merges SharePoint reference attachments with hosted content", {
|
|
buildOptions: () => {
|
|
return {
|
|
hostedContents: createHostedImageContents("hosted-1"),
|
|
...buildDefaultShareReferenceGraphFetchOptions({
|
|
onShareRequest: () => createPdfResponse(),
|
|
}),
|
|
};
|
|
},
|
|
expectedLength: 2,
|
|
}),
|
|
];
|
|
const CHANNEL_GRAPH_URL_CASES: Array<LabeledCase & ChannelGraphUrlCaseParams> = [
|
|
withLabel("builds channel message urls", {
|
|
conversationId: "19:thread@thread.tacv2",
|
|
messageId: "123",
|
|
}),
|
|
withLabel("builds channel reply urls when replyToId is present", {
|
|
messageId: "reply-id",
|
|
replyToId: "root-id",
|
|
}),
|
|
];
|
|
const GRAPH_URL_EXPECTATION_CASES: GraphUrlExpectationCase[] = [
|
|
...CHANNEL_GRAPH_URL_CASES.map<GraphUrlExpectationCase>(({ label, ...params }) =>
|
|
withLabel(label, {
|
|
params: createChannelGraphMessageUrlParams(params),
|
|
expectedPath: buildExpectedChannelMessagePath(params),
|
|
}),
|
|
),
|
|
withLabel("builds chat message urls", {
|
|
params: {
|
|
conversationType: "groupChat" as const,
|
|
conversationId: "19:chat@thread.v2",
|
|
messageId: "456",
|
|
},
|
|
expectedPath: "/chats/19%3Achat%40thread.v2/messages/456",
|
|
}),
|
|
];
|
|
|
|
type GraphFetchMockOptions = {
|
|
hostedContents?: unknown[];
|
|
attachments?: unknown[];
|
|
messageAttachments?: unknown[];
|
|
onShareRequest?: (url: string) => Response | Promise<Response>;
|
|
onUnhandled?: (url: string) => Response | Promise<Response> | undefined;
|
|
};
|
|
|
|
const createReferenceAttachment = (shareUrl = DEFAULT_SHARE_REFERENCE_URL) => ({
|
|
id: "ref-1",
|
|
contentType: "reference",
|
|
contentUrl: shareUrl,
|
|
name: "report.pdf",
|
|
});
|
|
const buildShareReferenceGraphFetchOptions = (params: {
|
|
referenceAttachment: ReturnType<typeof createReferenceAttachment>;
|
|
onShareRequest?: GraphFetchMockOptions["onShareRequest"];
|
|
onUnhandled?: GraphFetchMockOptions["onUnhandled"];
|
|
}) => ({
|
|
attachments: [params.referenceAttachment],
|
|
messageAttachments: [params.referenceAttachment],
|
|
...(params.onShareRequest ? { onShareRequest: params.onShareRequest } : {}),
|
|
...(params.onUnhandled ? { onUnhandled: params.onUnhandled } : {}),
|
|
});
|
|
const buildDefaultShareReferenceGraphFetchOptions = (
|
|
params: Omit<Parameters<typeof buildShareReferenceGraphFetchOptions>[0], "referenceAttachment">,
|
|
) =>
|
|
buildShareReferenceGraphFetchOptions({
|
|
referenceAttachment: createReferenceAttachment(),
|
|
...params,
|
|
});
|
|
type GraphEndpointResponseHandler = {
|
|
suffix: string;
|
|
buildResponse: () => Response;
|
|
};
|
|
const createGraphEndpointResponseHandlers = (params: {
|
|
hostedContents: unknown[];
|
|
attachments: unknown[];
|
|
messageAttachments: unknown[];
|
|
}): GraphEndpointResponseHandler[] => [
|
|
{
|
|
suffix: "/hostedContents",
|
|
buildResponse: () => createGraphCollectionResponse(params.hostedContents),
|
|
},
|
|
{
|
|
suffix: "/attachments",
|
|
buildResponse: () => createGraphCollectionResponse(params.attachments),
|
|
},
|
|
{
|
|
suffix: "/messages/123",
|
|
buildResponse: () => createJsonResponse({ attachments: params.messageAttachments }),
|
|
},
|
|
];
|
|
const resolveGraphEndpointResponse = (
|
|
url: string,
|
|
handlers: GraphEndpointResponseHandler[],
|
|
): Response | undefined => {
|
|
const handler = handlers.find((entry) => url.endsWith(entry.suffix));
|
|
return handler ? handler.buildResponse() : undefined;
|
|
};
|
|
|
|
const createGraphFetchMock = (options: GraphFetchMockOptions = {}) => {
|
|
const hostedContents = options.hostedContents ?? [];
|
|
const attachments = options.attachments ?? [];
|
|
const messageAttachments = options.messageAttachments ?? [];
|
|
const endpointHandlers = createGraphEndpointResponseHandlers({
|
|
hostedContents,
|
|
attachments,
|
|
messageAttachments,
|
|
});
|
|
return vi.fn(async (url: string) => {
|
|
const endpointResponse = resolveGraphEndpointResponse(url, endpointHandlers);
|
|
if (endpointResponse) {
|
|
return endpointResponse;
|
|
}
|
|
if (url.startsWith(GRAPH_SHARES_URL_PREFIX) && options.onShareRequest) {
|
|
return options.onShareRequest(url);
|
|
}
|
|
const unhandled = options.onUnhandled ? await options.onUnhandled(url) : undefined;
|
|
return unhandled ?? createNotFoundResponse();
|
|
});
|
|
};
|
|
const downloadGraphMediaWithMockOptions = async (
|
|
options: GraphFetchMockOptions = {},
|
|
overrides: DownloadGraphMediaOverrides = {},
|
|
): Promise<GraphMediaDownloadResult> => {
|
|
const fetchMock = createGraphFetchMock(options);
|
|
const media = await downloadMSTeamsGraphMedia({
|
|
messageUrl: DEFAULT_MESSAGE_URL,
|
|
tokenProvider: createTokenProvider(),
|
|
maxBytes: DEFAULT_MAX_BYTES,
|
|
fetchFn: asFetchFn(fetchMock),
|
|
...overrides,
|
|
});
|
|
return { fetchMock, media };
|
|
};
|
|
const runAttachmentDownloadSuccessCase = async ({
|
|
attachments,
|
|
buildFetchFn,
|
|
beforeDownload,
|
|
assert,
|
|
}: AttachmentDownloadSuccessCase) => {
|
|
const fetchFn = (buildFetchFn ?? (() => createOkFetchMock(CONTENT_TYPE_IMAGE_PNG)))();
|
|
beforeDownload?.();
|
|
const media = await downloadAttachmentsWithFetch(attachments, fetchFn);
|
|
expectSingleMedia(media);
|
|
assert?.(media);
|
|
};
|
|
const runAttachmentAuthRetryCase = async ({
|
|
scenario,
|
|
expectedMediaLength,
|
|
expectTokenFetch,
|
|
}: AttachmentAuthRetryCase) => {
|
|
const tokenProvider = createTokenProvider();
|
|
const fetchMock = createAuthAwareImageFetchMock({
|
|
unauthStatus: scenario.unauthStatus,
|
|
unauthBody: scenario.unauthBody,
|
|
});
|
|
const media = await downloadAttachmentsWithFetch(
|
|
createImageAttachments(scenario.attachmentUrl),
|
|
fetchMock,
|
|
{ tokenProvider, ...scenario.overrides },
|
|
);
|
|
expectAttachmentMediaLength(media, expectedMediaLength);
|
|
expectMockCallState(tokenProvider.getAccessToken, expectTokenFetch);
|
|
};
|
|
const runGraphMediaSuccessCase = async ({
|
|
buildOptions,
|
|
expectedLength,
|
|
assert,
|
|
}: GraphMediaSuccessCase) => {
|
|
const { fetchMock, media } = await downloadGraphMediaWithMockOptions(buildOptions());
|
|
expectAttachmentMediaLength(media.media, expectedLength);
|
|
assert?.({ fetchMock, media });
|
|
};
|
|
|
|
describe("msteams attachments", () => {
|
|
beforeEach(() => {
|
|
detectMimeMock.mockClear();
|
|
saveMediaBufferMock.mockClear();
|
|
fetchRemoteMediaMock.mockClear();
|
|
setMSTeamsRuntime(runtimeStub);
|
|
});
|
|
|
|
describe("buildMSTeamsAttachmentPlaceholder", () => {
|
|
it.each<AttachmentPlaceholderCase>(ATTACHMENT_PLACEHOLDER_CASES)(
|
|
"$label",
|
|
({ attachments, expected }) => {
|
|
expect(buildMSTeamsAttachmentPlaceholder(attachments)).toBe(expected);
|
|
},
|
|
);
|
|
});
|
|
|
|
describe("downloadMSTeamsAttachments", () => {
|
|
it.each<AttachmentDownloadSuccessCase>(ATTACHMENT_DOWNLOAD_SUCCESS_CASES)(
|
|
"$label",
|
|
runAttachmentDownloadSuccessCase,
|
|
);
|
|
|
|
it("stores inline data:image base64 payloads", async () => {
|
|
const media = await downloadMSTeamsAttachments(
|
|
buildDownloadParams([
|
|
...createHtmlImageAttachments([`data:image/png;base64,${PNG_BASE64}`]),
|
|
]),
|
|
);
|
|
|
|
expectSingleMedia(media);
|
|
expectMediaBufferSaved();
|
|
});
|
|
|
|
it.each<AttachmentAuthRetryCase>(ATTACHMENT_AUTH_RETRY_CASES)(
|
|
"$label",
|
|
runAttachmentAuthRetryCase,
|
|
);
|
|
|
|
it("preserves auth fallback when dispatcher-mode fetch returns a redirect", async () => {
|
|
const redirectedUrl = createTestUrl("redirected.png");
|
|
const tokenProvider = createTokenProvider();
|
|
const fetchMock = vi.fn(async (url: string, opts?: RequestInit) => {
|
|
const hasAuth = Boolean(new Headers(opts?.headers).get("Authorization"));
|
|
if (url === TEST_URL_IMAGE) {
|
|
return hasAuth
|
|
? createRedirectResponse(redirectedUrl)
|
|
: createTextResponse("unauthorized", 401);
|
|
}
|
|
if (url === redirectedUrl) {
|
|
return createBufferResponse(PNG_BUFFER, CONTENT_TYPE_IMAGE_PNG);
|
|
}
|
|
return createNotFoundResponse();
|
|
});
|
|
|
|
fetchRemoteMediaMock.mockImplementationOnce(async (params) => {
|
|
const fetchFn = params.fetchImpl ?? fetch;
|
|
let currentUrl = params.url;
|
|
for (let i = 0; i < MAX_REDIRECT_HOPS; i += 1) {
|
|
const res = await fetchFn(currentUrl, {
|
|
redirect: "manual",
|
|
dispatcher: {},
|
|
} as RequestInit);
|
|
if (REDIRECT_STATUS_CODES.includes(res.status)) {
|
|
const location = res.headers.get("location");
|
|
if (!location) {
|
|
throw new Error("redirect missing location");
|
|
}
|
|
currentUrl = new URL(location, currentUrl).toString();
|
|
continue;
|
|
}
|
|
return readRemoteMediaResponse(res, params);
|
|
}
|
|
throw new Error("too many redirects");
|
|
});
|
|
|
|
const media = await downloadAttachmentsWithFetch(
|
|
createImageAttachments(TEST_URL_IMAGE),
|
|
fetchMock,
|
|
{ tokenProvider, authAllowHosts: [TEST_HOST] },
|
|
);
|
|
|
|
expectAttachmentMediaLength(media, 1);
|
|
expect(tokenProvider.getAccessToken).toHaveBeenCalledOnce();
|
|
expect(fetchMock.mock.calls.map(([calledUrl]) => String(calledUrl))).toContain(redirectedUrl);
|
|
});
|
|
|
|
it("continues scope fallback after non-auth failure and succeeds on later scope", async () => {
|
|
let authAttempt = 0;
|
|
const tokenProvider = createTokenProvider((scope) => `token:${scope}`);
|
|
const fetchMock = vi.fn(async (_url: string, opts?: RequestInit) => {
|
|
const auth = new Headers(opts?.headers).get("Authorization");
|
|
if (!auth) {
|
|
return createTextResponse("unauthorized", 401);
|
|
}
|
|
authAttempt += 1;
|
|
if (authAttempt === 1) {
|
|
return createTextResponse("upstream transient", 500);
|
|
}
|
|
return createBufferResponse(PNG_BUFFER, CONTENT_TYPE_IMAGE_PNG);
|
|
});
|
|
|
|
const media = await downloadAttachmentsWithFetch(
|
|
createImageAttachments(TEST_URL_IMAGE),
|
|
fetchMock,
|
|
{ tokenProvider, authAllowHosts: [TEST_HOST] },
|
|
);
|
|
|
|
expectAttachmentMediaLength(media, 1);
|
|
expect(tokenProvider.getAccessToken).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("does not forward Authorization to redirects outside auth allowlist", async () => {
|
|
const tokenProvider = createTokenProvider("top-secret-token");
|
|
const graphFileUrl = createUrlForHost(GRAPH_HOST, "file");
|
|
const seen: Array<{ url: string; auth: string }> = [];
|
|
const fetchMock = vi.fn(async (url: string, opts?: RequestInit) => {
|
|
const auth = new Headers(opts?.headers).get("Authorization") ?? "";
|
|
seen.push({ url, auth });
|
|
if (url === graphFileUrl && !auth) {
|
|
return new Response("unauthorized", { status: 401 });
|
|
}
|
|
if (url === graphFileUrl && auth) {
|
|
return new Response("", {
|
|
status: 302,
|
|
headers: { location: "https://attacker.azureedge.net/collect" },
|
|
});
|
|
}
|
|
if (url === "https://attacker.azureedge.net/collect") {
|
|
return new Response(Buffer.from("png"), {
|
|
status: 200,
|
|
headers: { "content-type": CONTENT_TYPE_IMAGE_PNG },
|
|
});
|
|
}
|
|
return createNotFoundResponse();
|
|
});
|
|
|
|
const media = await downloadMSTeamsAttachments(
|
|
buildDownloadParams([{ contentType: CONTENT_TYPE_IMAGE_PNG, contentUrl: graphFileUrl }], {
|
|
tokenProvider,
|
|
allowHosts: [GRAPH_HOST, AZUREEDGE_HOST],
|
|
authAllowHosts: [GRAPH_HOST],
|
|
fetchFn: asFetchFn(fetchMock),
|
|
}),
|
|
);
|
|
|
|
expectSingleMedia(media);
|
|
const redirected = seen.find(
|
|
(entry) => entry.url === "https://attacker.azureedge.net/collect",
|
|
);
|
|
expect(redirected).toBeDefined();
|
|
expect(redirected?.auth).toBe("");
|
|
});
|
|
|
|
it("skips urls outside the allowlist", async () => {
|
|
const fetchMock = vi.fn();
|
|
const media = await downloadAttachmentsWithFetch(
|
|
createImageAttachments(TEST_URL_OUTSIDE_ALLOWLIST),
|
|
fetchMock,
|
|
{
|
|
allowHosts: [GRAPH_HOST],
|
|
},
|
|
{ expectFetchCalled: false },
|
|
);
|
|
|
|
expectAttachmentMediaLength(media, 0);
|
|
});
|
|
|
|
it("blocks redirects to non-https URLs", async () => {
|
|
const insecureUrl = "http://x/insecure.png";
|
|
const fetchMock = vi.fn(async (input: RequestInfo | URL) => {
|
|
const url = typeof input === "string" ? input : input.toString();
|
|
if (url === TEST_URL_IMAGE) {
|
|
return createRedirectResponse(insecureUrl);
|
|
}
|
|
if (url === insecureUrl) {
|
|
return createBufferResponse("insecure", CONTENT_TYPE_IMAGE_PNG);
|
|
}
|
|
return createNotFoundResponse();
|
|
});
|
|
|
|
const media = await downloadAttachmentsWithFetch(
|
|
createImageAttachments(TEST_URL_IMAGE),
|
|
fetchMock,
|
|
{
|
|
allowHosts: [TEST_HOST],
|
|
},
|
|
);
|
|
|
|
expectAttachmentMediaLength(media, 0);
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
describe("buildMSTeamsGraphMessageUrls", () => {
|
|
it.each(GRAPH_URL_EXPECTATION_CASES)("$label", ({ params, expectedPath }) => {
|
|
const urls = buildMSTeamsGraphMessageUrls(params);
|
|
expect(urls[0]).toContain(expectedPath);
|
|
});
|
|
});
|
|
|
|
describe("downloadMSTeamsGraphMedia", () => {
|
|
it.each<GraphMediaSuccessCase>(GRAPH_MEDIA_SUCCESS_CASES)("$label", runGraphMediaSuccessCase);
|
|
|
|
it("does not forward Authorization for SharePoint redirects outside auth allowlist", async () => {
|
|
const tokenProvider = createTokenProvider("top-secret-token");
|
|
const escapedUrl = "https://example.com/collect";
|
|
const seen: Array<{ url: string; auth: string }> = [];
|
|
const referenceAttachment = createReferenceAttachment();
|
|
const fetchMock = vi.fn(async (input: RequestInfo | URL, init?: RequestInit) => {
|
|
const url = String(input);
|
|
const auth = new Headers(init?.headers).get("Authorization") ?? "";
|
|
seen.push({ url, auth });
|
|
|
|
if (url === DEFAULT_MESSAGE_URL) {
|
|
return createJsonResponse({ attachments: [referenceAttachment] });
|
|
}
|
|
if (url === `${DEFAULT_MESSAGE_URL}/hostedContents`) {
|
|
return createGraphCollectionResponse([]);
|
|
}
|
|
if (url === `${DEFAULT_MESSAGE_URL}/attachments`) {
|
|
return createGraphCollectionResponse([referenceAttachment]);
|
|
}
|
|
if (url.startsWith(GRAPH_SHARES_URL_PREFIX)) {
|
|
return createRedirectResponse(escapedUrl);
|
|
}
|
|
if (url === escapedUrl) {
|
|
return createPdfResponse();
|
|
}
|
|
return createNotFoundResponse();
|
|
});
|
|
|
|
const media = await downloadMSTeamsGraphMedia({
|
|
messageUrl: DEFAULT_MESSAGE_URL,
|
|
tokenProvider,
|
|
maxBytes: DEFAULT_MAX_BYTES,
|
|
allowHosts: [...DEFAULT_SHAREPOINT_ALLOW_HOSTS, "example.com"],
|
|
authAllowHosts: DEFAULT_SHAREPOINT_ALLOW_HOSTS,
|
|
fetchFn: asFetchFn(fetchMock),
|
|
});
|
|
|
|
expectAttachmentMediaLength(media.media, 1);
|
|
const redirected = seen.find((entry) => entry.url === escapedUrl);
|
|
expect(redirected).toBeDefined();
|
|
expect(redirected?.auth).toBe("");
|
|
});
|
|
|
|
it("blocks SharePoint redirects to hosts outside allowHosts", async () => {
|
|
const escapedUrl = "https://evil.example/internal.pdf";
|
|
const { fetchMock, media } = await downloadGraphMediaWithMockOptions(
|
|
{
|
|
...buildDefaultShareReferenceGraphFetchOptions({
|
|
onShareRequest: () => createRedirectResponse(escapedUrl),
|
|
onUnhandled: (url) => {
|
|
if (url === escapedUrl) {
|
|
return createPdfResponse("should-not-be-fetched");
|
|
}
|
|
return undefined;
|
|
},
|
|
}),
|
|
},
|
|
{
|
|
allowHosts: DEFAULT_SHAREPOINT_ALLOW_HOSTS,
|
|
},
|
|
);
|
|
|
|
expectAttachmentMediaLength(media.media, 0);
|
|
const calledUrls = fetchMock.mock.calls.map((call) => String(call[0]));
|
|
expect(calledUrls.some((url) => url.startsWith(GRAPH_SHARES_URL_PREFIX))).toBe(true);
|
|
expect(calledUrls).not.toContain(escapedUrl);
|
|
});
|
|
});
|
|
|
|
describe("buildMSTeamsMediaPayload", () => {
|
|
it("returns single and multi-file fields", async () => {
|
|
const payload = buildMSTeamsMediaPayload(createImageMediaEntries("/tmp/a.png", "/tmp/b.png"));
|
|
expectMSTeamsMediaPayload(payload, {
|
|
firstPath: "/tmp/a.png",
|
|
paths: ["/tmp/a.png", "/tmp/b.png"],
|
|
types: [CONTENT_TYPE_IMAGE_PNG, CONTENT_TYPE_IMAGE_PNG],
|
|
});
|
|
});
|
|
});
|
|
});
|