mirror of
https://github.com/moltbot/moltbot.git
synced 2026-03-07 22:44:16 +00:00
* fix(ui): strip injected inbound metadata from user messages in history Fixes #21106 Fixes #21109 Fixes #22116 OpenClaw prepends structured metadata blocks ("Conversation info", "Sender:", reply-context) to user messages before sending them to the LLM. These blocks are intentionally AI-context-only and must never reach the chat history that users see. Root cause: `buildInboundUserContextPrefix` in `inbound-meta.ts` prepends the blocks directly to the stored user message content string, so they are persisted verbatim and later shown in webchat, TUI, and every other rendering surface. Fix: • `src/auto-reply/reply/strip-inbound-meta.ts` — new utility with a 6-sentinel fast-path strip (zero-alloc on miss) + 9-test suite. • `src/tui/tui-session-actions.ts` — wraps `chatLog.addUser(...)` with `stripInboundMetadata()` so the TUI never stores the prefix. • `ui/src/ui/chat/message-normalizer.ts` — strips user-role text content items during normalisation so webchat renders clean messages. * fix(ui): strip inbound metadata for user messages in display path * test: fix discord component send test spread typing * fix: strip inbound metadata from mac chat history decode * fix: align Swift metadata stripping parser with TS implementation * fix: normalize line endings in inbound metadata stripper * chore: document Swift/TS metadata-sentinel ownership * chore: update changelog for inbound metadata strip fix * changelog: credit Mellowambience for 22142 --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
108 lines
2.8 KiB
Swift
108 lines
2.8 KiB
Swift
import Testing
|
|
@testable import OpenClawChatUI
|
|
|
|
@Suite("ChatMarkdownPreprocessor")
|
|
struct ChatMarkdownPreprocessorTests {
|
|
@Test func extractsDataURLImages() {
|
|
let base64 = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQIHWP4////GQAJ+wP/2hN8NwAAAABJRU5ErkJggg=="
|
|
let markdown = """
|
|
Hello
|
|
|
|
)
|
|
"""
|
|
|
|
let result = ChatMarkdownPreprocessor.preprocess(markdown: markdown)
|
|
|
|
#expect(result.cleaned == "Hello")
|
|
#expect(result.images.count == 1)
|
|
#expect(result.images.first?.image != nil)
|
|
}
|
|
|
|
@Test func stripsInboundUntrustedContextBlocks() {
|
|
let markdown = """
|
|
Conversation info (untrusted metadata):
|
|
```json
|
|
{
|
|
"message_id": "123",
|
|
"sender": "openclaw-ios"
|
|
}
|
|
```
|
|
|
|
Sender (untrusted metadata):
|
|
```json
|
|
{
|
|
"label": "Razor"
|
|
}
|
|
```
|
|
|
|
Razor?
|
|
"""
|
|
|
|
let result = ChatMarkdownPreprocessor.preprocess(markdown: markdown)
|
|
|
|
#expect(result.cleaned == "Razor?")
|
|
}
|
|
|
|
@Test func stripsSingleConversationInfoBlock() {
|
|
let text = """
|
|
Conversation info (untrusted metadata):
|
|
```json
|
|
{"x": 1}
|
|
```
|
|
|
|
User message
|
|
"""
|
|
|
|
let result = ChatMarkdownPreprocessor.preprocess(markdown: text)
|
|
|
|
#expect(result.cleaned == "User message")
|
|
}
|
|
|
|
@Test func stripsAllKnownInboundMetadataSentinels() {
|
|
let sentinels = [
|
|
"Conversation info (untrusted metadata):",
|
|
"Sender (untrusted metadata):",
|
|
"Thread starter (untrusted, for context):",
|
|
"Replied message (untrusted, for context):",
|
|
"Forwarded message context (untrusted metadata):",
|
|
"Chat history since last reply (untrusted, for context):",
|
|
]
|
|
|
|
for sentinel in sentinels {
|
|
let markdown = """
|
|
\(sentinel)
|
|
```json
|
|
{"x": 1}
|
|
```
|
|
|
|
User content
|
|
"""
|
|
let result = ChatMarkdownPreprocessor.preprocess(markdown: markdown)
|
|
#expect(result.cleaned == "User content")
|
|
}
|
|
}
|
|
|
|
@Test func preservesNonMetadataJsonFence() {
|
|
let markdown = """
|
|
Here is some json:
|
|
```json
|
|
{"x": 1}
|
|
```
|
|
"""
|
|
|
|
let result = ChatMarkdownPreprocessor.preprocess(markdown: markdown)
|
|
|
|
#expect(result.cleaned == markdown.trimmingCharacters(in: .whitespacesAndNewlines))
|
|
}
|
|
|
|
@Test func stripsLeadingTimestampPrefix() {
|
|
let markdown = """
|
|
[Fri 2026-02-20 18:45 GMT+1] How's it going?
|
|
"""
|
|
|
|
let result = ChatMarkdownPreprocessor.preprocess(markdown: markdown)
|
|
|
|
#expect(result.cleaned == "How's it going?")
|
|
}
|
|
}
|