mirror of
https://github.com/moltbot/moltbot.git
synced 2026-03-07 22:44:16 +00:00
* feat(bluebubbles): auto-strip markdown from outbound messages (#7402) * fix(security): add timeout to webhook body reading (#6762) Adds 30-second timeout to readBody() in voice-call, bluebubbles, and nostr webhook handlers. Prevents Slow-Loris DoS (CWE-400, CVSS 7.5). Merged with existing maxBytes protection in voice-call. * fix(security): unify Error objects and lint fixes in webhook timeouts (#6762) * fix: prevent plugins from auto-enabling without user consent (#3961) Changes default plugin enabled state from true to false in enablePluginEntry(). Preserves existing enabled:true values. Fixes #3932. * fix: apply hierarchical mediaMaxMb config to all channels (#8749) Generalizes resolveAttachmentMaxBytes() to use account → channel → global config resolution for all channels, not just BlueBubbles. Fixes #7847. * fix(bluebubbles): sanitize attachment filenames against header injection (#10333) Strip ", \r, \n, and \\ from filenames after path.basename() to prevent multipart Content-Disposition header injection (CWE-93, CVSS 5.4). Also adds sanitization to setGroupIconBlueBubbles which had zero filename sanitization. * fix(lint): exclude extensions/ from Oxlint preflight check (#9313) Extensions use PluginRuntime|null patterns that trigger no-redundant-type-constituents because PluginRuntime resolves to any. Excluding extensions/ from Oxlint unblocks user upgrades. Re-applies the approach from closed PR #10087. * fix(bluebubbles): add tempGuid to createNewChatWithMessage payload (#7745) Non-Private-API mode (AppleScript) requires tempGuid in send payloads. The main sendMessageBlueBubbles already had it, but createNewChatWithMessage was missing it, causing 400 errors for new chat creation without Private API. * fix: send stop-typing signal when run ends with NO_REPLY (#8785) Adds onCleanup callback to the typing controller that fires when the controller is cleaned up while typing was active (e.g., after NO_REPLY). Channels using createTypingCallbacks automatically get stop-typing on cleanup. This prevents the typing indicator from lingering in group chats when the agent decides not to reply. * fix(telegram): deduplicate skill commands in multi-agent setup (#5717) Two fixes: 1. Skip duplicate workspace dirs when listing skill commands across agents. Multiple agents sharing the same workspace would produce duplicate commands with _2, _3 suffixes. 2. Clear stale commands via deleteMyCommands before registering new ones. Commands from deleted skills now get cleaned up on restart. * fix: add size limits to unbounded in-memory caches (#4948) Adds max-size caps with oldest-entry eviction to prevent OOM in long-running deployments: - BlueBubbles serverInfoCache: 64 entries (already has TTL) - Google Chat authCache: 32 entries - Matrix directRoomCache: 1024 entries - Discord presenceCache: 5000 entries per account * fix: address review concerns (#11093) - Chain deleteMyCommands → setMyCommands to prevent race condition (#5717) - Rename enablePluginEntry to registerPluginEntry (now sets enabled: false) - Add Slow-Loris timeout test for readJsonBody (#6023)
336 lines
8.5 KiB
TypeScript
336 lines
8.5 KiB
TypeScript
import type { MsgContext } from "../templating.js";
|
|
import type { GetReplyOptions, ReplyPayload } from "../types.js";
|
|
import {
|
|
resolveAgentDir,
|
|
resolveAgentWorkspaceDir,
|
|
resolveSessionAgentId,
|
|
resolveAgentSkillsFilter,
|
|
} from "../../agents/agent-scope.js";
|
|
import { resolveModelRefFromString } from "../../agents/model-selection.js";
|
|
import { resolveAgentTimeoutMs } from "../../agents/timeout.js";
|
|
import { DEFAULT_AGENT_WORKSPACE_DIR, ensureAgentWorkspace } from "../../agents/workspace.js";
|
|
import { type OpenClawConfig, loadConfig } from "../../config/config.js";
|
|
import { applyLinkUnderstanding } from "../../link-understanding/apply.js";
|
|
import { applyMediaUnderstanding } from "../../media-understanding/apply.js";
|
|
import { defaultRuntime } from "../../runtime.js";
|
|
import { resolveCommandAuthorization } from "../command-auth.js";
|
|
import { SILENT_REPLY_TOKEN } from "../tokens.js";
|
|
import { resolveDefaultModel } from "./directive-handling.js";
|
|
import { resolveReplyDirectives } from "./get-reply-directives.js";
|
|
import { handleInlineActions } from "./get-reply-inline-actions.js";
|
|
import { runPreparedReply } from "./get-reply-run.js";
|
|
import { finalizeInboundContext } from "./inbound-context.js";
|
|
import { applyResetModelOverride } from "./session-reset-model.js";
|
|
import { initSessionState } from "./session.js";
|
|
import { stageSandboxMedia } from "./stage-sandbox-media.js";
|
|
import { createTypingController } from "./typing.js";
|
|
|
|
function mergeSkillFilters(channelFilter?: string[], agentFilter?: string[]): string[] | undefined {
|
|
const normalize = (list?: string[]) => {
|
|
if (!Array.isArray(list)) {
|
|
return undefined;
|
|
}
|
|
return list.map((entry) => String(entry).trim()).filter(Boolean);
|
|
};
|
|
const channel = normalize(channelFilter);
|
|
const agent = normalize(agentFilter);
|
|
if (!channel && !agent) {
|
|
return undefined;
|
|
}
|
|
if (!channel) {
|
|
return agent;
|
|
}
|
|
if (!agent) {
|
|
return channel;
|
|
}
|
|
if (channel.length === 0 || agent.length === 0) {
|
|
return [];
|
|
}
|
|
const agentSet = new Set(agent);
|
|
return channel.filter((name) => agentSet.has(name));
|
|
}
|
|
|
|
export async function getReplyFromConfig(
|
|
ctx: MsgContext,
|
|
opts?: GetReplyOptions,
|
|
configOverride?: OpenClawConfig,
|
|
): Promise<ReplyPayload | ReplyPayload[] | undefined> {
|
|
const isFastTestEnv = process.env.OPENCLAW_TEST_FAST === "1";
|
|
const cfg = configOverride ?? loadConfig();
|
|
const targetSessionKey =
|
|
ctx.CommandSource === "native" ? ctx.CommandTargetSessionKey?.trim() : undefined;
|
|
const agentSessionKey = targetSessionKey || ctx.SessionKey;
|
|
const agentId = resolveSessionAgentId({
|
|
sessionKey: agentSessionKey,
|
|
config: cfg,
|
|
});
|
|
const mergedSkillFilter = mergeSkillFilters(
|
|
opts?.skillFilter,
|
|
resolveAgentSkillsFilter(cfg, agentId),
|
|
);
|
|
const resolvedOpts =
|
|
mergedSkillFilter !== undefined ? { ...opts, skillFilter: mergedSkillFilter } : opts;
|
|
const agentCfg = cfg.agents?.defaults;
|
|
const sessionCfg = cfg.session;
|
|
const { defaultProvider, defaultModel, aliasIndex } = resolveDefaultModel({
|
|
cfg,
|
|
agentId,
|
|
});
|
|
let provider = defaultProvider;
|
|
let model = defaultModel;
|
|
if (opts?.isHeartbeat) {
|
|
const heartbeatRaw = agentCfg?.heartbeat?.model?.trim() ?? "";
|
|
const heartbeatRef = heartbeatRaw
|
|
? resolveModelRefFromString({
|
|
raw: heartbeatRaw,
|
|
defaultProvider,
|
|
aliasIndex,
|
|
})
|
|
: null;
|
|
if (heartbeatRef) {
|
|
provider = heartbeatRef.ref.provider;
|
|
model = heartbeatRef.ref.model;
|
|
}
|
|
}
|
|
|
|
const workspaceDirRaw = resolveAgentWorkspaceDir(cfg, agentId) ?? DEFAULT_AGENT_WORKSPACE_DIR;
|
|
const workspace = await ensureAgentWorkspace({
|
|
dir: workspaceDirRaw,
|
|
ensureBootstrapFiles: !agentCfg?.skipBootstrap && !isFastTestEnv,
|
|
});
|
|
const workspaceDir = workspace.dir;
|
|
const agentDir = resolveAgentDir(cfg, agentId);
|
|
const timeoutMs = resolveAgentTimeoutMs({ cfg });
|
|
const configuredTypingSeconds =
|
|
agentCfg?.typingIntervalSeconds ?? sessionCfg?.typingIntervalSeconds;
|
|
const typingIntervalSeconds =
|
|
typeof configuredTypingSeconds === "number" ? configuredTypingSeconds : 6;
|
|
const typing = createTypingController({
|
|
onReplyStart: opts?.onReplyStart,
|
|
onCleanup: opts?.onTypingCleanup,
|
|
typingIntervalSeconds,
|
|
silentToken: SILENT_REPLY_TOKEN,
|
|
log: defaultRuntime.log,
|
|
});
|
|
opts?.onTypingController?.(typing);
|
|
|
|
const finalized = finalizeInboundContext(ctx);
|
|
|
|
if (!isFastTestEnv) {
|
|
await applyMediaUnderstanding({
|
|
ctx: finalized,
|
|
cfg,
|
|
agentDir,
|
|
activeModel: { provider, model },
|
|
});
|
|
await applyLinkUnderstanding({
|
|
ctx: finalized,
|
|
cfg,
|
|
});
|
|
}
|
|
|
|
const commandAuthorized = finalized.CommandAuthorized;
|
|
resolveCommandAuthorization({
|
|
ctx: finalized,
|
|
cfg,
|
|
commandAuthorized,
|
|
});
|
|
const sessionState = await initSessionState({
|
|
ctx: finalized,
|
|
cfg,
|
|
commandAuthorized,
|
|
});
|
|
let {
|
|
sessionCtx,
|
|
sessionEntry,
|
|
previousSessionEntry,
|
|
sessionStore,
|
|
sessionKey,
|
|
sessionId,
|
|
isNewSession,
|
|
resetTriggered,
|
|
systemSent,
|
|
abortedLastRun,
|
|
storePath,
|
|
sessionScope,
|
|
groupResolution,
|
|
isGroup,
|
|
triggerBodyNormalized,
|
|
bodyStripped,
|
|
} = sessionState;
|
|
|
|
await applyResetModelOverride({
|
|
cfg,
|
|
resetTriggered,
|
|
bodyStripped,
|
|
sessionCtx,
|
|
ctx: finalized,
|
|
sessionEntry,
|
|
sessionStore,
|
|
sessionKey,
|
|
storePath,
|
|
defaultProvider,
|
|
defaultModel,
|
|
aliasIndex,
|
|
});
|
|
|
|
const directiveResult = await resolveReplyDirectives({
|
|
ctx: finalized,
|
|
cfg,
|
|
agentId,
|
|
agentDir,
|
|
workspaceDir,
|
|
agentCfg,
|
|
sessionCtx,
|
|
sessionEntry,
|
|
sessionStore,
|
|
sessionKey,
|
|
storePath,
|
|
sessionScope,
|
|
groupResolution,
|
|
isGroup,
|
|
triggerBodyNormalized,
|
|
commandAuthorized,
|
|
defaultProvider,
|
|
defaultModel,
|
|
aliasIndex,
|
|
provider,
|
|
model,
|
|
typing,
|
|
opts: resolvedOpts,
|
|
skillFilter: mergedSkillFilter,
|
|
});
|
|
if (directiveResult.kind === "reply") {
|
|
return directiveResult.reply;
|
|
}
|
|
|
|
let {
|
|
commandSource,
|
|
command,
|
|
allowTextCommands,
|
|
skillCommands,
|
|
directives,
|
|
cleanedBody,
|
|
elevatedEnabled,
|
|
elevatedAllowed,
|
|
elevatedFailures,
|
|
defaultActivation,
|
|
resolvedThinkLevel,
|
|
resolvedVerboseLevel,
|
|
resolvedReasoningLevel,
|
|
resolvedElevatedLevel,
|
|
execOverrides,
|
|
blockStreamingEnabled,
|
|
blockReplyChunking,
|
|
resolvedBlockStreamingBreak,
|
|
provider: resolvedProvider,
|
|
model: resolvedModel,
|
|
modelState,
|
|
contextTokens,
|
|
inlineStatusRequested,
|
|
directiveAck,
|
|
perMessageQueueMode,
|
|
perMessageQueueOptions,
|
|
} = directiveResult.result;
|
|
provider = resolvedProvider;
|
|
model = resolvedModel;
|
|
|
|
const inlineActionResult = await handleInlineActions({
|
|
ctx,
|
|
sessionCtx,
|
|
cfg,
|
|
agentId,
|
|
agentDir,
|
|
sessionEntry,
|
|
previousSessionEntry,
|
|
sessionStore,
|
|
sessionKey,
|
|
storePath,
|
|
sessionScope,
|
|
workspaceDir,
|
|
isGroup,
|
|
opts: resolvedOpts,
|
|
typing,
|
|
allowTextCommands,
|
|
inlineStatusRequested,
|
|
command,
|
|
skillCommands,
|
|
directives,
|
|
cleanedBody,
|
|
elevatedEnabled,
|
|
elevatedAllowed,
|
|
elevatedFailures,
|
|
defaultActivation: () => defaultActivation,
|
|
resolvedThinkLevel,
|
|
resolvedVerboseLevel,
|
|
resolvedReasoningLevel,
|
|
resolvedElevatedLevel,
|
|
resolveDefaultThinkingLevel: modelState.resolveDefaultThinkingLevel,
|
|
provider,
|
|
model,
|
|
contextTokens,
|
|
directiveAck,
|
|
abortedLastRun,
|
|
skillFilter: mergedSkillFilter,
|
|
});
|
|
if (inlineActionResult.kind === "reply") {
|
|
return inlineActionResult.reply;
|
|
}
|
|
directives = inlineActionResult.directives;
|
|
abortedLastRun = inlineActionResult.abortedLastRun ?? abortedLastRun;
|
|
|
|
await stageSandboxMedia({
|
|
ctx,
|
|
sessionCtx,
|
|
cfg,
|
|
sessionKey,
|
|
workspaceDir,
|
|
});
|
|
|
|
return runPreparedReply({
|
|
ctx,
|
|
sessionCtx,
|
|
cfg,
|
|
agentId,
|
|
agentDir,
|
|
agentCfg,
|
|
sessionCfg,
|
|
commandAuthorized,
|
|
command,
|
|
commandSource,
|
|
allowTextCommands,
|
|
directives,
|
|
defaultActivation,
|
|
resolvedThinkLevel,
|
|
resolvedVerboseLevel,
|
|
resolvedReasoningLevel,
|
|
resolvedElevatedLevel,
|
|
execOverrides,
|
|
elevatedEnabled,
|
|
elevatedAllowed,
|
|
blockStreamingEnabled,
|
|
blockReplyChunking,
|
|
resolvedBlockStreamingBreak,
|
|
modelState,
|
|
provider,
|
|
model,
|
|
perMessageQueueMode,
|
|
perMessageQueueOptions,
|
|
typing,
|
|
opts: resolvedOpts,
|
|
defaultProvider,
|
|
defaultModel,
|
|
timeoutMs,
|
|
isNewSession,
|
|
resetTriggered,
|
|
systemSent,
|
|
sessionEntry,
|
|
sessionStore,
|
|
sessionKey,
|
|
sessionId,
|
|
storePath,
|
|
workspaceDir,
|
|
abortedLastRun,
|
|
});
|
|
}
|