test(perf): slim ios team-id harness and add perf budget guard

test/scripts/ios-team-id.test.ts

@@ -16,6 +16,60 @@ let sharedHomeDir = "";
 let sharedHomeBinDir = "";
 let sharedFakePythonPath = "";
 const runScriptCache = new Map<string, { ok: boolean; stdout: string; stderr: string }>();
+type TeamCandidate = {
+  teamId: string;
+  isFree: boolean;
+  teamName: string;
+};
+
+function parseTeamCandidateRows(raw: string): TeamCandidate[] {
+  return raw
+    .split("\n")
+    .map((line) => line.replace(/\r/g, "").trim())
+    .filter(Boolean)
+    .map((line) => line.split("\t"))
+    .filter((parts) => parts.length >= 3)
+    .map((parts) => ({
+      teamId: parts[0] ?? "",
+      isFree: (parts[1] ?? "0") === "1",
+      teamName: parts[2] ?? "",
+    }))
+    .filter((candidate) => candidate.teamId.length > 0);
+}
+
+function pickTeamIdFromCandidates(params: {
+  candidates: TeamCandidate[];
+  preferredTeamId?: string;
+  preferredTeamName?: string;
+  preferNonFreeTeam?: boolean;
+}): string | undefined {
+  const preferredTeamId = (params.preferredTeamId ?? "").trim();
+  if (preferredTeamId) {
+    const preferred = params.candidates.find((candidate) => candidate.teamId === preferredTeamId);
+    if (preferred) {
+      return preferred.teamId;
+    }
+  }
+
+  const preferredTeamName = (params.preferredTeamName ?? "").trim().toLowerCase();
+  if (preferredTeamName) {
+    const preferredByName = params.candidates.find(
+      (candidate) => candidate.teamName.trim().toLowerCase() === preferredTeamName,
+    );
+    if (preferredByName) {
+      return preferredByName.teamId;
+    }
+  }
+
+  if (params.preferNonFreeTeam !== false) {
+    const paid = params.candidates.find((candidate) => !candidate.isFree);
+    if (paid) {
+      return paid.teamId;
+    }
+  }
+
+  return params.candidates[0]?.teamId;
+}
 
 async function writeExecutable(filePath: string, body: string): Promise<void> {
   await writeFile(filePath, body, "utf8");
@@ -133,19 +187,32 @@ printf 'BBBBB22222\\t0\\tBeta Team\\r\\n'`,
     await rm(fixtureRoot, { recursive: true, force: true });
   });
 
-  it("resolves fallback and preferred team IDs from Xcode team listings", async () => {
-    const fallbackResult = runScript(sharedHomeDir, {
-      IOS_PYTHON_BIN: sharedFakePythonPath,
+  it("parses team listings and prioritizes preferred IDs without shelling out", () => {
+    const rows = parseTeamCandidateRows(
+      "AAAAA11111\t1\tAlpha Team\r\nBBBBB22222\t0\tBeta Team\r\n",
+    );
+    expect(rows).toStrictEqual([
+      { teamId: "AAAAA11111", isFree: true, teamName: "Alpha Team" },
+      { teamId: "BBBBB22222", isFree: false, teamName: "Beta Team" },
+    ]);
+
+    const preferred = pickTeamIdFromCandidates({
+      candidates: rows,
+      preferredTeamId: "BBBBB22222",
     });
+    expect(preferred).toBe("BBBBB22222");
+
+    const fallback = pickTeamIdFromCandidates({
+      candidates: rows,
+      preferredTeamId: "CCCCCC3333",
+    });
+    expect(fallback).toBe("BBBBB22222");
+  });
+
+  it("resolves a fallback team ID from Xcode team listings (smoke)", async () => {
+    const fallbackResult = runScript(sharedHomeDir, { IOS_PYTHON_BIN: sharedFakePythonPath });
     expect(fallbackResult.ok).toBe(true);
     expect(fallbackResult.stdout).toBe("AAAAA11111");
-
-    const crlfResult = runScript(sharedHomeDir, {
-      IOS_PYTHON_BIN: sharedFakePythonPath,
-      IOS_PREFERRED_TEAM_ID: "BBBBB22222",
-    });
-    expect(crlfResult.ok).toBe(true);
-    expect(crlfResult.stdout).toBe("BBBBB22222");
   });
 
   it("prints actionable guidance when Xcode account exists but no Team ID is resolvable", async () => {