LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-04-26 16:06:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(tests): dedupe tool, projector, and delivery fixtures

Browse Source
This commit is contained in:
Peter Steinberger
2026-03-03 01:05:24 +00:00
parent c3d5159121
commit a48a3dbdda
6 changed files with 552 additions and 599 deletions
Download Patch File Download Diff File Expand all files Collapse all files

214
src/auto-reply/reply/acp-projector.test.ts
View File

@@ -18,6 +18,30 @@ function createProjectorHarness(cfgOverrides?: Parameters<typeof createCfg>[0])
return { deliveries, projector };
}
function createLiveCfgOverrides(
streamOverrides: Record<string, unknown>,
): Parameters<typeof createCfg>[0] {
return {
acp: {
enabled: true,
stream: {
deliveryMode: "live",
...streamOverrides,
},
},
} as Parameters<typeof createCfg>[0];
}
function createHiddenBoundaryCfg(
streamOverrides: Record<string, unknown> = {},
): Parameters<typeof createCfg>[0] {
return createLiveCfgOverrides({
coalesceIdleMs: 0,
maxChunkChars: 256,
...streamOverrides,
});
}
function blockDeliveries(deliveries: Delivery[]) {
return deliveries.filter((entry) => entry.kind === "block");
}
@@ -92,6 +116,22 @@ function createLiveStatusAndToolLifecycleHarness(params?: {
});
}
async function emitToolLifecycleEvent(
projector: ReturnType<typeof createProjectorHarness>["projector"],
event: {
tag: "tool_call" | "tool_call_update";
toolCallId: string;
status: "in_progress" | "completed";
title?: string;
text: string;
},
) {
await projector.onEvent({
type: "tool_call",
...event,
});
}
async function runHiddenBoundaryCase(params: {
cfgOverrides?: Parameters<typeof createCfg>[0];
toolCallId: string;
@@ -152,16 +192,12 @@ describe("createAcpReplyProjector", () => {
});
it("does not suppress identical short text across terminal turn boundaries", async () => {
const { deliveries, projector } = createProjectorHarness({
acp: {
enabled: true,
stream: {
deliveryMode: "live",
coalesceIdleMs: 0,
maxChunkChars: 64,
},
},
});
const { deliveries, projector } = createProjectorHarness(
createLiveCfgOverrides({
coalesceIdleMs: 0,
maxChunkChars: 64,
}),
);
await projector.onEvent({ type: "text_delta", text: "A", tag: "agent_message_chunk" });
await projector.onEvent({ type: "done", stopReason: "end_turn" });
@@ -177,16 +213,12 @@ describe("createAcpReplyProjector", () => {
it("flushes staggered live text deltas after idle gaps", async () => {
vi.useFakeTimers();
try {
const { deliveries, projector } = createProjectorHarness({
acp: {
enabled: true,
stream: {
deliveryMode: "live",
coalesceIdleMs: 50,
maxChunkChars: 64,
},
},
});
const { deliveries, projector } = createProjectorHarness(
createLiveCfgOverrides({
coalesceIdleMs: 50,
maxChunkChars: 64,
}),
);
await projector.onEvent({ type: "text_delta", text: "A", tag: "agent_message_chunk" });
await vi.advanceTimersByTimeAsync(760);
@@ -236,16 +268,12 @@ describe("createAcpReplyProjector", () => {
it("does not flush short live fragments mid-phrase on idle", async () => {
vi.useFakeTimers();
try {
const { deliveries, projector } = createProjectorHarness({
acp: {
enabled: true,
stream: {
deliveryMode: "live",
coalesceIdleMs: 100,
maxChunkChars: 256,
},
},
});
const { deliveries, projector } = createProjectorHarness(
createLiveCfgOverrides({
coalesceIdleMs: 100,
maxChunkChars: 256,
}),
);
await projector.onEvent({
type: "text_delta",
@@ -350,19 +378,15 @@ describe("createAcpReplyProjector", () => {
});
expect(hidden).toEqual([]);
const { deliveries: shown, projector: shownProjector } = createProjectorHarness({
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 64,
deliveryMode: "live",
tagVisibility: {
usage_update: true,
},
const { deliveries: shown, projector: shownProjector } = createProjectorHarness(
createLiveCfgOverrides({
coalesceIdleMs: 0,
maxChunkChars: 64,
tagVisibility: {
usage_update: true,
},
},
});
}),
);
await shownProjector.onEvent({
type: "status",
@@ -406,32 +430,28 @@ describe("createAcpReplyProjector", () => {
it("dedupes repeated tool lifecycle updates when repeatSuppression is enabled", async () => {
const { deliveries, projector } = createLiveToolLifecycleHarness();
await projector.onEvent({
type: "tool_call",
await emitToolLifecycleEvent(projector, {
tag: "tool_call",
toolCallId: "call_1",
status: "in_progress",
title: "List files",
text: "List files (in_progress)",
});
await projector.onEvent({
type: "tool_call",
await emitToolLifecycleEvent(projector, {
tag: "tool_call_update",
toolCallId: "call_1",
status: "in_progress",
title: "List files",
text: "List files (in_progress)",
});
await projector.onEvent({
type: "tool_call",
await emitToolLifecycleEvent(projector, {
tag: "tool_call_update",
toolCallId: "call_1",
status: "completed",
title: "List files",
text: "List files (completed)",
});
await projector.onEvent({
type: "tool_call",
await emitToolLifecycleEvent(projector, {
tag: "tool_call_update",
toolCallId: "call_1",
status: "completed",
@@ -451,16 +471,14 @@ describe("createAcpReplyProjector", () => {
const longTitle =
"Run an intentionally long command title that truncates before lifecycle status is visible";
await projector.onEvent({
type: "tool_call",
await emitToolLifecycleEvent(projector, {
tag: "tool_call",
toolCallId: "call_truncated_status",
status: "in_progress",
title: longTitle,
text: `${longTitle} (in_progress)`,
});
await projector.onEvent({
type: "tool_call",
await emitToolLifecycleEvent(projector, {
tag: "tool_call_update",
toolCallId: "call_truncated_status",
status: "completed",
@@ -541,19 +559,15 @@ describe("createAcpReplyProjector", () => {
});
it("suppresses exact duplicate status updates when repeatSuppression is enabled", async () => {
const { deliveries, projector } = createProjectorHarness({
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 256,
deliveryMode: "live",
tagVisibility: {
available_commands_update: true,
},
const { deliveries, projector } = createProjectorHarness(
createLiveCfgOverrides({
coalesceIdleMs: 0,
maxChunkChars: 256,
tagVisibility: {
available_commands_update: true,
},
},
});
}),
);
await projector.onEvent({
type: "status",
@@ -649,16 +663,7 @@ describe("createAcpReplyProjector", () => {
it("inserts a space boundary before visible text after hidden tool updates by default", async () => {
await runHiddenBoundaryCase({
cfgOverrides: {
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 256,
deliveryMode: "live",
},
},
},
cfgOverrides: createHiddenBoundaryCfg(),
toolCallId: "call_hidden_1",
expectedText: "fallback. I don't",
});
@@ -666,20 +671,12 @@ describe("createAcpReplyProjector", () => {
it("preserves hidden boundary across nonterminal hidden tool updates", async () => {
await runHiddenBoundaryCase({
cfgOverrides: {
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 256,
deliveryMode: "live",
tagVisibility: {
tool_call: false,
tool_call_update: false,
},
},
cfgOverrides: createHiddenBoundaryCfg({
tagVisibility: {
tool_call: false,
tool_call_update: false,
},
},
}),
toolCallId: "hidden_boundary_1",
includeNonTerminalUpdate: true,
expectedText: "fallback. I don't",
@@ -688,17 +685,9 @@ describe("createAcpReplyProjector", () => {
it("supports hiddenBoundarySeparator=space", async () => {
await runHiddenBoundaryCase({
cfgOverrides: {
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 256,
deliveryMode: "live",
hiddenBoundarySeparator: "space",
},
},
},
cfgOverrides: createHiddenBoundaryCfg({
hiddenBoundarySeparator: "space",
}),
toolCallId: "call_hidden_2",
expectedText: "fallback. I don't",
});
@@ -706,17 +695,9 @@ describe("createAcpReplyProjector", () => {
it("supports hiddenBoundarySeparator=none", async () => {
await runHiddenBoundaryCase({
cfgOverrides: {
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 256,
deliveryMode: "live",
hiddenBoundarySeparator: "none",
},
},
},
cfgOverrides: createHiddenBoundaryCfg({
hiddenBoundarySeparator: "none",
}),
toolCallId: "call_hidden_3",
expectedText: "fallback.I don't",
});
@@ -724,16 +705,7 @@ describe("createAcpReplyProjector", () => {
it("does not duplicate newlines when previous visible text already ends with newline", async () => {
await runHiddenBoundaryCase({
cfgOverrides: {
acp: {
enabled: true,
stream: {
coalesceIdleMs: 0,
maxChunkChars: 256,
deliveryMode: "live",
},
},
},
cfgOverrides: createHiddenBoundaryCfg(),
toolCallId: "call_hidden_4",
firstText: "fallback.\n",
expectedText: "fallback.\nI don't",

136
src/auto-reply/reply/reply-utils.test.ts
View File

@@ -157,6 +157,27 @@ describe("typing controller", () => {
vi.useRealTimers();
});
function createTestTypingController() {
const onReplyStart = vi.fn();
const typing = createTypingController({
onReplyStart,
typingIntervalSeconds: 1,
typingTtlMs: 30_000,
});
return { typing, onReplyStart };
}
function markTypingState(
typing: ReturnType<typeof createTypingController>,
state: "run" | "idle",
) {
if (state === "run") {
typing.markRunComplete();
return;
}
typing.markDispatchIdle();
}
it("stops only after both run completion and dispatcher idle are set (any order)", async () => {
vi.useFakeTimers();
const cases = [
@@ -165,12 +186,7 @@ describe("typing controller", () => {
] as const;
for (const testCase of cases) {
const onReplyStart = vi.fn();
const typing = createTypingController({
onReplyStart,
typingIntervalSeconds: 1,
typingTtlMs: 30_000,
});
const { typing, onReplyStart } = createTestTypingController();
await typing.startTypingLoop();
expect(onReplyStart, testCase.name).toHaveBeenCalledTimes(1);
@@ -178,19 +194,11 @@ describe("typing controller", () => {
await vi.advanceTimersByTimeAsync(2_000);
expect(onReplyStart, testCase.name).toHaveBeenCalledTimes(3);
if (testCase.first === "run") {
typing.markRunComplete();
} else {
typing.markDispatchIdle();
}
markTypingState(typing, testCase.first);
await vi.advanceTimersByTimeAsync(2_000);
expect(onReplyStart, testCase.name).toHaveBeenCalledTimes(testCase.first === "run" ? 3 : 5);
if (testCase.second === "run") {
typing.markRunComplete();
} else {
typing.markDispatchIdle();
}
markTypingState(typing, testCase.second);
await vi.advanceTimersByTimeAsync(2_000);
expect(onReplyStart, testCase.name).toHaveBeenCalledTimes(testCase.first === "run" ? 3 : 5);
}
@@ -198,12 +206,7 @@ describe("typing controller", () => {
it("does not start typing after run completion", async () => {
vi.useFakeTimers();
const onReplyStart = vi.fn();
const typing = createTypingController({
onReplyStart,
typingIntervalSeconds: 1,
typingTtlMs: 30_000,
});
const { typing, onReplyStart } = createTestTypingController();
typing.markRunComplete();
await typing.startTypingOnText("late text");
@@ -213,12 +216,7 @@ describe("typing controller", () => {
it("does not restart typing after it has stopped", async () => {
vi.useFakeTimers();
const onReplyStart = vi.fn();
const typing = createTypingController({
onReplyStart,
typingIntervalSeconds: 1,
typingTtlMs: 30_000,
});
const { typing, onReplyStart } = createTestTypingController();
await typing.startTypingLoop();
expect(onReplyStart).toHaveBeenCalledTimes(1);
@@ -358,6 +356,21 @@ describe("parseAudioTag", () => {
});
describe("resolveResponsePrefixTemplate", () => {
function expectResolvedTemplateCases<
T extends ReadonlyArray<{
name: string;
template: string | undefined;
values: Parameters<typeof resolveResponsePrefixTemplate>[1];
expected: string | undefined;
}>,
>(cases: T) {
for (const testCase of cases) {
expect(resolveResponsePrefixTemplate(testCase.template, testCase.values), testCase.name).toBe(
testCase.expected,
);
}
}
it("resolves known variables, aliases, and case-insensitive tokens", () => {
const cases = [
{
@@ -420,11 +433,7 @@ describe("resolveResponsePrefixTemplate", () => {
expected: "[OpenClaw] anthropic/claude-opus-4-5 (think:high)",
},
] as const;
for (const testCase of cases) {
expect(resolveResponsePrefixTemplate(testCase.template, testCase.values), testCase.name).toBe(
testCase.expected,
);
}
expectResolvedTemplateCases(cases);
});
it("preserves unresolved/unknown placeholders and handles static inputs", () => {
@@ -450,11 +459,7 @@ describe("resolveResponsePrefixTemplate", () => {
expected: "[gpt-5.2 | {provider}]",
},
] as const;
for (const testCase of cases) {
expect(resolveResponsePrefixTemplate(testCase.template, testCase.values), testCase.name).toBe(
testCase.expected,
);
}
expectResolvedTemplateCases(cases);
});
});
@@ -556,16 +561,32 @@ describe("block reply coalescer", () => {
vi.useRealTimers();
});
it("coalesces chunks within the idle window", async () => {
vi.useFakeTimers();
function createBlockCoalescerHarness(config: {
minChars: number;
maxChars: number;
idleMs: number;
joiner: string;
flushOnEnqueue?: boolean;
}) {
const flushes: string[] = [];
const coalescer = createBlockReplyCoalescer({
config: { minChars: 1, maxChars: 200, idleMs: 100, joiner: " " },
config,
shouldAbort: () => false,
onFlush: (payload) => {
flushes.push(payload.text ?? "");
},
});
return { flushes, coalescer };
}
it("coalesces chunks within the idle window", async () => {
vi.useFakeTimers();
const { flushes, coalescer } = createBlockCoalescerHarness({
minChars: 1,
maxChars: 200,
idleMs: 100,
joiner: " ",
});
coalescer.enqueue({ text: "Hello" });
coalescer.enqueue({ text: "world" });
@@ -577,13 +598,11 @@ describe("block reply coalescer", () => {
it("waits until minChars before idle flush", async () => {
vi.useFakeTimers();
const flushes: string[] = [];
const coalescer = createBlockReplyCoalescer({
config: { minChars: 10, maxChars: 200, idleMs: 50, joiner: " " },
shouldAbort: () => false,
onFlush: (payload) => {
flushes.push(payload.text ?? "");
},
const { flushes, coalescer } = createBlockCoalescerHarness({
minChars: 10,
maxChars: 200,
idleMs: 50,
joiner: " ",
});
coalescer.enqueue({ text: "short" });
@@ -598,13 +617,11 @@ describe("block reply coalescer", () => {
it("still accumulates when flushOnEnqueue is not set (default)", async () => {
vi.useFakeTimers();
const flushes: string[] = [];
const coalescer = createBlockReplyCoalescer({
config: { minChars: 1, maxChars: 2000, idleMs: 100, joiner: "\n\n" },
shouldAbort: () => false,
onFlush: (payload) => {
flushes.push(payload.text ?? "");
},
const { flushes, coalescer } = createBlockCoalescerHarness({
minChars: 1,
maxChars: 2000,
idleMs: 100,
joiner: "\n\n",
});
coalescer.enqueue({ text: "First paragraph" });
@@ -630,14 +647,7 @@ describe("block reply coalescer", () => {
] as const;
for (const testCase of cases) {
const flushes: string[] = [];
const coalescer = createBlockReplyCoalescer({
config: testCase.config,
shouldAbort: () => false,
onFlush: (payload) => {
flushes.push(payload.text ?? "");
},
});
const { flushes, coalescer } = createBlockCoalescerHarness(testCase.config);
for (const input of testCase.inputs) {
coalescer.enqueue({ text: input });
}