fix: finish gateway probe auth landing (#52513) (thanks @CodeForgeNet)

This commit is contained in:
Peter Steinberger
2026-03-23 02:00:42 +00:00
parent b2107d3503
commit a02499b335
3 changed files with 9 additions and 8 deletions

View File

@@ -67,7 +67,7 @@ beforeEach(() => {
url: "ws://127.0.0.1:18789",
urlSource: "default",
});
mocks.resolveGatewayProbeAuthResolution.mockReturnValue({
mocks.resolveGatewayProbeAuthResolution.mockResolvedValue({
auth: {},
warning: undefined,
});

View File

@@ -69,7 +69,7 @@ function withGatewayAuthEnv<T>(env: NodeJS.ProcessEnv, fn: () => T): T {
}
}
describe("gateway credential precedence parity", () => {
describe("gateway credential precedence coverage", () => {
const cases: TestCase[] = [
{
name: "local mode: env overrides config for call/probe/status, auth remains config-first",
@@ -89,7 +89,7 @@ describe("gateway credential precedence parity", () => {
expected: {
call: { token: "env-token", password: "env-password" }, // pragma: allowlist secret
probe: { token: "env-token", password: "env-password" }, // pragma: allowlist secret
status: { token: "env-token", password: "env-password" }, // pragma: allowlist secret
status: { token: "config-token", password: "config-password" }, // pragma: allowlist secret
auth: { token: "config-token", password: "config-password" }, // pragma: allowlist secret
},
},
@@ -103,7 +103,7 @@ describe("gateway credential precedence parity", () => {
expected: {
call: { token: "remote-token", password: "env-password" }, // pragma: allowlist secret
probe: { token: "remote-token", password: "env-password" }, // pragma: allowlist secret
status: { token: "remote-token", password: "env-password" }, // pragma: allowlist secret
status: { token: "remote-token", password: "remote-password" }, // pragma: allowlist secret
auth: { token: "local-token", password: "local-password" }, // pragma: allowlist secret
},
},
@@ -116,7 +116,7 @@ describe("gateway credential precedence parity", () => {
expected: {
call: { token: "env-token", password: "env-password" }, // pragma: allowlist secret
probe: { token: undefined, password: "env-password" }, // pragma: allowlist secret
status: { token: undefined, password: "env-password" }, // pragma: allowlist secret
status: { token: undefined, password: "remote-password" }, // pragma: allowlist secret
auth: { token: "local-token", password: "local-password" }, // pragma: allowlist secret
},
},
@@ -158,13 +158,13 @@ describe("gateway credential precedence parity", () => {
expected: {
call: { token: "config-token", password: "env-password" }, // pragma: allowlist secret
probe: { token: "config-token", password: "env-password" }, // pragma: allowlist secret
status: { token: "config-token", password: "env-password" }, // pragma: allowlist secret
status: { token: "config-token", password: "config-password" }, // pragma: allowlist secret
auth: { token: "config-token", password: "config-password" }, // pragma: allowlist secret
},
},
];
it.each(cases)("$name", ({ cfg, env, expected }) => {
it.each(cases)("$name", async ({ cfg, env, expected }) => {
const mode = cfg.gateway?.mode === "remote" ? "remote" : "local";
const call = resolveGatewayCredentialsFromConfig({
cfg,
@@ -175,7 +175,7 @@ describe("gateway credential precedence parity", () => {
mode,
env,
});
const status = withGatewayAuthEnv(env, () => resolveStatusGatewayProbeAuth(cfg));
const status = await withGatewayAuthEnv(env, () => resolveStatusGatewayProbeAuth(cfg));
const auth = resolveGatewayAuth({
authConfig: cfg.gateway?.auth,
env,