From 4fed265d050c4eea490366c5317416233bb3905c Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 12 May 2026 01:01:01 +0100 Subject: [PATCH] test: guard browser internal cdp mock calls --- .../src/browser/cdp.helpers.internal.test.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/extensions/browser/src/browser/cdp.helpers.internal.test.ts b/extensions/browser/src/browser/cdp.helpers.internal.test.ts index 53775942bc7..c5d33ae052b 100644 --- a/extensions/browser/src/browser/cdp.helpers.internal.test.ts +++ b/extensions/browser/src/browser/cdp.helpers.internal.test.ts @@ -49,6 +49,15 @@ describe("cdp.helpers internal", () => { } }); + function requireGuardedFetchRequest() { + const [call] = fetchWithSsrFGuardMock.mock.calls; + if (!call) { + throw new Error("expected guarded CDP fetch call"); + } + const [request] = call; + return request; + } + describe("assertCdpEndpointAllowed", () => { it("throws on non-http/https/ws/wss protocols under any SSRF policy", async () => { await expect( @@ -142,7 +151,7 @@ describe("cdp.helpers internal", () => { await fetchCdpChecked("http://93.184.216.34:9222/json/version", 250, undefined, { allowPrivateNetwork: true, }); - const [request] = fetchWithSsrFGuardMock.mock.calls[0] ?? []; + const request = requireGuardedFetchRequest(); expect(request?.policy?.allowPrivateNetwork).toBe(true); }); @@ -154,7 +163,7 @@ describe("cdp.helpers internal", () => { release, }); await fetchCdpChecked("http://93.184.216.34:9222/json/version", 250); - const [request] = fetchWithSsrFGuardMock.mock.calls[0] ?? []; + const request = requireGuardedFetchRequest(); expect(request?.policy).toEqual({ allowPrivateNetwork: true }); }); });