diff --git a/src/agents/workspace-dirs.ts b/src/agents/workspace-dirs.ts new file mode 100644 index 00000000000..62adbddd471 --- /dev/null +++ b/src/agents/workspace-dirs.ts @@ -0,0 +1,16 @@ +import type { OpenClawConfig } from "../config/config.js"; +import { resolveAgentWorkspaceDir, resolveDefaultAgentId } from "./agent-scope.js"; + +export function listAgentWorkspaceDirs(cfg: OpenClawConfig): string[] { + const dirs = new Set(); + const list = cfg.agents?.list; + if (Array.isArray(list)) { + for (const entry of list) { + if (entry && typeof entry === "object" && typeof entry.id === "string") { + dirs.add(resolveAgentWorkspaceDir(cfg, entry.id)); + } + } + } + dirs.add(resolveAgentWorkspaceDir(cfg, resolveDefaultAgentId(cfg))); + return [...dirs]; +} diff --git a/src/gateway/server-methods/skills.ts b/src/gateway/server-methods/skills.ts index c1336fd4d61..c4039a18726 100644 --- a/src/gateway/server-methods/skills.ts +++ b/src/gateway/server-methods/skills.ts @@ -8,6 +8,7 @@ import { import { installSkill } from "../../agents/skills-install.js"; import { buildWorkspaceSkillStatus } from "../../agents/skills-status.js"; import { loadWorkspaceSkillEntries, type SkillEntry } from "../../agents/skills.js"; +import { listAgentWorkspaceDirs } from "../../agents/workspace-dirs.js"; import { loadConfig, writeConfigFile } from "../../config/config.js"; import { getRemoteSkillEligibility } from "../../infra/skills-remote.js"; import { normalizeAgentId } from "../../routing/session-key.js"; @@ -22,20 +23,6 @@ import { validateSkillsUpdateParams, } from "../protocol/index.js"; -function listWorkspaceDirs(cfg: OpenClawConfig): string[] { - const dirs = new Set(); - const list = cfg.agents?.list; - if (Array.isArray(list)) { - for (const entry of list) { - if (entry && typeof entry === "object" && typeof entry.id === "string") { - dirs.add(resolveAgentWorkspaceDir(cfg, entry.id)); - } - } - } - dirs.add(resolveAgentWorkspaceDir(cfg, resolveDefaultAgentId(cfg))); - return [...dirs]; -} - function collectSkillBins(entries: SkillEntry[]): string[] { const bins = new Set(); for (const entry of entries) { @@ -114,7 +101,7 @@ export const skillsHandlers: GatewayRequestHandlers = { return; } const cfg = loadConfig(); - const workspaceDirs = listWorkspaceDirs(cfg); + const workspaceDirs = listAgentWorkspaceDirs(cfg); const bins = new Set(); for (const workspaceDir of workspaceDirs) { const entries = loadWorkspaceSkillEntries(workspaceDir, { config: cfg }); diff --git a/src/infra/skills-remote.ts b/src/infra/skills-remote.ts index 01d49804b3c..ea1e4de422a 100644 --- a/src/infra/skills-remote.ts +++ b/src/infra/skills-remote.ts @@ -1,9 +1,9 @@ import type { SkillEligibilityContext, SkillEntry } from "../agents/skills.js"; import type { OpenClawConfig } from "../config/config.js"; import type { NodeRegistry } from "../gateway/node-registry.js"; -import { resolveAgentWorkspaceDir, resolveDefaultAgentId } from "../agents/agent-scope.js"; import { loadWorkspaceSkillEntries } from "../agents/skills.js"; import { bumpSkillsSnapshotVersion } from "../agents/skills/refresh.js"; +import { listAgentWorkspaceDirs } from "../agents/workspace-dirs.js"; import { createSubsystemLogger } from "../logging/subsystem.js"; import { listNodePairing, updatePairedNodeMetadata } from "./node-pairing.js"; @@ -172,20 +172,6 @@ export function removeRemoteNodeInfo(nodeId: string) { remoteNodes.delete(nodeId); } -function listWorkspaceDirs(cfg: OpenClawConfig): string[] { - const dirs = new Set(); - const list = cfg.agents?.list; - if (Array.isArray(list)) { - for (const entry of list) { - if (entry && typeof entry === "object" && typeof entry.id === "string") { - dirs.add(resolveAgentWorkspaceDir(cfg, entry.id)); - } - } - } - dirs.add(resolveAgentWorkspaceDir(cfg, resolveDefaultAgentId(cfg))); - return [...dirs]; -} - function collectRequiredBins(entries: SkillEntry[], targetPlatform: string): string[] { const bins = new Set(); for (const entry of entries) { @@ -272,7 +258,7 @@ export async function refreshRemoteNodeBins(params: { return; } - const workspaceDirs = listWorkspaceDirs(params.cfg); + const workspaceDirs = listAgentWorkspaceDirs(params.cfg); const requiredBins = new Set(); for (const workspaceDir of workspaceDirs) { const entries = loadWorkspaceSkillEntries(workspaceDir, { config: params.cfg }); diff --git a/src/security/audit-extra.async.ts b/src/security/audit-extra.async.ts index e2bd4d0bbba..2b95c43b4cf 100644 --- a/src/security/audit-extra.async.ts +++ b/src/security/audit-extra.async.ts @@ -10,7 +10,7 @@ import type { OpenClawConfig, ConfigFileSnapshot } from "../config/config.js"; import type { AgentToolsConfig } from "../config/types.tools.js"; import type { SkillScanFinding } from "./skill-scanner.js"; import type { ExecFn } from "./windows-acl.js"; -import { resolveAgentWorkspaceDir, resolveDefaultAgentId } from "../agents/agent-scope.js"; +import { resolveDefaultAgentId } from "../agents/agent-scope.js"; import { isToolAllowedByPolicies } from "../agents/pi-tools.policy.js"; import { resolveSandboxConfigForAgent, @@ -18,6 +18,7 @@ import { } from "../agents/sandbox.js"; import { loadWorkspaceSkillEntries } from "../agents/skills.js"; import { resolveToolProfilePolicy } from "../agents/tool-policy.js"; +import { listAgentWorkspaceDirs } from "../agents/workspace-dirs.js"; import { MANIFEST_KEY } from "../compat/legacy-names.js"; import { resolveNativeSkillsEnabled } from "../config/commands.js"; import { createConfigIO } from "../config/config.js"; @@ -81,20 +82,6 @@ async function readPluginManifestExtensions(pluginPath: string): Promise (typeof entry === "string" ? entry.trim() : "")).filter(Boolean); } -function listWorkspaceDirs(cfg: OpenClawConfig): string[] { - const dirs = new Set(); - const list = cfg.agents?.list; - if (Array.isArray(list)) { - for (const entry of list) { - if (entry && typeof entry === "object" && typeof entry.id === "string") { - dirs.add(resolveAgentWorkspaceDir(cfg, entry.id)); - } - } - } - dirs.add(resolveAgentWorkspaceDir(cfg, resolveDefaultAgentId(cfg))); - return [...dirs]; -} - function formatCodeSafetyDetails(findings: SkillScanFinding[], rootDir: string): string { return findings .map((finding) => { @@ -741,7 +728,7 @@ export async function collectInstalledSkillsCodeSafetyFindings(params: { const findings: SecurityAuditFinding[] = []; const pluginExtensionsDir = path.join(params.stateDir, "extensions"); const scannedSkillDirs = new Set(); - const workspaceDirs = listWorkspaceDirs(params.cfg); + const workspaceDirs = listAgentWorkspaceDirs(params.cfg); for (const workspaceDir of workspaceDirs) { const entries = loadWorkspaceSkillEntries(workspaceDir, { config: params.cfg });