LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-04-25 23:47:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: harden telegram forum-service mention guard typing (#32262) (thanks @scoootscooob)

Browse Source
This commit is contained in:
Peter Steinberger
2026-03-02 23:32:40 +00:00
parent 58ad617e64
commit 28c88e9fa1
3 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/telegram/bot-message-context.implicit-mention.test.ts
View File

@@ -2,6 +2,15 @@ import { describe, expect, it } from "vitest";
import { buildTelegramMessageContextForTest } from "./bot-message-context.test-harness.js";
describe("buildTelegramMessageContext implicitMention forum service messages", () => {
const TELEGRAM_FORUM_SERVICE_FIELDS = [
"forum_topic_created",
"forum_topic_edited",
"forum_topic_closed",
"forum_topic_reopened",
"general_forum_topic_hidden",
"general_forum_topic_unhidden",
] as const;
/**
* Build a group message context where the user sends a message inside a
* forum topic that has `reply_to_message` pointing to a message from the
@@ -62,6 +71,19 @@ describe("buildTelegramMessageContext implicitMention forum service messages", (
expect(ctx).toBeNull();
});
it.each(TELEGRAM_FORUM_SERVICE_FIELDS)(
"does NOT trigger implicitMention for %s service message",
async (field) => {
const ctx = await buildGroupReplyCtx({
replyToMessageText: undefined,
replyFromIsBot: true,
replyToMessageExtra: { [field]: {} },
});
expect(ctx).toBeNull();
},
);
it("does NOT trigger implicitMention for forum_topic_closed service message", async () => {
const ctx = await buildGroupReplyCtx({
replyToMessageText: undefined,

7
src/telegram/bot-message-context.ts
View File

@@ -888,9 +888,10 @@ const FORUM_SERVICE_FIELDS = [
* `forum_topic_*` / `general_forum_topic_*` fields and should not count as
* regular bot replies for implicit-mention purposes.
*/
function isTelegramForumServiceMessage(msg: Record<string, unknown> | undefined | null): boolean {
if (!msg) {
function isTelegramForumServiceMessage(msg: unknown): boolean {
if (!msg || typeof msg !== "object") {
return false;
}
return FORUM_SERVICE_FIELDS.some((f) => msg[f] != null);
const record = msg as Record<string, unknown>;
return FORUM_SERVICE_FIELDS.some((f) => record[f] != null);
}