test(perf): speed up cron, memory, and secrets hotspots

This commit is contained in:
Peter Steinberger
2026-03-03 00:42:13 +00:00
parent 86090b0ff2
commit 282b107e99
5 changed files with 183 additions and 36 deletions

View File

@@ -1,7 +1,8 @@
import "./isolated-agent.mocks.js";
import fs from "node:fs/promises";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { withTempHome as withTempHomeBase } from "../../test/helpers/temp-home.js";
import os from "node:os";
import path from "node:path";
import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
import { runSubagentAnnounceFlow } from "../agents/subagent-announce.js";
import type { CliDeps } from "../cli/deps.js";
import {
@@ -14,8 +15,67 @@ import { runCronIsolatedAgentTurn } from "./isolated-agent.js";
import { makeCfg, makeJob, writeSessionStore } from "./isolated-agent.test-harness.js";
import { setupIsolatedAgentTurnMocks } from "./isolated-agent.test-setup.js";
type HomeEnvSnapshot = {
HOME: string | undefined;
USERPROFILE: string | undefined;
HOMEDRIVE: string | undefined;
HOMEPATH: string | undefined;
OPENCLAW_HOME: string | undefined;
OPENCLAW_STATE_DIR: string | undefined;
};
const TELEGRAM_TARGET = { mode: "announce", channel: "telegram", to: "123" } as const;
let suiteTempHomeRoot = "";
let suiteTempHomeCaseId = 0;
function snapshotHomeEnv(): HomeEnvSnapshot {
return {
HOME: process.env.HOME,
USERPROFILE: process.env.USERPROFILE,
HOMEDRIVE: process.env.HOMEDRIVE,
HOMEPATH: process.env.HOMEPATH,
OPENCLAW_HOME: process.env.OPENCLAW_HOME,
OPENCLAW_STATE_DIR: process.env.OPENCLAW_STATE_DIR,
};
}
function restoreHomeEnv(snapshot: HomeEnvSnapshot) {
const restoreValue = (key: keyof HomeEnvSnapshot) => {
const value = snapshot[key];
if (value === undefined) {
delete process.env[key];
} else {
process.env[key] = value;
}
};
restoreValue("HOME");
restoreValue("USERPROFILE");
restoreValue("HOMEDRIVE");
restoreValue("HOMEPATH");
restoreValue("OPENCLAW_HOME");
restoreValue("OPENCLAW_STATE_DIR");
}
async function withTempHome<T>(fn: (home: string) => Promise<T>): Promise<T> {
return withTempHomeBase(fn, { prefix: "openclaw-cron-delivery-suite-" });
const home = path.join(suiteTempHomeRoot, `case-${suiteTempHomeCaseId++}`);
await fs.mkdir(path.join(home, ".openclaw", "agents", "main", "sessions"), { recursive: true });
const snapshot = snapshotHomeEnv();
process.env.HOME = home;
process.env.USERPROFILE = home;
delete process.env.OPENCLAW_HOME;
process.env.OPENCLAW_STATE_DIR = path.join(home, ".openclaw");
if (process.platform === "win32") {
const parsed = path.parse(home);
if (parsed.root) {
process.env.HOMEDRIVE = parsed.root.replace(/[\\/]+$/, "");
process.env.HOMEPATH = home.slice(process.env.HOMEDRIVE.length) || "\\";
}
}
try {
return await fn(home);
} finally {
restoreHomeEnv(snapshot);
}
}
async function runExplicitTelegramAnnounceTurn(params: {
@@ -25,7 +85,7 @@ async function runExplicitTelegramAnnounceTurn(params: {
}): Promise<Awaited<ReturnType<typeof runCronIsolatedAgentTurn>>> {
return runTelegramAnnounceTurn({
...params,
delivery: { mode: "announce", channel: "telegram", to: "123" },
delivery: TELEGRAM_TARGET,
});
}
@@ -77,9 +137,7 @@ async function expectStructuredTelegramFailure(params: {
storePath,
deps,
delivery: {
mode: "announce",
channel: "telegram",
to: "123",
...TELEGRAM_TARGET,
...(params.bestEffort ? { bestEffort: true } : {}),
},
});
@@ -168,6 +226,19 @@ async function assertExplicitTelegramTargetAnnounce(params: {
}
describe("runCronIsolatedAgentTurn", () => {
beforeAll(async () => {
suiteTempHomeRoot = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-cron-delivery-suite-"));
});
afterAll(async () => {
if (!suiteTempHomeRoot) {
return;
}
await fs.rm(suiteTempHomeRoot, { recursive: true, force: true });
suiteTempHomeRoot = "";
suiteTempHomeCaseId = 0;
});
beforeEach(() => {
setupIsolatedAgentTurnMocks();
});

View File

@@ -1,8 +1,8 @@
import "./isolated-agent.mocks.js";
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { withTempHome as withTempHomeBase } from "../../test/helpers/temp-home.js";
import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
import { loadModelCatalog } from "../agents/model-catalog.js";
import { runEmbeddedPiAgent } from "../agents/pi-embedded.js";
import type { CliDeps } from "../cli/deps.js";
@@ -15,8 +15,66 @@ import {
} from "./isolated-agent.test-harness.js";
import type { CronJob } from "./types.js";
type HomeEnvSnapshot = {
HOME: string | undefined;
USERPROFILE: string | undefined;
HOMEDRIVE: string | undefined;
HOMEPATH: string | undefined;
OPENCLAW_HOME: string | undefined;
OPENCLAW_STATE_DIR: string | undefined;
};
let suiteTempHomeRoot = "";
let suiteTempHomeCaseId = 0;
function snapshotHomeEnv(): HomeEnvSnapshot {
return {
HOME: process.env.HOME,
USERPROFILE: process.env.USERPROFILE,
HOMEDRIVE: process.env.HOMEDRIVE,
HOMEPATH: process.env.HOMEPATH,
OPENCLAW_HOME: process.env.OPENCLAW_HOME,
OPENCLAW_STATE_DIR: process.env.OPENCLAW_STATE_DIR,
};
}
function restoreHomeEnv(snapshot: HomeEnvSnapshot) {
const restoreValue = (key: keyof HomeEnvSnapshot) => {
const value = snapshot[key];
if (value === undefined) {
delete process.env[key];
} else {
process.env[key] = value;
}
};
restoreValue("HOME");
restoreValue("USERPROFILE");
restoreValue("HOMEDRIVE");
restoreValue("HOMEPATH");
restoreValue("OPENCLAW_HOME");
restoreValue("OPENCLAW_STATE_DIR");
}
async function withTempHome<T>(fn: (home: string) => Promise<T>): Promise<T> {
return withTempHomeBase(fn, { prefix: "openclaw-cron-turn-suite-" });
const home = path.join(suiteTempHomeRoot, `case-${suiteTempHomeCaseId++}`);
await fs.mkdir(path.join(home, ".openclaw", "agents", "main", "sessions"), { recursive: true });
const snapshot = snapshotHomeEnv();
process.env.HOME = home;
process.env.USERPROFILE = home;
delete process.env.OPENCLAW_HOME;
process.env.OPENCLAW_STATE_DIR = path.join(home, ".openclaw");
if (process.platform === "win32") {
const parsed = path.parse(home);
if (parsed.root) {
process.env.HOMEDRIVE = parsed.root.replace(/[\\/]+$/, "");
process.env.HOMEPATH = home.slice(process.env.HOMEDRIVE.length) || "\\";
}
}
try {
return await fn(home);
} finally {
restoreHomeEnv(snapshot);
}
}
function makeDeps(): CliDeps {
@@ -166,6 +224,19 @@ async function runStoredOverrideAndExpectModel(params: {
}
describe("runCronIsolatedAgentTurn", () => {
beforeAll(async () => {
suiteTempHomeRoot = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-cron-turn-suite-"));
});
afterAll(async () => {
if (!suiteTempHomeRoot) {
return;
}
await fs.rm(suiteTempHomeRoot, { recursive: true, force: true });
suiteTempHomeRoot = "";
suiteTempHomeCaseId = 0;
});
beforeEach(() => {
vi.mocked(runEmbeddedPiAgent).mockClear();
vi.mocked(loadModelCatalog).mockResolvedValue([]);