LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-03-08 06:54:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(exec): restore sandbox as implicit host default

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-23 01:48:09 +01:00
parent 211ab9e4f6
commit 278331c49c
4 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/agents/bash-tools.exec.path.test.ts
View File

@@ -126,19 +126,25 @@ describe("exec host env validation", () => {
).rejects.toThrow(/Security Violation: Environment variable 'LD_DEBUG' is forbidden/);
});
it("defaults to gateway when sandbox runtime is unavailable", async () => {
it("defaults to sandbox when sandbox runtime is unavailable", async () => {
const tool = createExecTool({ security: "full", ask: "off" });
const result = await tool.execute("call1", {
command: "echo ok",
});
const text = normalizeText(result.content.find((c) => c.type === "text")?.text);
expect(text).toContain("ok");
const err = await tool
.execute("call1", {
.execute("call2", {
command: "echo ok",
host: "sandbox",
host: "gateway",
})
.then(() => null)
.catch((error: unknown) => (error instanceof Error ? error : new Error(String(error))));
expect(err).toBeTruthy();
expect(err?.message).toMatch(/exec host not allowed/);
expect(err?.message).toMatch(/tools\.exec\.host=gateway/);
expect(err?.message).toMatch(/tools\.exec\.host=sandbox/);
});
it("fails closed when sandbox host is explicitly configured without sandbox runtime", async () => {

2
src/agents/bash-tools.exec.ts
View File

@@ -300,7 +300,7 @@ export function createExecTool(
if (elevatedRequested) {
logInfo(`exec: elevated command ${truncateMiddle(params.command, 120)}`);
}
const configuredHost = defaults?.host ?? (defaults?.sandbox ? "sandbox" : "gateway");
const configuredHost = defaults?.host ?? "sandbox";
const sandboxHostConfigured = defaults?.host === "sandbox";
const requestedHost = normalizeExecHost(params.host) ?? null;
let host: ExecHost = requestedHost ?? configuredHost;