LLM/moltbot
1
0
Fork 0
mirror of https://github.com/moltbot/moltbot.git synced 2026-04-23 14:45:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add facade recursion regression coverage (#57508) (thanks @openperf)

Browse Source
This commit is contained in:
Ayaan Zaidi
2026-03-30 13:46:25 +05:30
parent 9a03fe8181
commit 0b632dde8c
2 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/plugin-sdk/facade-runtime.test.ts
View File

@@ -31,6 +31,36 @@ function createThrowingPluginDir(prefix: string): string {
return rootDir;
}
function createCircularPluginDir(prefix: string): string {
const rootDir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
tempDirs.push(rootDir);
fs.mkdirSync(path.join(rootDir, "demo"), { recursive: true });
fs.writeFileSync(
path.join(rootDir, "facade.mjs"),
[
`import { loadBundledPluginPublicSurfaceModuleSync } from ${JSON.stringify(
new URL("./facade-runtime.js", import.meta.url).href,
)};`,
`export const marker = loadBundledPluginPublicSurfaceModuleSync({ dirName: "demo", artifactBasename: "api.js" }).marker;`,
"",
].join("\n"),
"utf8",
);
fs.writeFileSync(
path.join(rootDir, "demo", "helper.js"),
['import { marker } from "../facade.mjs";', "export const circularMarker = marker;", ""].join(
"\n",
),
"utf8",
);
fs.writeFileSync(
path.join(rootDir, "demo", "api.js"),
['import "./helper.js";', 'export const marker = "circular-ok";', ""].join("\n"),
"utf8",
);
return rootDir;
}
afterEach(() => {
vi.restoreAllMocks();
if (originalBundledPluginsDir === undefined) {
@@ -79,6 +109,18 @@ describe("plugin-sdk facade runtime", () => {
expect(first.marker).toBe("identity-check");
});
it("breaks circular facade re-entry during module evaluation", () => {
const dir = createCircularPluginDir("openclaw-facade-circular-");
process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = dir;
const loaded = loadBundledPluginPublicSurfaceModuleSync<{ marker: string }>({
dirName: "demo",
artifactBasename: "api.js",
});
expect(loaded.marker).toBe("circular-ok");
});
it("clears the cache on load failure so retries re-execute", () => {
const dir = createThrowingPluginDir("openclaw-facade-throw-");
process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = dir;