mirror of
https://github.com/arc53/DocsGPT.git
synced 2026-02-22 12:21:39 +00:00
Artifacts-backed persistence for Agent “Self” tools (Notes / Todo) + streaming artifact_id support (#2267)
* (feat:memory) use fs/storage for files
* (feat:todo) artifact_id via sse
* (feat:notes) artifact id return
* (feat:artifact) add get endpoint, store todos with conv id
* (feat: artifacts) fe integration
* feat(artifacts): ui enhancements, notes as mkdwn
* chore(artifacts) updated artifact tests
* (feat:todo_tool) return all todo items
* (feat:tools) use specific tool names in bubble
* feat: add conversationId prop to artifact components in Conversation
* Revert "(feat:memory) use fs/storage for files"
This reverts commit d1ce3bea31.
* (fix:fe) build fail
This commit is contained in:
Manish Madan
194
tests/agents/test_get_artifact.py
Normal file
194
tests/agents/test_get_artifact.py
Normal file
@@ -0,0 +1,194 @@
|
||||
from datetime import datetime
|
||||
|
||||
import pytest
|
||||
from bson.objectid import ObjectId
|
||||
from flask import request
|
||||
|
||||
|
||||
@pytest.mark.unit
|
||||
class TestGetArtifact:
|
||||
def test_note_artifact_success(self, mock_mongo_db, flask_app, decoded_token):
|
||||
from application.core.settings import settings
|
||||
from application.api.user.tools.routes import GetArtifact
|
||||
|
||||
db = mock_mongo_db[settings.MONGO_DB_NAME]
|
||||
note_id = ObjectId()
|
||||
db["notes"].insert_one(
|
||||
{
|
||||
"_id": note_id,
|
||||
"user_id": decoded_token["sub"],
|
||||
"tool_id": "tool1",
|
||||
"note": "a\nb",
|
||||
"updated_at": datetime(2025, 1, 1),
|
||||
}
|
||||
)
|
||||
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context():
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get(str(note_id))
|
||||
|
||||
assert resp.status_code == 200
|
||||
assert resp.json["artifact"]["artifact_type"] == "note"
|
||||
assert resp.json["artifact"]["data"]["content"] == "a\nb"
|
||||
assert resp.json["artifact"]["data"]["line_count"] == 2
|
||||
|
||||
def test_todo_artifact_success(self, mock_mongo_db, flask_app, decoded_token):
|
||||
from application.core.settings import settings
|
||||
from application.api.user.tools.routes import GetArtifact
|
||||
|
||||
db = mock_mongo_db[settings.MONGO_DB_NAME]
|
||||
todo_id_1 = ObjectId()
|
||||
todo_id_2 = ObjectId()
|
||||
db["todos"].insert_many([
|
||||
{
|
||||
"_id": todo_id_1,
|
||||
"user_id": decoded_token["sub"],
|
||||
"tool_id": "tool1",
|
||||
"todo_id": 1,
|
||||
"title": "First task",
|
||||
"status": "open",
|
||||
"created_at": datetime(2025, 1, 1),
|
||||
"updated_at": datetime(2025, 1, 1),
|
||||
},
|
||||
{
|
||||
"_id": todo_id_2,
|
||||
"user_id": decoded_token["sub"],
|
||||
"tool_id": "tool1",
|
||||
"todo_id": 2,
|
||||
"title": "Second task",
|
||||
"status": "completed",
|
||||
"created_at": datetime(2025, 1, 1),
|
||||
"updated_at": datetime(2025, 1, 2),
|
||||
},
|
||||
])
|
||||
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context():
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get(str(todo_id_1))
|
||||
|
||||
assert resp.status_code == 200
|
||||
assert resp.json["artifact"]["artifact_type"] == "todo_list"
|
||||
data = resp.json["artifact"]["data"]
|
||||
assert data["total_count"] == 2
|
||||
assert data["open_count"] == 1
|
||||
assert data["completed_count"] == 1
|
||||
assert len(data["items"]) == 2
|
||||
# Verify both todos are returned
|
||||
todo_ids = [item["todo_id"] for item in data["items"]]
|
||||
assert 1 in todo_ids
|
||||
assert 2 in todo_ids
|
||||
|
||||
def test_todo_artifact_all_param(self, mock_mongo_db, flask_app, decoded_token):
|
||||
"""Test that all todos are returned regardless of the 'all' query parameter."""
|
||||
from application.core.settings import settings
|
||||
from application.api.user.tools.routes import GetArtifact
|
||||
|
||||
db = mock_mongo_db[settings.MONGO_DB_NAME]
|
||||
todo_id_1 = ObjectId()
|
||||
todo_id_2 = ObjectId()
|
||||
db["todos"].insert_many([
|
||||
{
|
||||
"_id": todo_id_1,
|
||||
"user_id": decoded_token["sub"],
|
||||
"tool_id": "tool1",
|
||||
"todo_id": 1,
|
||||
"title": "First task",
|
||||
"status": "open",
|
||||
"created_at": datetime(2025, 1, 1),
|
||||
"updated_at": datetime(2025, 1, 1),
|
||||
},
|
||||
{
|
||||
"_id": todo_id_2,
|
||||
"user_id": decoded_token["sub"],
|
||||
"tool_id": "tool1",
|
||||
"todo_id": 2,
|
||||
"title": "Second task",
|
||||
"status": "completed",
|
||||
"created_at": datetime(2025, 1, 1),
|
||||
"updated_at": datetime(2025, 1, 2),
|
||||
},
|
||||
])
|
||||
|
||||
# Test without query parameter - should return all todos
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context():
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get(str(todo_id_1))
|
||||
|
||||
assert resp.status_code == 200
|
||||
assert resp.json["artifact"]["artifact_type"] == "todo_list"
|
||||
data = resp.json["artifact"]["data"]
|
||||
assert data["total_count"] == 2
|
||||
assert data["open_count"] == 1
|
||||
assert data["completed_count"] == 1
|
||||
assert len(data["items"]) == 2
|
||||
|
||||
# Test with query parameter (should still return all todos, parameter is ignored)
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context(query_string={"all": "true"}):
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get(str(todo_id_1))
|
||||
|
||||
assert resp.status_code == 200
|
||||
assert resp.json["artifact"]["artifact_type"] == "todo_list"
|
||||
data = resp.json["artifact"]["data"]
|
||||
assert data["total_count"] == 2
|
||||
assert data["open_count"] == 1
|
||||
assert data["completed_count"] == 1
|
||||
assert len(data["items"]) == 2
|
||||
|
||||
def test_invalid_artifact_id_returns_400(self, mock_mongo_db, flask_app, decoded_token):
|
||||
from application.api.user.tools.routes import GetArtifact
|
||||
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context():
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get("not_an_object_id")
|
||||
|
||||
assert resp.status_code == 400
|
||||
assert resp.json["message"] == "Invalid artifact ID"
|
||||
|
||||
def test_artifact_not_found_returns_404(self, mock_mongo_db, flask_app, decoded_token):
|
||||
from application.api.user.tools.routes import GetArtifact
|
||||
|
||||
non_existent_id = ObjectId()
|
||||
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context():
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get(str(non_existent_id))
|
||||
|
||||
assert resp.status_code == 404
|
||||
assert resp.json["message"] == "Artifact not found"
|
||||
|
||||
def test_other_user_artifact_returns_404(self, mock_mongo_db, flask_app, decoded_token):
|
||||
from application.core.settings import settings
|
||||
from application.api.user.tools.routes import GetArtifact
|
||||
|
||||
db = mock_mongo_db[settings.MONGO_DB_NAME]
|
||||
note_id = ObjectId()
|
||||
db["notes"].insert_one(
|
||||
{
|
||||
"_id": note_id,
|
||||
"user_id": "other_user",
|
||||
"tool_id": "tool1",
|
||||
"note": "secret",
|
||||
"updated_at": datetime(2025, 1, 1),
|
||||
}
|
||||
)
|
||||
|
||||
with flask_app.app_context():
|
||||
with flask_app.test_request_context():
|
||||
request.decoded_token = decoded_token
|
||||
resource = GetArtifact()
|
||||
resp = resource.get(str(note_id))
|
||||
|
||||
assert resp.status_code == 404
|
||||
Reference in New Issue
Block a user