From 9583f6b1c5124d1ac86f93361144eec5b81838ba Mon Sep 17 00:00:00 2001
From: Mansi <mansi@example.com>
Date: Fri, 5 Dec 2025 23:06:07 +0300
Subject: [PATCH] refactor: extract setKiroIncognitoMode helper to reduce code
 duplication

- Added setKiroIncognitoMode() helper function to handle Kiro auth incognito mode setting
- Replaced 3 duplicate code blocks (21 lines) with single function calls (3 lines)
- Kiro auth defaults to incognito mode for multi-account support
- Users can override with --incognito or --no-incognito flags

This addresses the code duplication noted in PR #1 review.
---
 cmd/server/main.go | 37 ++++++++++++++++---------------------
 1 file changed, 16 insertions(+), 21 deletions(-)

diff --git a/cmd/server/main.go b/cmd/server/main.go
index 28c3e514..ef949187 100644
--- a/cmd/server/main.go
+++ b/cmd/server/main.go
@@ -47,6 +47,19 @@ func init() {
 	buildinfo.BuildDate = BuildDate
 }
 
+// setKiroIncognitoMode sets the incognito browser mode for Kiro authentication.
+// Kiro defaults to incognito mode for multi-account support.
+// Users can explicitly override with --incognito or --no-incognito flags.
+func setKiroIncognitoMode(cfg *config.Config, useIncognito, noIncognito bool) {
+	if useIncognito {
+		cfg.IncognitoBrowser = true
+	} else if noIncognito {
+		cfg.IncognitoBrowser = false
+	} else {
+		cfg.IncognitoBrowser = true // Kiro default
+	}
+}
+
 // main is the entry point of the application.
 // It parses command-line flags, loads configuration, and starts the appropriate
 // service based on the provided flags (login, codex-login, or server mode).
@@ -465,36 +478,18 @@ func main() {
 		// Users can explicitly override with --no-incognito
 		// Note: This config mutation is safe - auth commands exit after completion
 		// and don't share config with StartService (which is in the else branch)
-		if useIncognito {
-			cfg.IncognitoBrowser = true
-		} else if noIncognito {
-			cfg.IncognitoBrowser = false
-		} else {
-			cfg.IncognitoBrowser = true // Kiro default
-		}
+		setKiroIncognitoMode(cfg, useIncognito, noIncognito)
 		cmd.DoKiroLogin(cfg, options)
 	} else if kiroGoogleLogin {
 		// For Kiro auth, default to incognito mode for multi-account support
 		// Users can explicitly override with --no-incognito
 		// Note: This config mutation is safe - auth commands exit after completion
-		if useIncognito {
-			cfg.IncognitoBrowser = true
-		} else if noIncognito {
-			cfg.IncognitoBrowser = false
-		} else {
-			cfg.IncognitoBrowser = true // Kiro default
-		}
+		setKiroIncognitoMode(cfg, useIncognito, noIncognito)
 		cmd.DoKiroGoogleLogin(cfg, options)
 	} else if kiroAWSLogin {
 		// For Kiro auth, default to incognito mode for multi-account support
 		// Users can explicitly override with --no-incognito
-		if useIncognito {
-			cfg.IncognitoBrowser = true
-		} else if noIncognito {
-			cfg.IncognitoBrowser = false
-		} else {
-			cfg.IncognitoBrowser = true // Kiro default
-		}
+		setKiroIncognitoMode(cfg, useIncognito, noIncognito)
 		cmd.DoKiroAWSLogin(cfg, options)
 	} else if kiroImport {
 		cmd.DoKiroImport(cfg, options)