From cf7016b36d37f1969a4352f974ccd7551e800681 Mon Sep 17 00:00:00 2001 From: Meng Xiangzhuo Date: Wed, 13 Nov 2024 16:09:02 +0800 Subject: [PATCH] chore: remove unused code --- freqtrade/exchange/binance_public_data.py | 14 -------------- tests/exchange/test_binance_public_data.py | 8 -------- 2 files changed, 22 deletions(-) diff --git a/freqtrade/exchange/binance_public_data.py b/freqtrade/exchange/binance_public_data.py index 70dfb1df3..33691f962 100644 --- a/freqtrade/exchange/binance_public_data.py +++ b/freqtrade/exchange/binance_public_data.py @@ -87,20 +87,6 @@ async def fetch_ohlcv( return df -def symbol_ccxt_to_binance(symbol: str) -> str: - """ - Convert ccxt symbol notation to binance notation - e.g. BTC/USDT -> BTCUSDT, BTC/USDT:USDT -> BTCUSDT - """ - if ":" in symbol: - parts = symbol.split(":") - if len(parts) != 2: - raise ValueError(f"Cannot recognize symbol: {symbol}") - return parts[0].replace("/", "") - else: - return symbol.replace("/", "") - - def concat(dfs) -> DataFrame: if all(df is None for df in dfs): return DataFrame() diff --git a/tests/exchange/test_binance_public_data.py b/tests/exchange/test_binance_public_data.py index 5fb2fcc67..49caf5f06 100644 --- a/tests/exchange/test_binance_public_data.py +++ b/tests/exchange/test_binance_public_data.py @@ -16,7 +16,6 @@ from freqtrade.exchange.binance_public_data import ( Http404, fetch_ohlcv, get_daily_ohlcv, - symbol_ccxt_to_binance, zip_name, ) from freqtrade.util.datetime_helpers import dt_ts, dt_utc @@ -295,10 +294,3 @@ async def test_get_daily_ohlcv(mocker, testdatadir): ) df = await get_daily_ohlcv("spot", symbol, timeframe, date, session) assert isinstance(df, zipfile.BadZipFile) - - -def test_symbol_ccxt_to_binance(): - assert symbol_ccxt_to_binance("BTC/USDT") == "BTCUSDT" - assert symbol_ccxt_to_binance("BTC/USDT:USDT") == "BTCUSDT" - with pytest.raises(ValueError): - assert symbol_ccxt_to_binance("BTC:USDT:USDT") == "BTCUSDT"