From ce590cced7e9931bad9ad19b946e86c3898faec0 Mon Sep 17 00:00:00 2001 From: Matthias Date: Sat, 21 Feb 2026 20:20:14 +0100 Subject: [PATCH] chore: clarify --export-filename Deprecation messages part of #12846 --- freqtrade/configuration/configuration.py | 23 +++++++++++++++-------- tests/optimize/test_backtesting.py | 3 +++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/freqtrade/configuration/configuration.py b/freqtrade/configuration/configuration.py index c544e47b5..82e93fb91 100644 --- a/freqtrade/configuration/configuration.py +++ b/freqtrade/configuration/configuration.py @@ -221,14 +221,21 @@ class Configuration: config, argname="exportfilename", logstring="Storing backtest results to {} ..." ) config["exportfilename"] = Path(config["exportfilename"]) - if config.get("exportdirectory") and Path(config["exportdirectory"]).is_dir(): - logger.warning( - "DEPRECATED: Using `--export-filename` with directories is deprecated, " - "use `--backtest-directory` instead." - ) - if config.get("exportdirectory") is None: - # Fallback - assign export-directory directly. - config["exportdirectory"] = config["exportfilename"] + if config.get("exportfilename"): + if Path(config["exportfilename"]).is_dir(): + logger.warning( + "DEPRECATED: Using `--export-filename` with directories is deprecated, " + "use `--backtest-directory` instead." + ) + if config.get("exportdirectory") is None: + # Fallback - assign export-directory directly. + config["exportdirectory"] = config["exportfilename"] + elif config.get("runmode") == RunMode.BACKTEST: + logger.warning( + "DEPRECATED: Using `--export-filename` has no impact when backtesting. " + "Please use `--notes` to annotate backtest results and " + "`--backtest-directory` to specify the output directory. " + ) if not config.get("exportdirectory"): config["exportdirectory"] = config["user_data_dir"] / "backtest_results" if not config.get("exportfilename"): diff --git a/tests/optimize/test_backtesting.py b/tests/optimize/test_backtesting.py index bbf55d2bc..270c5b33d 100644 --- a/tests/optimize/test_backtesting.py +++ b/tests/optimize/test_backtesting.py @@ -221,6 +221,9 @@ def test_setup_bt_configuration_with_arguments(mocker, default_conf, caplog) -> assert "exportfilename" in config assert isinstance(config["exportfilename"], Path) assert log_has("Storing backtest results to {} ...".format(config["exportfilename"]), caplog) + assert log_has_re( + "DEPRECATED: Using `--export-filename` has no impact when backtesting.*", caplog + ) assert "fee" in config assert log_has("Parameter --fee detected, setting fee to: {} ...".format(config["fee"]), caplog)