From 9f8539f13e05f35b3130d2d6f9d6d7ef60b8f8ae Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 13:21:25 -0800 Subject: [PATCH 01/11] Remove unused code on Strategy interface --- freqtrade/strategy/interface.py | 7 ------- freqtrade/strategy/strategy.py | 14 ++++---------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/freqtrade/strategy/interface.py b/freqtrade/strategy/interface.py index 9281e72ca..dc9f33244 100644 --- a/freqtrade/strategy/interface.py +++ b/freqtrade/strategy/interface.py @@ -17,13 +17,6 @@ class IStrategy(ABC): stoploss -> float: optimal stoploss designed for the strategy ticker_interval -> int: value of the ticker interval to use for the strategy """ - @property - def name(self) -> str: - """ - Name of the strategy. - :return: str representation of the class name - """ - return self.__class__.__name__ @abstractmethod def populate_indicators(self, dataframe: DataFrame) -> DataFrame: diff --git a/freqtrade/strategy/strategy.py b/freqtrade/strategy/strategy.py index 97e260ee8..427c24fc6 100644 --- a/freqtrade/strategy/strategy.py +++ b/freqtrade/strategy/strategy.py @@ -1,3 +1,5 @@ +# pragma pylint: disable=attribute-defined-outside-init + """ This module load custom strategies """ @@ -21,7 +23,7 @@ class Strategy(object): DEFAULT_STRATEGY = 'default_strategy' - def __new__(cls): + def __new__(cls) -> object: """ Used to create the Singleton :return: Strategy object @@ -30,15 +32,7 @@ class Strategy(object): Strategy.__instance = object.__new__(cls) return Strategy.__instance - def __init__(self): - if Strategy.__instance is None: - self.logger = None - self.minimal_roi = None - self.stoploss = None - self.ticker_interval = None - self.custom_strategy = None - - def init(self, config): + def init(self, config: dict) -> None: """ Load the custom class from config parameter :param config: From 45a34be2acd0af862411e2bdc4d18630f115ac09 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 14:20:20 -0800 Subject: [PATCH 02/11] Add more unittest for trim_tickerlist() method --- freqtrade/tests/optimize/test_optimize.py | 40 ++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/freqtrade/tests/optimize/test_optimize.py b/freqtrade/tests/optimize/test_optimize.py index 646959669..a8d118176 100644 --- a/freqtrade/tests/optimize/test_optimize.py +++ b/freqtrade/tests/optimize/test_optimize.py @@ -1,12 +1,13 @@ # pragma pylint: disable=missing-docstring, protected-access, C0103 import os +import json import logging from shutil import copyfile from freqtrade import exchange, optimize from freqtrade.exchange import Bittrex from freqtrade.optimize.__init__ import make_testdata_path, download_pairs,\ - download_backtesting_testdata, load_tickerdata_file + download_backtesting_testdata, load_tickerdata_file, trim_tickerlist # Change this if modifying BTC_UNITEST testdatafile _BTC_UNITTEST_LENGTH = 13681 @@ -220,3 +221,40 @@ def test_tickerdata_to_dataframe(): tickerlist = {'BTC_UNITEST': tick} data = optimize.tickerdata_to_dataframe(tickerlist) assert len(data['BTC_UNITEST']) == 100 + + +def test_trim_tickerlist(): + with open('freqtrade/tests/testdata/BTC_ETH-1.json') as data_file: + ticker_list = json.load(data_file) + ticker_list_len = len(ticker_list) + + # Test the pattern ^(-\d+)$ + # This pattern remove X element from the beginning + timerange = ((None, 'line'), None, 5) + ticker = trim_tickerlist(ticker_list, timerange) + ticker_len = len(ticker) + + assert ticker_list_len == ticker_len + 5 + assert ticker_list[0] is not ticker[0] # The first element should be different + assert ticker_list[-1] is ticker[-1] # The last element must be the same + + # Test the pattern ^(\d+)-$ + # This pattern keep X element from the end + timerange = (('line', None), 5, None) + ticker = trim_tickerlist(ticker_list, timerange) + ticker_len = len(ticker) + + assert ticker_len == 5 + assert ticker_list[0] is ticker[0] # The first element must be the same + assert ticker_list[-1] is not ticker[-1] # The last element should be different + + # Test the pattern ^(\d+)-(\d+)$ + # This pattern extract a window + timerange = (('index', 'index'), 5, 10) + ticker = trim_tickerlist(ticker_list, timerange) + ticker_len = len(ticker) + + assert ticker_len == 5 + assert ticker_list[0] is not ticker[0] # The first element should be different + assert ticker_list[5] is ticker[0] # The list starts at the index 5 + assert ticker_list[9] is ticker[-1] # The list ends at the index 9 (5 elements) From 2bccaa31c979db78d8330501f43e035f1564b1f3 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 14:28:28 -0800 Subject: [PATCH 03/11] Increase pylint score on misc.py --- freqtrade/misc.py | 28 ++++++++++++++-------------- freqtrade/optimize/__init__.py | 3 +-- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/freqtrade/misc.py b/freqtrade/misc.py index 7a1631737..cf2db1004 100644 --- a/freqtrade/misc.py +++ b/freqtrade/misc.py @@ -60,7 +60,7 @@ def common_datearray(dfs): return np.sort(arr, axis=0) -def file_dump_json(filename, data): +def file_dump_json(filename, data) -> None: with open(filename, 'w') as fp: json.dump(data, fp) @@ -287,27 +287,27 @@ def hyperopt_options(parser: argparse.ArgumentParser) -> None: def parse_timerange(text): if text is None: return None - syntax = [('^-(\d{8})$', (None, 'date')), - ('^(\d{8})-$', ('date', None)), - ('^(\d{8})-(\d{8})$', ('date', 'date')), - ('^(-\d+)$', (None, 'line')), - ('^(\d+)-$', ('line', None)), - ('^(\d+)-(\d+)$', ('index', 'index'))] + syntax = [(r'^-(\d{8})$', (None, 'date')), + (r'^(\d{8})-$', ('date', None)), + (r'^(\d{8})-(\d{8})$', ('date', 'date')), + (r'^(-\d+)$', (None, 'line')), + (r'^(\d+)-$', ('line', None)), + (r'^(\d+)-(\d+)$', ('index', 'index'))] for rex, stype in syntax: # Apply the regular expression to text - m = re.match(rex, text) - if m: # Regex has matched - rvals = m.groups() - n = 0 + match = re.match(rex, text) + if match: # Regex has matched + rvals = match.groups() + index = 0 start = None stop = None if stype[0]: - start = rvals[n] + start = rvals[index] if stype[0] != 'date': start = int(start) - n += 1 + index += 1 if stype[1]: - stop = rvals[n] + stop = rvals[index] if stype[1] != 'date': stop = int(stop) return (stype, start, stop) diff --git a/freqtrade/optimize/__init__.py b/freqtrade/optimize/__init__.py index a0eb5b8a2..3c30ed5b9 100644 --- a/freqtrade/optimize/__init__.py +++ b/freqtrade/optimize/__init__.py @@ -26,8 +26,7 @@ def trim_tickerlist(tickerlist, timerange): return tickerlist -def load_tickerdata_file(datadir, pair, ticker_interval, - timerange=None): +def load_tickerdata_file(datadir, pair, ticker_interval, timerange=None): """ Load a pair from file, :return dict OR empty if unsuccesful From d85b56a2bd7fd7ccfab333665b83db51ee3b2cb2 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 14:38:17 -0800 Subject: [PATCH 04/11] Add unit test for test_file_dump_json() --- freqtrade/tests/optimize/test_optimize.py | 28 ++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/freqtrade/tests/optimize/test_optimize.py b/freqtrade/tests/optimize/test_optimize.py index a8d118176..40fe07c87 100644 --- a/freqtrade/tests/optimize/test_optimize.py +++ b/freqtrade/tests/optimize/test_optimize.py @@ -3,11 +3,12 @@ import os import json import logging +import uuid from shutil import copyfile from freqtrade import exchange, optimize from freqtrade.exchange import Bittrex from freqtrade.optimize.__init__ import make_testdata_path, download_pairs,\ - download_backtesting_testdata, load_tickerdata_file, trim_tickerlist + download_backtesting_testdata, load_tickerdata_file, trim_tickerlist, file_dump_json # Change this if modifying BTC_UNITEST testdatafile _BTC_UNITTEST_LENGTH = 13681 @@ -258,3 +259,28 @@ def test_trim_tickerlist(): assert ticker_list[0] is not ticker[0] # The first element should be different assert ticker_list[5] is ticker[0] # The list starts at the index 5 assert ticker_list[9] is ticker[-1] # The list ends at the index 9 (5 elements) + + +def test_file_dump_json(): + + file = 'freqtrade/tests/testdata/test_{id}.json'.format(id=str(uuid.uuid4())) + data = { 'bar': 'foo'} + + # check the file we will create does not exist + assert os.path.isfile(file) is False + + # Create the Json file + file_dump_json(file, data) + + # Check the file was create + assert os.path.isfile(file) is True + + # Open the Json file created and test the data is in it + with open(file) as data_file: + json_from_file = json.load(data_file) + + assert 'bar' in json_from_file + assert json_from_file['bar'] == 'foo' + + # Remove the file + _clean_test_file(file) From 25ab08f42282b2a06915478fd7f29366ee546426 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 15:03:54 -0800 Subject: [PATCH 05/11] Fix Flake8 warning --- freqtrade/tests/optimize/test_optimize.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/freqtrade/tests/optimize/test_optimize.py b/freqtrade/tests/optimize/test_optimize.py index 40fe07c87..3247ca7c0 100644 --- a/freqtrade/tests/optimize/test_optimize.py +++ b/freqtrade/tests/optimize/test_optimize.py @@ -264,7 +264,7 @@ def test_trim_tickerlist(): def test_file_dump_json(): file = 'freqtrade/tests/testdata/test_{id}.json'.format(id=str(uuid.uuid4())) - data = { 'bar': 'foo'} + data = {'bar': 'foo'} # check the file we will create does not exist assert os.path.isfile(file) is False From fd9c62d1c4c692da8015dd6a4a72123a07ac1491 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 15:16:13 -0800 Subject: [PATCH 06/11] Increase test coverage on strategy.py --- freqtrade/tests/strategy/test_strategy.py | 1 + 1 file changed, 1 insertion(+) diff --git a/freqtrade/tests/strategy/test_strategy.py b/freqtrade/tests/strategy/test_strategy.py index 8a2a21f41..dd772f784 100644 --- a/freqtrade/tests/strategy/test_strategy.py +++ b/freqtrade/tests/strategy/test_strategy.py @@ -16,6 +16,7 @@ def test_sanitize_module_name(): def test_search_strategy(): assert Strategy._search_strategy('default_strategy') == '.' + assert Strategy._search_strategy('test_strategy') == 'user_data.strategies.' assert Strategy._search_strategy('super_duper') is None From df453803cef69a48f967382697303d22f0d7ab79 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 15:29:26 -0800 Subject: [PATCH 07/11] Increase test coverage on rpc_telegram.py --- freqtrade/tests/rpc/test_rpc_telegram.py | 29 ++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/freqtrade/tests/rpc/test_rpc_telegram.py b/freqtrade/tests/rpc/test_rpc_telegram.py index 34d92b43e..8ed12440d 100644 --- a/freqtrade/tests/rpc/test_rpc_telegram.py +++ b/freqtrade/tests/rpc/test_rpc_telegram.py @@ -406,8 +406,7 @@ def test_performance_handle( assert 'BTC_ETH\t6.20% (1)' in msg_mock.call_args_list[0][0][0] -def test_daily_handle( - default_conf, update, ticker, limit_buy_order, limit_sell_order, mocker): +def test_daily_handle(default_conf, update, ticker, limit_buy_order, limit_sell_order, mocker): mocker.patch.dict('freqtrade.main._CONF', default_conf) mocker.patch('freqtrade.main.get_signal', side_effect=lambda s, t: (True, False)) msg_mock = MagicMock() @@ -470,6 +469,25 @@ def test_daily_handle( assert str(' 2.798 USD') in msg_mock.call_args_list[0][0][0] assert str(' 3 trades') in msg_mock.call_args_list[0][0][0] + +def test_daily_wrong_input(default_conf, update, ticker, mocker): + mocker.patch.dict('freqtrade.main._CONF', default_conf) + mocker.patch('freqtrade.main.get_signal', side_effect=lambda s, t: (True, False)) + msg_mock = MagicMock() + mocker.patch('freqtrade.main.rpc.send_msg', MagicMock()) + mocker.patch.multiple('freqtrade.rpc.telegram', + _CONF=default_conf, + init=MagicMock(), + send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.exchange', + validate_pairs=MagicMock(), + get_ticker=ticker) + mocker.patch.multiple('freqtrade.fiat_convert.Pymarketcap', + ticker=MagicMock(return_value={'price_usd': 15000.0}), + _cache_symbols=MagicMock(return_value={'BTC': 1})) + mocker.patch('freqtrade.fiat_convert.CryptoToFiatConverter._find_price', return_value=15000.0) + init(default_conf, create_engine('sqlite://')) + # Try invalid data msg_mock.reset_mock() update_state(State.RUNNING) @@ -478,6 +496,13 @@ def test_daily_handle( assert msg_mock.call_count == 1 assert 'must be an integer greater than 0' in msg_mock.call_args_list[0][0][0] + # Try invalid data + msg_mock.reset_mock() + update_state(State.RUNNING) + update.message.text = '/daily today' + _daily(bot=MagicMock(), update=update) + assert str('Daily Profit over the last 7 days') in msg_mock.call_args_list[0][0][0] + def test_count_handle(default_conf, update, ticker, mocker): mocker.patch.dict('freqtrade.main._CONF', default_conf) From 7ab2498544a02358a9fa4df3fe05821090b54eb2 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 15:33:57 -0800 Subject: [PATCH 08/11] Increase test coverage on optimize.py --- freqtrade/tests/optimize/test_optimize.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/freqtrade/tests/optimize/test_optimize.py b/freqtrade/tests/optimize/test_optimize.py index 3247ca7c0..e893e4826 100644 --- a/freqtrade/tests/optimize/test_optimize.py +++ b/freqtrade/tests/optimize/test_optimize.py @@ -260,6 +260,14 @@ def test_trim_tickerlist(): assert ticker_list[5] is ticker[0] # The list starts at the index 5 assert ticker_list[9] is ticker[-1] # The list ends at the index 9 (5 elements) + # Test a wrong pattern + # This pattern must return the list unchanged + timerange = ((None, None), None, 5) + ticker = trim_tickerlist(ticker_list, timerange) + ticker_len = len(ticker) + + assert ticker_list_len == ticker_len + def test_file_dump_json(): From 36fa5b827d95faf5cf09f64243324afdbe6023fe Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 16:18:10 -0800 Subject: [PATCH 09/11] Add unit test on rpc_telegram.py --- freqtrade/tests/rpc/test_rpc_telegram.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/freqtrade/tests/rpc/test_rpc_telegram.py b/freqtrade/tests/rpc/test_rpc_telegram.py index 8ed12440d..6541f2820 100644 --- a/freqtrade/tests/rpc/test_rpc_telegram.py +++ b/freqtrade/tests/rpc/test_rpc_telegram.py @@ -716,3 +716,18 @@ def test_send_msg_network_error(default_conf, mocker): # Bot should've tried to send it twice assert len(bot.method_calls) == 2 + + +def test_init(default_conf, update, ticker, limit_buy_order, limit_sell_order, mocker): + mocker.patch.dict('freqtrade.main._CONF', default_conf) + mocker.patch('freqtrade.main.get_signal', side_effect=lambda s, t: (True, False)) + msg_mock = MagicMock() + mocker.patch('freqtrade.main.rpc.send_msg', MagicMock()) + mocker.patch.multiple('freqtrade.rpc.telegram', + _CONF=default_conf, + init=MagicMock(), + send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.exchange', + validate_pairs=MagicMock(), + get_ticker=ticker) + init(default_conf, create_engine('sqlite://')) \ No newline at end of file From 3e777a9d87dde23ff95ec60a0f00385fd48ac630 Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 16:25:15 -0800 Subject: [PATCH 10/11] Add unit test in misc.py to cover datesarray_to_datetimearray() --- freqtrade/tests/test_misc.py | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/freqtrade/tests/test_misc.py b/freqtrade/tests/test_misc.py index 96743dfab..442e267df 100644 --- a/freqtrade/tests/test_misc.py +++ b/freqtrade/tests/test_misc.py @@ -5,11 +5,13 @@ import time from copy import deepcopy from unittest.mock import MagicMock +import datetime import pytest from jsonschema import ValidationError - +from freqtrade.analyze import parse_ticker_dataframe from freqtrade.misc import (common_args_parser, file_dump_json, load_config, - parse_args, parse_timerange, throttle) + parse_args, parse_timerange, throttle, datesarray_to_datetimearray, + common_datearray) def test_throttle(): @@ -178,3 +180,18 @@ def test_load_config_missing_attributes(default_conf, mocker): read_data=json.dumps(conf))) with pytest.raises(ValidationError, match=r'.*\'exchange\' is a required property.*'): load_config('somefile') + + +def test_datesarray_to_datetimearray(ticker_history): + dataframes = parse_ticker_dataframe(ticker_history) + dates = datesarray_to_datetimearray(dataframes['date']) + + assert isinstance(dates[0], datetime.datetime) + assert dates[0].year == 2017 + assert dates[0].month == 11 + assert dates[0].day == 26 + assert dates[0].hour == 8 + assert dates[0].minute == 50 + + date_len = len(dates) + assert date_len == 3 From 20af5049af4a84daaefe8af767c1ff5a1bb4673d Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 28 Jan 2018 16:34:38 -0800 Subject: [PATCH 11/11] Thanks Flake8 --- freqtrade/tests/rpc/test_rpc_telegram.py | 2 +- freqtrade/tests/test_misc.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/freqtrade/tests/rpc/test_rpc_telegram.py b/freqtrade/tests/rpc/test_rpc_telegram.py index 6541f2820..7b1f656d6 100644 --- a/freqtrade/tests/rpc/test_rpc_telegram.py +++ b/freqtrade/tests/rpc/test_rpc_telegram.py @@ -730,4 +730,4 @@ def test_init(default_conf, update, ticker, limit_buy_order, limit_sell_order, m mocker.patch.multiple('freqtrade.main.exchange', validate_pairs=MagicMock(), get_ticker=ticker) - init(default_conf, create_engine('sqlite://')) \ No newline at end of file + init(default_conf, create_engine('sqlite://')) diff --git a/freqtrade/tests/test_misc.py b/freqtrade/tests/test_misc.py index 442e267df..c0d4db7a1 100644 --- a/freqtrade/tests/test_misc.py +++ b/freqtrade/tests/test_misc.py @@ -10,8 +10,7 @@ import pytest from jsonschema import ValidationError from freqtrade.analyze import parse_ticker_dataframe from freqtrade.misc import (common_args_parser, file_dump_json, load_config, - parse_args, parse_timerange, throttle, datesarray_to_datetimearray, - common_datearray) + parse_args, parse_timerange, throttle, datesarray_to_datetimearray) def test_throttle():