From 92405f94ec7caf4bae007b6bc522476faf2d66f6 Mon Sep 17 00:00:00 2001 From: Matthias Date: Thu, 30 Jan 2025 07:13:03 +0100 Subject: [PATCH] test: further add tests for public trades dl --- freqtrade/exchange/binance_public_data.py | 2 +- tests/exchange/test_binance_public_data.py | 12 +++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/freqtrade/exchange/binance_public_data.py b/freqtrade/exchange/binance_public_data.py index cbb69b675..565317a53 100644 --- a/freqtrade/exchange/binance_public_data.py +++ b/freqtrade/exchange/binance_public_data.py @@ -325,7 +325,7 @@ async def download_archive_trades( except Exception as e: logger.warning( - "An exception occurred during fast traes download from Binance, falling back to " + "An exception occurred during fast trades download from Binance, falling back to " "the slower REST API, this can take a lot more time.", exc_info=e, ) diff --git a/tests/exchange/test_binance_public_data.py b/tests/exchange/test_binance_public_data.py index 24346d546..ab299321b 100644 --- a/tests/exchange/test_binance_public_data.py +++ b/tests/exchange/test_binance_public_data.py @@ -395,7 +395,7 @@ async def test_download_archive_trades(mocker, caplog): assert log_has_re(r"Binance fast download .*stopped", caplog) -async def test_download_archive_trades_exception(mocker): +async def test_download_archive_trades_exception(mocker, caplog): pair = "BTC/USDT" since_ms = dt_ts(dt_utc(2020, 1, 1)) @@ -412,6 +412,16 @@ async def test_download_archive_trades_exception(mocker): assert pair1 == pair assert res == [] + mocker.patch( + "freqtrade.exchange.binance_public_data._download_archive_trades", side_effect=RuntimeError + ) + + await download_archive_trades( + CandleType.SPOT, pair, since_ms=since_ms, until_ms=until_ms, markets=markets + ) + assert pair1 == pair + assert res == [] + assert log_has_re("An exception occurred during fast trades download", caplog) async def test_binance_vision_trades_zip_url():