CTYPTO/freqtrade
1
0
Fork 0
mirror of https://github.com/freqtrade/freqtrade.git synced 2025-12-17 05:11:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improved message when nonexisting trade is deleted

Browse Source 
part of #11967
This commit is contained in:
Matthias
2025-07-07 19:13:55 +02:00
parent 14429d449c
commit 60029c2a8b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
freqtrade/rpc/rpc.py
View File

@@ -1094,7 +1094,7 @@ class RPC:
trade = Trade.get_trades(trade_filter=[Trade.id == trade_id]).first() trade = Trade.get_trades(trade_filter=[Trade.id == trade_id]).first()
if not trade: if not trade:
logger.warning("delete trade: Invalid argument received") logger.warning("delete trade: Invalid argument received")
raise RPCException("invalid argument") raise RPCException(f"Trade with id '{trade_id}' not found.")
# Try cancelling regular order if that exists # Try cancelling regular order if that exists
for open_order in trade.open_orders: for open_order in trade.open_orders:

2
tests/rpc/test_rpc.py
View File

@@ -393,7 +393,7 @@ def test_rpc_delete_trade(mocker, default_conf, fee, markets, caplog, is_short):
freqtradebot.strategy.order_types["stoploss_on_exchange"] = True freqtradebot.strategy.order_types["stoploss_on_exchange"] = True
create_mock_trades(fee, is_short) create_mock_trades(fee, is_short)
rpc = RPC(freqtradebot) rpc = RPC(freqtradebot)
with pytest.raises(RPCException, match="invalid argument"): with pytest.raises(RPCException, match="Trade with id '200' not found."):
rpc._rpc_delete("200") rpc._rpc_delete("200")
trades = Trade.session.scalars(select(Trade)).all() trades = Trade.session.scalars(select(Trade)).all()