From 45e75f3d090effa18377ce0de4f94c4f5f9d1a1d Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Fri, 30 Aug 2024 17:59:22 +0200
Subject: [PATCH] chore: improve arguments to get_liquidation_price

---
 freqtrade/exchange/exchange.py          | 4 ++--
 freqtrade/leverage/liquidation_price.py | 1 -
 tests/exchange/test_binance.py          | 2 --
 tests/exchange/test_exchange.py         | 4 ----
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py
index 83aff2def..d6149745a 100644
--- a/freqtrade/exchange/exchange.py
+++ b/freqtrade/exchange/exchange.py
@@ -3532,7 +3532,7 @@ class Exchange:
         stake_amount: float,
         leverage: float,
         wallet_balance: float,
-        other_trades: list,
+        other_trades: Optional[list] = None,
     ) -> Optional[float]:
         """
         Set's the margin mode on the exchange to cross or isolated for a specific pair
@@ -3554,7 +3554,7 @@ class Exchange:
                 leverage=leverage,
                 stake_amount=stake_amount,
                 wallet_balance=wallet_balance,
-                other_trades=other_trades,
+                other_trades=other_trades or [],
             )
         else:
             positions = self.fetch_positions(pair)
diff --git a/freqtrade/leverage/liquidation_price.py b/freqtrade/leverage/liquidation_price.py
index 89d5d1a36..e2fb167c8 100644
--- a/freqtrade/leverage/liquidation_price.py
+++ b/freqtrade/leverage/liquidation_price.py
@@ -56,7 +56,6 @@ def update_liquidation_prices(
                     stake_amount=trade.stake_amount,
                     leverage=trade.leverage,
                     wallet_balance=trade.stake_amount,
-                    other_trades=[],
                 )
             )
         else:
diff --git a/tests/exchange/test_binance.py b/tests/exchange/test_binance.py
index 96f3e6a5b..983a499dd 100644
--- a/tests/exchange/test_binance.py
+++ b/tests/exchange/test_binance.py
@@ -294,8 +294,6 @@ def test_liquidation_price_binance(
                     stake_amount=open_rate * amount,
                     leverage=5,
                     other_trades=other_contracts,
-                    # mm_ex_1=mm_ex_1,
-                    # upnl_ex_1=upnl_ex_1,
                 ),
                 2,
             )
diff --git a/tests/exchange/test_exchange.py b/tests/exchange/test_exchange.py
index 56a967e5a..7535822c3 100644
--- a/tests/exchange/test_exchange.py
+++ b/tests/exchange/test_exchange.py
@@ -5524,7 +5524,6 @@ def test_liquidation_price_is_none(
             stake_amount=open_rate * 71200.81144,
             leverage=5,
             wallet_balance=-56354.57,
-            other_trades=[],
         )
         is None
     )
@@ -5970,7 +5969,6 @@ def test_get_liquidation_price1(mocker, default_conf):
         stake_amount=18.884 * 0.8,
         leverage=leverage,
         wallet_balance=18.884 * 0.8,
-        other_trades=[],
     )
     assert liq_price == 17.47
 
@@ -5984,7 +5982,6 @@ def test_get_liquidation_price1(mocker, default_conf):
         stake_amount=18.884 * 0.8,
         leverage=leverage,
         wallet_balance=18.884 * 0.8,
-        other_trades=[],
     )
     assert liq_price == 17.540699999999998
 
@@ -5998,7 +5995,6 @@ def test_get_liquidation_price1(mocker, default_conf):
         stake_amount=18.884 * 0.8,
         leverage=leverage,
         wallet_balance=18.884 * 0.8,
-        other_trades=[],
     )
     assert liq_price is None
     default_conf["trading_mode"] = "margin"