From 30b4f271522f233fe50ecd9e8b67e6120446d581 Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Sun, 3 Mar 2024 12:46:46 +0100
Subject: [PATCH] Cleanup some nitpicks

---
 freqtrade/persistence/custom_data.py  | 1 +
 freqtrade/persistence/trade_model.py  | 4 +---
 tests/persistence/test_persistence.py | 1 +
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/freqtrade/persistence/custom_data.py b/freqtrade/persistence/custom_data.py
index 3ebcd0f48..81a9e7ad6 100644
--- a/freqtrade/persistence/custom_data.py
+++ b/freqtrade/persistence/custom_data.py
@@ -107,6 +107,7 @@ class CustomDataWrapper:
     @staticmethod
     def delete_custom_data(trade_id: int) -> None:
         _CustomData.session.query(_CustomData).filter(_CustomData.ft_trade_id == trade_id).delete()
+        _CustomData.session.commit()
 
     @staticmethod
     def get_custom_data(*, trade_id: int, key: Optional[str] = None) -> List[_CustomData]:
diff --git a/freqtrade/persistence/trade_model.py b/freqtrade/persistence/trade_model.py
index 06a6e818d..e74bc1f48 100644
--- a/freqtrade/persistence/trade_model.py
+++ b/freqtrade/persistence/trade_model.py
@@ -343,7 +343,6 @@ class LocalTrade:
     id: int = 0
 
     orders: List[Order] = []
-    custom_data: List[_CustomData] = []
 
     exchange: str = ''
     pair: str = ''
@@ -1507,7 +1506,7 @@ class Trade(ModelBase, LocalTrade):
         innerjoin=True)  # type: ignore
     custom_data: Mapped[List[_CustomData]] = relationship(
         "_CustomData", cascade="all, delete-orphan",
-        lazy="raise")  # type: ignore
+        lazy="raise")
 
     exchange: Mapped[str] = mapped_column(String(25), nullable=False)  # type: ignore
     pair: Mapped[str] = mapped_column(String(25), nullable=False, index=True)  # type: ignore
@@ -1613,7 +1612,6 @@ class Trade(ModelBase, LocalTrade):
 
         CustomDataWrapper.delete_custom_data(trade_id=self.id)
 
-        _CustomData.session.commit()
         Trade.session.delete(self)
         Trade.commit()
 
diff --git a/tests/persistence/test_persistence.py b/tests/persistence/test_persistence.py
index 0e0e70ee8..18f28da2b 100644
--- a/tests/persistence/test_persistence.py
+++ b/tests/persistence/test_persistence.py
@@ -2099,6 +2099,7 @@ def test_Trade_object_idem():
         'get_mix_tag_performance',
         'get_trading_volume',
         'validate_string_len',
+        'custom_data'
     )
     EXCLUDES2 = ('trades', 'trades_open', 'bt_trades_open_pp', 'bt_open_open_trade_count',
                  'total_profit', 'from_json',)