From 6b8968ed0f3f867fe3f0847e8bab251cd73a178d Mon Sep 17 00:00:00 2001 From: Matthias Date: Tue, 25 Nov 2025 19:18:22 +0100 Subject: [PATCH 1/2] chore(ci): restructure CI to reliably fail the build step if other checks failed --- .github/workflows/ci.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0156758eb..ea55c675d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -306,11 +306,18 @@ jobs: webhookUrl: ${{ secrets.DISCORD_WEBHOOK }} build: + if: always() name: "Build" needs: [ tests, docs-check, mypy-version-check, pre-commit ] runs-on: ubuntu-22.04 steps: + + - name: Decide whether the needed jobs succeeded or failed + uses: re-actors/alls-green@05ac9388f0aebcb5727afa17fcccfecd6f8ec5fe # v1.2.2 + with: + jobs: ${{ toJSON(needs) }} + - uses: actions/checkout@v5 with: persist-credentials: false @@ -405,10 +412,7 @@ jobs: docker-build: name: "Docker Build and Deploy" needs: [ - tests, - docs-check, - mypy-version-check, - pre-commit + build, ] if: (github.event_name == 'push' || github.event_name == 'schedule' || github.event_name == 'release') && github.repository == 'freqtrade/freqtrade' uses: ./.github/workflows/docker-build.yml From f4920f199cc7c84187e60bbd959aef676361d7db Mon Sep 17 00:00:00 2001 From: Matthias Date: Tue, 25 Nov 2025 19:44:10 +0100 Subject: [PATCH 2/2] chore(ci): only notify after build. --- .github/workflows/ci.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ea55c675d..14a55ff7a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -275,10 +275,7 @@ jobs: # Notify only once - when CI completes (and after deploy) in case it's successful notify-complete: needs: [ - tests, - docs-check, - mypy-version-check, - pre-commit, + build, build-linux-online ] runs-on: ubuntu-22.04 @@ -308,7 +305,12 @@ jobs: build: if: always() name: "Build" - needs: [ tests, docs-check, mypy-version-check, pre-commit ] + needs: [ + tests, + docs-check, + mypy-version-check, + pre-commit, + ] runs-on: ubuntu-22.04 steps: