From 1b2cfc9857bcb0b0fc4fd38d13205360701e9266 Mon Sep 17 00:00:00 2001 From: Matthias Date: Tue, 11 Jun 2024 19:53:22 +0200 Subject: [PATCH] Simplify generate_tag_metrics logic --- freqtrade/optimize/optimize_reports/optimize_reports.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/freqtrade/optimize/optimize_reports/optimize_reports.py b/freqtrade/optimize/optimize_reports/optimize_reports.py index abb831d36..d0d50abf0 100644 --- a/freqtrade/optimize/optimize_reports/optimize_reports.py +++ b/freqtrade/optimize/optimize_reports/optimize_reports.py @@ -157,12 +157,11 @@ def generate_tag_metrics( tabular_data = [] if tag_type in results.columns: - for tag, count in results[tag_type].value_counts().items(): - result = results[results[tag_type] == tag] - if skip_nan and result["profit_abs"].isnull().all(): + for tags, group in results.groupby(tag_type): + if skip_nan and group["profit_abs"].isnull().all(): continue - tabular_data.append(_generate_result_line(result, starting_balance, tag)) + tabular_data.append(_generate_result_line(group, starting_balance, tags)) # Sort by total profit %: tabular_data = sorted(tabular_data, key=lambda k: k["profit_total_abs"], reverse=True)