feat: don't auto-delete trades data due to invalid timerange

trades-data is already slow enough to download

freqtrade/data/history/history_utils.py

@@ -345,7 +345,7 @@ def refresh_backtest_ohlcv_data(
             progress.update(timeframe_task, completed=0)
 
             if pair not in exchange.markets:
-                pairs_not_available.append(pair)
+                pairs_not_available.append(f"{pair}: Pair not available on exchange.")
                 logger.info(f"Skipping pair {pair}...")
                 continue
             for timeframe in timeframes:
@@ -411,7 +411,6 @@ def _download_trades_history(
     Download trade history from the exchange.
     Appends to previously downloaded trades data.
     """
-    try:
     until = None
     since = 0
     if timerange:
@@ -428,11 +427,11 @@ def _download_trades_history(
 
     if not trades.empty and since > 0 and since < trades.iloc[0]["timestamp"]:
         # since is before the first trade
-            logger.info(
-                f"Start ({trades.iloc[0]['date']:{DATETIME_PRINT_FORMAT}}) earlier than "
-                f"available data. Redownloading trades for {pair}..."
+        raise ValueError(
+            f"Start {format_ms_time(since)} earlier than "
+            f"available data ({trades.iloc[0]['date']:{DATETIME_PRINT_FORMAT}}). "
+            f"Please use `--erase` if you'd like to redownload {pair}."
         )
-            trades = trades_list_to_df([])
 
     from_id = trades.iloc[-1]["id"] if not trades.empty else None
     if not trades.empty and since < trades.iloc[-1]["timestamp"]:
@@ -481,10 +480,6 @@ def _download_trades_history(
     logger.info(f"New Amount of trades: {len(trades)}")
     return True
 
-    except Exception:
-        logger.exception(f'Failed to download and store historic trades for pair: "{pair}". ')
-        return False
-
 
 def refresh_backtest_trades_data(
     exchange: Exchange,
@@ -508,7 +503,7 @@ def refresh_backtest_trades_data(
         for pair in pairs:
             progress.update(pair_task, description=f"Downloading trades [{pair}]")
             if pair not in exchange.markets:
-                pairs_not_available.append(pair)
+                pairs_not_available.append(f"{pair}: Pair not available on exchange.")
                 logger.info(f"Skipping pair {pair}...")
                 continue
 
@@ -517,6 +512,7 @@ def refresh_backtest_trades_data(
                     logger.info(f"Deleting existing data for pair {pair}.")
 
             logger.info(f"Downloading trades for pair {pair}.")
+            try:
                 _download_trades_history(
                     exchange=exchange,
                     pair=pair,
@@ -525,6 +521,13 @@ def refresh_backtest_trades_data(
                     data_handler=data_handler,
                     trading_mode=trading_mode,
                 )
+            except ValueError as e:
+                pairs_not_available.append(f"{pair}: {str(e)}")
+            except Exception:
+                logger.exception(
+                    f'Failed to download and store historic trades for pair: "{pair}". '
+                )
+
             progress.update(pair_task, advance=1)
 
     return pairs_not_available
@@ -674,7 +677,7 @@ def download_data_main(config: Config) -> None:
             )
     finally:
         if pairs_not_available:
-            logger.info(
-                f"Pairs [{','.join(pairs_not_available)}] not available "
-                f"on exchange {exchange.name}."
+            logger.warning(
+                f"Encountered a problem downloading the following pairs from {exchange.name}: \n"
+                f"{'\n'.join(pairs_not_available)}"
             )